Merge pull request #89 from 3270io/claude/demo-screen-recordings-edsqd9

Record the profiler and MCP demos, and fix what stopped the profiler running

Author: jnnngs

connect3270/emulator.go

@@ -239,11 +239,11 @@ func (e *Emulator) WaitForField(timeout time.Duration, maxRetries int) error {
 	unlockOutput, unlockErr := e.execCommand(unlockCommand)
 
 	// Query keyboard lock state after Wait(timeout, Unlock)
-	       if kbLockState, kbErr := e.query("KeyboardLock"); kbErr == nil {
-		       if Verbose {
-			       log.Printf("Keyboard lock state after Unlock wait: %s", kbLockState)
-		       }
-	       }
+	if kbLockState, kbErr := e.query("KeyboardLock"); kbErr == nil {
+		if Verbose {
+			log.Printf("Keyboard lock state after Unlock wait: %s", kbLockState)
+		}
+	}
 
 	// Check if unlock failed or status is not "U"
 	needsReset := false
@@ -262,13 +262,13 @@ func (e *Emulator) WaitForField(timeout time.Duration, maxRetries int) error {
 			// Retry unlock after reset
 			time.Sleep(retryDelay)
 			unlockOutput, unlockErr = e.execCommand(unlockCommand)
-			
+
 			// Query keyboard lock state again after reset
-			       if kbLockState, kbErr := e.query("KeyboardLock"); kbErr == nil {
-				       if Verbose {
-					       log.Printf("Keyboard lock state after Reset and Unlock: %s", kbLockState)
-				       }
-			       }
+			if kbLockState, kbErr := e.query("KeyboardLock"); kbErr == nil {
+				if Verbose {
+					log.Printf("Keyboard lock state after Reset and Unlock: %s", kbLockState)
+				}
+			}
 		}
 	}
 
@@ -279,12 +279,12 @@ func (e *Emulator) WaitForField(timeout time.Duration, maxRetries int) error {
 	for retries := 0; retries < maxRetries; retries++ {
 		output, err := e.execCommand(command)
 		if err == nil {
-			       if output == "" {
-				       if Verbose {
-					       log.Println("Wait command executed successfully (no output)")
-				       }
-				       return nil
-			       }
+			if output == "" {
+				if Verbose {
+					log.Println("Wait command executed successfully (no output)")
+				}
+				return nil
+			}
 
 			// Extract the keyboard status from the command output
 			statusParts := strings.Fields(output)
@@ -511,6 +511,16 @@ func (e *Emulator) GetValue(x, y, length int) (string, error) {
 	return "", fmt.Errorf("maximum GetValue retries reached")
 }
 
+// NormalizeQueryResponse reduces a raw Query reply to the value it carries.
+//
+// s3270 answers on the scripting protocol with the value on a "data:" line
+// followed by a status line and "ok". Callers that want to parse the value —
+// the host compatibility profiler is one — need the value alone, and Query
+// deliberately hands back the reply untouched.
+func NormalizeQueryResponse(raw string) string {
+	return normalizeAsciiData(raw)
+}
+
 // normalizeAsciiData trims the s3270/x3270 "data:" prefix and drops status lines.
 func normalizeAsciiData(raw string) string {
 	lines := strings.Split(raw, "\n")

connect3270/emulator_test.go

@@ -151,28 +151,28 @@ func TestWaitForFieldErrorIncludesKeyboardLockDetail(t *testing.T) {
 	// We can't fully test WaitForField without a real connection,
 	// but we can verify that when it would fail, the error format includes
 	// the KeyboardLockDetail message.
-	
+
 	// This test verifies the error message structure by checking that the
 	// failure path includes the expected "KeyboardLockDetail:" text
 	// The actual implementation will add this detail when query succeeds
 	expectedSubstring := "KeyboardLockDetail:"
-	
+
 	// Create an emulator (won't be connected)
 	e := &Emulator{
 		Host:       "test.host",
 		Port:       23,
 		ScriptPort: "5000",
 	}
-	
+
 	// Call WaitForField with minimal retries (will fail without connection)
 	// This should timeout and include KeyboardLockDetail in the error
 	err := e.WaitForField(1, 1)
-	
+
 	// Verify error occurred (expected since there's no connection)
 	if err == nil {
 		t.Fatal("Expected WaitForField to fail without connection")
 	}
-	
+
 	// Verify the error message contains the KeyboardLockDetail marker
 	if !strings.Contains(err.Error(), expectedSubstring) {
 		t.Errorf("WaitForField error should contain '%s', got: %v", expectedSubstring, err)
@@ -260,3 +260,44 @@ func TestCaptureAttrsEscapeValues(t *testing.T) {
 		t.Errorf("captureAttrs() = %q, want the host escaped", attrs)
 	}
 }
+
+// The host compatibility profiler parses these replies into a document that is
+// diffed against 3270Web's, so the value has to arrive without s3270's framing
+// around it. Leaving the prefix on produced a profile that described the
+// framing: host "data", terminal type "data:", 24 columns instead of 80.
+func TestNormalizeQueryResponse(t *testing.T) {
+	cases := []struct {
+		name string
+		raw  string
+		want string
+	}{
+		{
+			name: "strips the prefix and the status trailer",
+			raw:  "data: 127.0.0.1:3270\nU F U C(127.0.0.1) I 2 24 80 4 20 0x0 0.000\nok\n",
+			want: "127.0.0.1:3270",
+		},
+		{
+			name: "handles the prefix without a following space",
+			raw:  "data:IBM-3279-2-E\nok\n",
+			want: "IBM-3279-2-E",
+		},
+		{
+			name: "returns the reply unchanged when there is no data line",
+			raw:  "ok\n",
+			want: "ok",
+		},
+		{
+			name: "empty stays empty",
+			raw:  "",
+			want: "",
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			if got := NormalizeQueryResponse(tc.raw); got != tc.want {
+				t.Errorf("NormalizeQueryResponse(%q) = %q, want %q", tc.raw, got, tc.want)
+			}
+		})
+	}
+}

docs/assets/video/terminal-host-profiler.jpg

@@ -31,6 +31,18 @@ captures the first screen's banner signature, records timing, and writes
 the JSON to `-profileOut` (or stdout when omitted). The process exits
 non-zero on failure so CI can fail fast.
 
+<figure class="demo-video">
+  <video controls preload="metadata" playsinline
+         poster="/assets/video/terminal-host-profiler.jpg">
+    <source src="/assets/video/terminal-host-profiler.mp4" type="video/mp4">
+    <a href="/assets/video/terminal-host-profiler.mp4">Download the video</a>.
+  </video>
+  <figcaption>
+    Profiling the bundled sample host: the probe, the device and protocol it
+    reports, and the queries it could not get an answer to.
+  </figcaption>
+</figure>
+
 ## Flags
 
 | Flag | Description |

docs/assets/video/terminal-host-profiler.mp4

@@ -224,6 +224,8 @@ Shorter walk-throughs of one thing at a time:
 | Call it over HTTP — one POST returns the screen | [Advanced Features](advanced-features.md#api-mode-in-practice) |
 | The operations console, end to end | [Web Dashboard](dashboard.md#a-tour-of-the-console) |
 | Sign-in and administration with `AUTH_MODE=local` | [Accounts and Sign-In](authentication.md#what-it-looks-like) |
+| Profile a host before you trust a workflow against it | [Host Compatibility Profiler](host-profiler.md#quick-start) |
+| Drive it from an AI client over MCP | [MCP Server](mcp.md#check-it-works-first) |
 
 ## Conclusion
 

docs/assets/video/terminal-mcp-server.jpg

@@ -31,6 +31,19 @@ That prints the tool catalogue as JSON and exits. It needs no host, no
 workflow and no run in progress. If you see JSON, the wiring is right and
 anything that fails afterwards is configuration.
 
+<figure class="demo-video">
+  <video controls preload="metadata" playsinline
+         poster="/assets/video/terminal-mcp-server.jpg">
+    <source src="/assets/video/terminal-mcp-server.mp4" type="video/mp4">
+    <a href="/assets/video/terminal-mcp-server.mp4">Download the video</a>.
+  </video>
+  <figcaption>
+    The tool catalogue, the descriptions a model reads to choose between tools,
+    and a real stdio session — an <code>initialize</code> followed by a
+    <code>tools/call</code> — answered by the server by hand.
+  </figcaption>
+</figure>
+
 ## Setting up Claude Desktop
 
 1. Open **Claude Desktop** → **Settings** → **Developer** → **Edit Config**.

docs/assets/video/terminal-mcp-server.mp4

@@ -1691,6 +1691,11 @@ func main() {
 		startPrometheusListener(promListen)
 	}
 
+	// Before the profiler branch, not after it: -verbose and -headless are only
+	// two assignments, and leaving them until later meant a -profile run was
+	// driven by whatever the defaults happened to be.
+	setGlobalSettings()
+
 	if profileMode {
 		runProfileMode()
 		return