fix: remove last used model group

Author: wangtsiao

apps/desktop/src/renderer/components/automations/create-automation-dialog.tsx

@@ -40,7 +40,8 @@ import { toast } from "sonner"
 import type { Automation } from "../../../preload/api"
 import { discoveryProjectsAtom } from "../../atoms/discovery"
 import {
-	useModelState,
+	getModelVariants,
+	type ModelRef,
 	useDevoAgents,
 	useProviders,
 } from "../../hooks/use-devo-data"
@@ -51,10 +52,8 @@ import {
 	runAutomationNow,
 	updateAutomation,
 } from "../../services/backend"
-import type { ModelRef } from "../../hooks/use-devo-data"
 import { AgentSelector, ModelSelector, VariantSelector } from "../chat/prompt-toolbar"
 import { SchedulePicker } from "./schedule-picker"
-import { getModelVariants } from "../../hooks/use-devo-data"
 
 interface CreateAutomationDialogProps {
 	open: boolean
@@ -124,7 +123,6 @@ export function CreateAutomationDialog({
 
 	const { data: providers } = useProviders(directory)
 	const { agents } = useDevoAgents(directory)
-	const { recentModels } = useModelState()
 
 	// Compute available variants for the selected model
 	const variants = useMemo(() => {
@@ -459,7 +457,6 @@ export function CreateAutomationDialog({
 								effectiveModel={selectedModel}
 								hasOverride={selectedModel !== null}
 								onSelectModel={setSelectedModel}
-								recentModels={recentModels}
 							/>
 							{variants.length > 0 && (
 								<>

apps/desktop/src/renderer/components/chat/chat-input.tsx

@@ -178,7 +178,7 @@ export function ChatInput({
 	const [selectedAgent, setSelectedAgent] = useState<string | null>(null)
 	const [selectedVariant, setSelectedVariant] = useState<string | undefined>(undefined)
 
-	const { recentModels, addRecent: addRecentModel } = useModelState()
+	const { addRecent: addRecentModel } = useModelState()
 
 	// Resolve effective model
 
@@ -396,7 +396,6 @@ export function ChatInput({
 										if (m) addRecentModel(m)
 									})
 								}
-								recentModels={recentModels}
 								selectedVariant={selectedVariant}
 								onSelectVariant={(v) => startTransition(() => setSelectedVariant(v))}
 								disabled={!isConnected}

apps/desktop/src/renderer/components/chat/chat-view.tsx

@@ -1114,7 +1114,7 @@ function ChatInputSection({
 		}
 	}, [sessionMessages, agent.sessionId, agent.directory, projectModels])
 
-	const { recentModels, addRecent: addRecentModel } = useModelState()
+	const { addRecent: addRecentModel } = useModelState()
 
 	const activeDevoAgent = useMemo(() => {
 		const agentName = selectedAgent ?? config?.defaultAgent
@@ -1625,7 +1625,6 @@ function ChatInputSection({
 												effectiveModel={effectiveModel}
 												hasModelOverride={!!selectedModel}
 												onSelectModel={handleModelSelect}
-												recentModels={recentModels}
 												selectedVariant={selectedVariant}
 												onSelectVariant={setSelectedVariant}
 												disabled={!isConnected}

apps/desktop/src/renderer/components/chat/prompt-toolbar.test.ts

@@ -0,0 +1,36 @@
+import { readFileSync } from "node:fs"
+import { describe, expect, test } from "bun:test"
+
+const source = readFileSync(new URL("./prompt-toolbar.tsx", import.meta.url), "utf8")
+const modelSelectorProps = source.match(/interface ModelSelectorProps \{[\s\S]*?\n\}/)?.[0] ?? ""
+const promptToolbarProps = source.match(/export interface PromptToolbarProps \{[\s\S]*?\n\}/)?.[0] ?? ""
+
+describe("Model selector menu", () => {
+	test("does not expose a Last used presentation group", () => {
+		expect({
+			omitsLastUsedHeading: !source.includes("Last used"),
+			omitsLastUsedPresentationState: !source.includes("lastUsedModels"),
+			modelSelectorPropRemoved: !modelSelectorProps.includes("recentModels"),
+			promptToolbarPropRemoved: !promptToolbarProps.includes("recentModels"),
+		}).toEqual({
+			omitsLastUsedHeading: true,
+			omitsLastUsedPresentationState: true,
+			modelSelectorPropRemoved: true,
+			promptToolbarPropRemoved: true,
+		})
+	})
+
+	test("keeps provider grouping and active model selection", () => {
+		expect({
+			groupsFilteredModelsByProvider: source.includes("groupByProvider(filteredModels)"),
+			rendersProviderGroups: source.includes("<SearchableListPopoverGroup"),
+			keepsSessionModelsUngrouped: source.includes('providerId === "session"'),
+			keepsActiveModelCheck: source.includes("selected={model.value === activeValue}"),
+		}).toEqual({
+			groupsFilteredModelsByProvider: true,
+			rendersProviderGroups: true,
+			keepsSessionModelsUngrouped: true,
+			keepsActiveModelCheck: true,
+		})
+	})
+})

apps/desktop/src/renderer/components/chat/prompt-toolbar.tsx

@@ -193,8 +193,6 @@ interface ModelSelectorProps {
 	/** Whether the user has explicitly overridden the model */
 	hasOverride: boolean
 	onSelectModel: (model: ModelRef | null) => void
-	/** Recent models from model.json (most recently used first) */
-	recentModels?: ModelRef[]
 	variants?: string[]
 	selectedVariant?: string | undefined
 	currentVariant?: string | undefined
@@ -207,7 +205,6 @@ export function ModelSelector({
 	providers,
 	effectiveModel,
 	onSelectModel,
-	recentModels,
 	variants = [],
 	selectedVariant,
 	currentVariant,
@@ -217,17 +214,6 @@ export function ModelSelector({
 }: ModelSelectorProps) {
 	const models = useMemo(() => (providers ? flattenModels(providers.providers) : []), [providers])
 
-	// Build "Last used" group from recentModels (up to 3, only models that exist in providers)
-	const lastUsedModels = useMemo(() => {
-		if (!recentModels || recentModels.length === 0) return []
-		return recentModels
-			.slice(0, 3)
-			.map((ref) =>
-				models.find((m) => m.providerID === ref.providerID && m.modelID === ref.modelID),
-			)
-			.filter((m): m is ModelOption => m != null)
-	}, [recentModels, models])
-
 	const activeValue = effectiveModel
 		? `${effectiveModel.providerID}/${effectiveModel.modelID}`
 		: null
@@ -310,7 +296,6 @@ export function ModelSelector({
 						<SearchableListPopoverSearch placeholder="Search models..." />
 						<ModelSelectorList
 							models={models}
-							lastUsedModels={lastUsedModels}
 							activeValue={activeValue}
 							onSelect={handleSelect}
 						/>
@@ -335,12 +320,10 @@ export function ModelSelector({
 /** Inner list component — reads search from context */
 function ModelSelectorList({
 	models,
-	lastUsedModels,
 	activeValue,
 	onSelect,
 }: {
 	models: ModelOption[]
-	lastUsedModels: ModelOption[]
 	activeValue: string | null
 	onSelect: (value: string) => void
 }) {
@@ -365,22 +348,6 @@ function ModelSelectorList({
 				<SearchableListPopoverEmpty>No models found</SearchableListPopoverEmpty>
 			) : (
 				<>
-					{/* Last used group — only shown when not searching */}
-					{!search && lastUsedModels.length > 0 && (
-						<SearchableListPopoverGroup label="Last used">
-							{lastUsedModels.map((model) => (
-								<ModelSelectorOptionRow
-									key={`recent-${model.value}`}
-									displayName={model.displayName}
-									providerName={model.providerName}
-									reasoning={model.reasoning}
-									selected={model.value === activeValue}
-									onSelect={() => onSelect(model.value)}
-								/>
-							))}
-						</SearchableListPopoverGroup>
-					)}
-
 					{/* Provider-grouped models */}
 					{Array.from(grouped.entries()).map(([providerName, providerModels]) => {
 						// Get the provider ID from the first model in the group to look up the icon
@@ -517,9 +484,6 @@ export interface PromptToolbarProps {
 	hasModelOverride: boolean
 	onSelectModel: (model: ModelRef | null) => void
 
-	/** Recent models from model.json */
-	recentModels?: ModelRef[]
-
 	/** Currently selected variant */
 	selectedVariant: string | undefined
 	onSelectVariant: (variant: string | undefined) => void
@@ -540,7 +504,6 @@ export function PromptToolbar({
 	effectiveModel,
 	hasModelOverride,
 	onSelectModel,
-	recentModels,
 	selectedVariant,
 	onSelectVariant,
 	disabled,
@@ -588,7 +551,6 @@ export function PromptToolbar({
 				effectiveModel={effectiveModel}
 				hasOverride={hasModelOverride}
 				onSelectModel={onSelectModel}
-				recentModels={recentModels}
 				variants={variants}
 				selectedVariant={selectedVariant}
 				currentVariant={currentVariant}

apps/desktop/src/renderer/components/new-chat.tsx

@@ -656,7 +656,6 @@ export function NewChat() {
 												effectiveModel={effectiveModel}
 												hasModelOverride={!!selectedModel}
 												onSelectModel={handleModelSelect}
-												recentModels={recentModels}
 												selectedVariant={selectedVariant}
 												onSelectVariant={setSelectedVariant}
 												disabled={launching || !selectedDirectory}