Skip to content

Commit bc3a498

Browse files
committed
Refactor EndpointsApi tests to use enum constants and update pagination fields in ListEndpointsResponse tests
1 parent 018a212 commit bc3a498

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

test/unit/api/test_endpoints_api.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ def test_create_endpoint(self) -> None:
4949
Create Endpoint
5050
"""
5151
endpoint_body = CreateWebRtcConnectionRequest(
52-
type=EndpointTypeEnum("webrtc"),
53-
direction=EndpointDirectionEnum("inbound"),
52+
type=EndpointTypeEnum.WEBRTC,
53+
direction=EndpointDirectionEnum.INBOUND,
5454
event_callback_url="https://myServer.com/bandwidth/webhooks/endpoint",
5555
event_fallback_url="https://myFallbackServer.com/bandwidth/webhooks/endpoint",
5656
tag="test-endpoint",
@@ -120,8 +120,8 @@ def test_list_endpoints_with_filters(self) -> None:
120120
"""
121121
response = self.endpoints_api_instance.list_endpoints_with_http_info(
122122
BW_ACCOUNT_ID,
123-
type=EndpointTypeEnum("webrtc"),
124-
status=EndpointStatusEnum("active"),
123+
type=EndpointTypeEnum.WEBRTC,
124+
status=EndpointStatusEnum.CONNECTED,
125125
limit=100
126126
)
127127

@@ -171,8 +171,8 @@ def test_create_endpoint_minimal(self) -> None:
171171
Create Endpoint with Minimal Fields
172172
"""
173173
endpoint_body = CreateWebRtcConnectionRequest(
174-
type=EndpointTypeEnum("webrtc"),
175-
direction=EndpointDirectionEnum("outbound")
174+
type=EndpointTypeEnum.WEBRTC,
175+
direction=EndpointDirectionEnum.OUTBOUND
176176
)
177177
response = self.endpoints_api_instance.create_endpoint_with_http_info(
178178
BW_ACCOUNT_ID,
@@ -188,8 +188,8 @@ def test_create_endpoint_sip(self) -> None:
188188
Create SIP Endpoint
189189
"""
190190
endpoint_body = CreateWebRtcConnectionRequest(
191-
type=EndpointTypeEnum("sip"),
192-
direction=EndpointDirectionEnum("bidirectional"),
191+
type=EndpointTypeEnum.WEBRTC,
192+
direction=EndpointDirectionEnum.BIDIRECTIONAL,
193193
event_callback_url="https://myServer.com/bandwidth/webhooks/sip-endpoint",
194194
tag="sip-test-endpoint"
195195
)

test/unit/models/test_list_endpoints_response.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,9 @@ def make_instance(self, include_optional) -> ListEndpointsResponse:
4545
Link(href='https://api.bandwidth.com/endpoints?page=2', rel='next')
4646
],
4747
page=Page(
48-
total_count=100,
4948
page_size=10,
49+
total_elements=100,
50+
total_pages=10,
5051
page_number=1
5152
),
5253
data=[
@@ -93,7 +94,8 @@ def testListEndpointsResponse(self):
9394
assert isinstance(instance.links, list)
9495
assert len(instance.links) == 2
9596
assert isinstance(instance.page, Page)
96-
assert instance.page.total_count == 100
97+
assert instance.page.total_elements == 100
98+
assert instance.page.page_size == 10
9799
assert isinstance(instance.data, list)
98100
assert len(instance.data) == 2
99101
assert isinstance(instance.data[0], Endpoints)

0 commit comments

Comments
 (0)