Commit 790ec42
authored
fix: command parsing and executing caused console dead lock (#1565)
### Motivation
Executing a lot of commands while e.g. services are starting (printing
messages to the console) can lead to dead locks. This issue was probably
introduced with the cloud 2.0 migration. Prior to cloud 2.0 the
framework used to run suggestions on the caller thread. With cloud 2.0 a
shared thread pool for suggestion, parsing and executing can be used.
This then leads to dead locks.
### Modification
Explicitly set the thread pool for parsing & executing only. Suggestions
are processed on the caller thread (thus restoring cloud 1.0 behavior.
### Result
No dead-locks of the console.1 parent 9389d89 commit 790ec42
File tree
2 files changed
+7
-1
lines changed- node/src/main/java/eu/cloudnetservice/node/command/defaults
2 files changed
+7
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
| 40 | + | |
39 | 41 | | |
40 | 42 | | |
41 | 43 | | |
| |||
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
41 | 42 | | |
42 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
43 | 47 | | |
44 | 48 | | |
45 | 49 | | |
| |||
0 commit comments