Feature/event refactor (#246)

* feat: refactor Signal and Event to CloudEvent types with own identity

Refactor Signal and Event structs to use CloudEvent wrappers, add
pack/unpack for wire transport, and fix code quality issues including
typos, dead code, missing struct tags, inconsistent error handling,
and potential panics.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Fixing lint

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: zer0stars

DEVELOPER_GUIDE.md

@@ -34,7 +34,7 @@ Welcome to the Model Garage developer guide! This guide will help you understand
     - [Getting All Default Signals](#getting-all-default-signals)
     - [Signal Information Available](#signal-information-available)
     - [Common Usage Patterns](#common-usage-patterns)
-    - [Getting Event Tags](#getting-event-tags)
+    - [Getting Event Names](#getting-event-names)
   - [When to Import This Package](#when-to-import-this-package)
 - [Module-Specific Guides](#module-specific-guides)
 - [Additional Resources](#additional-resources)
@@ -461,20 +461,20 @@ signal.SetValue(65.5) // Sets ValueNumber
 
 ### Event Structure
 
-The `vss.Event` struct represents vehicle events (harsh braking, collisions, etc.) and **directly corresponds to the database schema**:
+The `vss.Event` type is a CloudEvent type alias (`type Event = cloudevent.CloudEvent[EventData]`) representing vehicle events (harsh braking, collisions, etc.) and **directly corresponds to the database schema**:
 
 ```go
-type Event struct {
-    Subject      string      // Vehicle/entity DID
-    Source       string      // Integration source
-    Producer     string      // Device DID
-    CloudEventID string      // CloudEvent identifier
-    Name         string      // Event name (e.g., "behavior.harshBraking")
-    Timestamp    time.Time   // When the event occurred
-    DurationNs   uint64      // Event duration in nanoseconds
-    Metadata     string      // JSON metadata
-    Tags         []string    // Event tags
+// EventData holds the domain-specific payload for an event.
+type EventData struct {
+    Name       string      // Event name (e.g., "behavior.harshBraking")
+    Timestamp  time.Time   // When the event occurred
+    DurationNs uint64      // Event duration in nanoseconds
+    Metadata   string      // JSON metadata
 }
+
+// Event is a CloudEvent with EventData as the payload.
+// Fields from CloudEventHeader: Subject, Source, Producer, ID, Type, DataVersion, Tags
+type Event = cloudevent.CloudEvent[EventData]
 ```
 
 **Database Mapping**:
@@ -583,20 +583,20 @@ if containsPrivilege(signal.Privileges, "VEHICLE_ALL_TIME_LOCATION") {
 }
 ```
 
-#### Getting Event Tags
+#### Getting Event Names
 
-Similarly, you can get all defined event tags:
+Similarly, you can get all defined event names:
 
 ```go
 import "github.com/DIMO-Network/model-garage/pkg/schema"
 
-eventTags, err := schema.GetDefaultEventTags()
+eventNames, err := schema.GetDefaultEventNames()
 if err != nil {
-    return fmt.Errorf("failed to load event tags: %w", err)
+    return fmt.Errorf("failed to load event names: %w", err)
 }
 
-for _, tag := range eventTags {
-    fmt.Printf("Event: %s - %s\n", tag.Name, tag.Desc)
+for _, eventName := range eventNames {
+    fmt.Printf("Event: %s - %s\n", eventName.Name, eventName.Desc)
 }
 ```
 

go.mod

@@ -5,7 +5,7 @@ go 1.25.0
 require (
 	github.com/99designs/gqlgen v0.17.87
 	github.com/DIMO-Network/clickhouse-infra v0.0.7
-	github.com/DIMO-Network/cloudevent v0.2.2
+	github.com/DIMO-Network/cloudevent v0.2.5
 	github.com/Masterminds/sprig/v3 v3.3.0
 	github.com/ethereum/go-ethereum v1.17.1
 	github.com/segmentio/ksuid v1.0.4

go.sum

@@ -29,8 +29,8 @@ github.com/ClickHouse/clickhouse-go/v2 v2.43.0 h1:fUR05TrF1GyvLDa/mAQjkx7KbgwdLR
 github.com/ClickHouse/clickhouse-go/v2 v2.43.0/go.mod h1:o6jf7JM/zveWC/PP277BLxjHy5KjnGX/jfljhM4s34g=
 github.com/DIMO-Network/clickhouse-infra v0.0.7 h1:TAsjkFFKu3D5Xg6dwBcRBryjCVSlXsNjVbTwJ4UDlTg=
 github.com/DIMO-Network/clickhouse-infra v0.0.7/go.mod h1:XS80lhSJNWBWGgZ+m4j7++zFj1wAXfmtV2gJfhGlabQ=
-github.com/DIMO-Network/cloudevent v0.2.2 h1:nSVLa6AIv2I5w0X180Dbds19ttZzqtrqEJfTG8ff2AI=
-github.com/DIMO-Network/cloudevent v0.2.2/go.mod h1:zFG6pf7ejwC0y3//mHpISDHR/blsSz8Lew2c4ebc8Lw=
+github.com/DIMO-Network/cloudevent v0.2.5 h1:3s6ZKtBXHYy0ujMYBdOBF9uJAc5C+EKEF7/SToW2cJA=
+github.com/DIMO-Network/cloudevent v0.2.5/go.mod h1:zFG6pf7ejwC0y3//mHpISDHR/blsSz8Lew2c4ebc8Lw=
 github.com/Masterminds/goutils v1.1.1 h1:5nUrii3FMTL5diU80unEVvNevw1nH4+ZV4DSLVJLSYI=
 github.com/Masterminds/goutils v1.1.1/go.mod h1:8cTjp+g8YejhMuvIA5y2vz3BpJxksy863GQaJW2MFNU=
 github.com/Masterminds/semver/v3 v3.4.0 h1:Zog+i5UMtVoCU8oKka5P7i9q9HgrJeGzI9SA1Xbatp0=

internal/generator/vehicle.tmpl

@@ -9,10 +9,10 @@ const (
 {{- end}}
 )
 
-// JSON names for defined event tags
+// JSON names for defined event names
 const (
-{{- range .EventTags}}
-	// Tag{{ .GOName }} {{ .Desc }}
-	Tag{{ .GOName }} = "{{ .JSONName }}"
+{{- range .EventNames}}
+	// Event{{ .GOName }}Name {{ .Desc }}
+	Event{{ .GOName }}Name = "{{ .JSONName }}"
 {{- end}}
-)
+)

pkg/autopi/codegen/convert_signal_status.tmpl

@@ -1,14 +1,21 @@
 // Code generated by github.com/DIMO-Network/model-garage DO NOT EDIT.
 package autopi
 
+import (
+	"errors"
+	"fmt"
+	"github.com/DIMO-Network/model-garage/pkg/convert"
+	"github.com/DIMO-Network/model-garage/pkg/vss"
+	"github.com/tidwall/gjson"
+)
 
-// SignalsFromData converts the given JSON data to a slice of signals.
-func SignalsFromV2Data(originalDoc []byte, baseSignal vss.Signal, signalName string, sigResult gjson.Result) ([]vss.Signal, error) {
+// SignalsFromV2Data converts the given JSON data to a slice of signal data.
+func SignalsFromV2Data(originalDoc []byte, baseSignal vss.Signal, signalName string, sigResult gjson.Result) ([]vss.SignalData, error) {
 	valResult := sigResult.Get("value")
 	if !valResult.Exists() {
 		return nil, errors.New("value field not found")
 	}
-	ret := make([]vss.Signal, 0)
+	ret := make([]vss.SignalData, 0)
 	var retErrs error
 	{{ $root := . }}
 	switch signalName {
@@ -19,11 +26,10 @@ func SignalsFromV2Data(originalDoc []byte, baseSignal vss.Signal, signalName str
 		if err != nil {
 			retErrs = errors.Join(retErrs, fmt.Errorf("failed to convert '{{ $origInfo.Name }}': %w", err))
 		} else {
-			sig := vss.Signal{
-				Subject: baseSignal.Subject,
-				Timestamp: baseSignal.Timestamp,
-				Source: baseSignal.Source,
-				Name: "{{ $sig.JSONName }}",
+			sig := vss.SignalData{
+				Timestamp:    baseSignal.Data.Timestamp,
+				Name:         "{{ $sig.JSONName }}",
+				CloudEventID: baseSignal.CloudEventHeader.ID,
 			}
 			sig.SetValue(val{{ $j }})
 			ret = append(ret, sig)

pkg/autopi/convert_signal.go

@@ -35,9 +35,10 @@ func SignalsFromV2Payload(event cloudevent.RawEvent) ([]vss.Signal, error) {
 	}
 	retSignals := []vss.Signal{}
 	signalMeta := vss.Signal{
-		Subject: event.Subject,
-		Source:  event.Source,
+		CloudEventHeader: event.CloudEventHeader,
 	}
+	hdr := event.CloudEventHeader
+	hdr.Type = cloudevent.TypeSignal
 
 	conversionErrors := convert.ConversionError{
 		Subject: event.Subject,
@@ -55,13 +56,15 @@ func SignalsFromV2Payload(event cloudevent.RawEvent) ([]vss.Signal, error) {
 			conversionErrors.Errors = append(conversionErrors.Errors, err)
 			continue
 		}
-		signalMeta.Timestamp = ts
-		sigs, err := SignalsFromV2Data(event.Data, signalMeta, originalName, sigData)
+		signalMeta.Data.Timestamp = ts
+		sigDatas, err := SignalsFromV2Data(event.Data, signalMeta, originalName, sigData)
 		if err != nil {
 			conversionErrors.Errors = append(conversionErrors.Errors, err)
 			continue
 		}
-		retSignals = append(retSignals, sigs...)
+		for _, sd := range sigDatas {
+			retSignals = append(retSignals, vss.Signal{CloudEventHeader: hdr, Data: sd})
+		}
 	}
 
 	if len(conversionErrors.Errors) > 0 {