fix: persistent volume retention (#1350)

This patch adds annotations to PVCs to avoid their pruning. This means
they will not be automatically deleted when they do not exist in the
"desired state".

This has been tested by being deployed to P49, then switching BlueAPI
between 1.11.2 and 1.11.3 and checking that changes to the scratch area
persist between PVC swaps.

Author: dan-fernandes

helm/blueapi/templates/volumes.yaml

@@ -4,7 +4,8 @@ kind: PersistentVolumeClaim
 metadata:
   name: {{ include "blueapi.fullname" . }}-scratch-{{ .Values.image.tag | default .Chart.AppVersion }}
   annotations:
-    helm.sh/resource-policy: keep
+    argocd.argoproj.io/sync-options: Prune=false,Delete=false
+    argocd.argoproj.io/compare-options: IgnoreExtraneous
 spec:
   accessModes:
     - ReadWriteMany

tests/unit_tests/test_helm_chart.py

@@ -600,7 +600,10 @@ def test_persistent_volume_claim_exists(
             "kind": "PersistentVolumeClaim",
             "metadata": {
                 "name": "blueapi-scratch-0.1.0",
-                "annotations": {"helm.sh/resource-policy": "keep"},
+                "annotations": {
+                    "argocd.argoproj.io/sync-options": "Prune=false,Delete=false",
+                    "argocd.argoproj.io/compare-options": "IgnoreExtraneous",
+                },
             },
             "spec": {
                 "accessModes": ["ReadWriteMany"],