Skip to content

Commit e280953

Browse files
committed
Refactor a few things
* Reorganize build.gradle * Upgrade gradle to 4.6 * Rename items in code to match actual names * Reformat JSON * Remove rift item * Move rift tile entity to tileentities package * Remove unnecessary .gitignore entries
1 parent 1c78b5e commit e280953

File tree

88 files changed

+3552
-3564
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

88 files changed

+3552
-3564
lines changed

.gitignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,5 @@ build
2424

2525
# other
2626
run
27-
libs
28-
forge-*-changelog.txt
2927
.DS_Store
3028
Thumbs.db
31-
logs

build.gradle

Lines changed: 37 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -18,67 +18,58 @@ apply plugin: 'net.minecraftforge.gradle.forge'
1818

1919
repositories {
2020
maven { url "https://jitpack.io" }
21-
ivy {
22-
url 'https://github.com/'
23-
layout 'pattern', {
24-
//noinspection GroovyAssignabilityCheck (IntelliJ is wrong)
25-
artifact '/[organisation]/[module]/raw/master/repository/snapshots/[revision].[ext]'
26-
}
27-
}
2821
}
2922

30-
// Version info
31-
String baseversion = "3.0" // Set beta to 0 after changing this
32-
int beta = 7 // Set this to 0 for a non-beta release
33-
int betaSub = 1
34-
ext.mcversion = "1.12.2"
35-
ext.forgeversion = "14.23.2.2623"
36-
String mcpversion = "snapshot_20180227"
23+
configurations {
24+
embed
25+
compile.extendsFrom(embed)
26+
}
3727

38-
String suffix = ""
39-
String shortSuffix = ""
40-
if (beta != 0) {
41-
suffix += ".$beta" + "-b"
42-
if (betaSub != 0) {
43-
suffix += "-$betaSub"
44-
}
45-
shortSuffix = suffix
46-
if (System.getenv("TRAVIS_BUILD_NUMBER") != null && beta != 0) {
47-
suffix += "+${System.getenv("TRAVIS_BUILD_NUMBER")}"
48-
} else {
49-
suffix += "+UNOFFICIAL"
50-
}
28+
dependencies {
29+
embed 'com.flowpowered:flow-math:1.0.3'
30+
embed 'org.jgrapht:jgrapht-core:1.1.0'
31+
embed 'com.github.DimensionalDevelopment:poly2tri.java:master-SNAPSHOT'
32+
compileOnly 'com.github.DimensionalDevelopment:AnnotatedNBT:-SNAPSHOT'
33+
compileOnly 'com.github.OpenCubicChunks:CubicChunks:MC_1.12-SNAPSHOT'
5134
}
52-
version = ext.modversion = baseversion + suffix
5335

36+
// Mod version
37+
version = ext.modversion = "3.0.7"
38+
boolean isBeta = true
5439
group = "org.dimdev.dimdoors"
55-
archivesBaseName = "Dimdoors"
56-
jar.archiveName = "Dimdoors-" + version + ".jar" // Constant name for travis
5740

58-
sourceCompatibility = "1.8"
59-
compileJava {
60-
//options.compilerArgs += "-proc:only"
41+
// Build number
42+
String fullVersion = version
43+
if (System.getenv("TRAVIS_BUILD_NUMBER") != null) {
44+
fullVersion += "+${System.getenv("TRAVIS_BUILD_NUMBER")}"
45+
} else {
46+
fullVersion += "+UNOFFICIAL"
47+
}
48+
if (isBeta) {
49+
fullVersion += "-b"
6150
}
6251

52+
// Jar name format
53+
archivesBaseName = "DimensionalDoors"
54+
jar.archiveName = "DimensionalDoors-" + fullVersion + ".jar" // Constant name for travis
55+
56+
// Minecraft, MCP, Forge, and Java versions
57+
sourceCompatibility = targetCompatibility = "1.8"
58+
ext.mcversion = "1.12.2"
59+
ext.forgeversion = "14.23.2.2623"
60+
String mcpversion = "snapshot_20180227"
61+
6362
minecraft {
6463
version = "$mcversion-$forgeversion"
6564
runDir = "run"
6665
mappings = mcpversion
67-
replace '${version}', baseversion + shortSuffix
68-
// makeObfSourceJar = false // an Srg named sources jar is made by default. uncomment this to disable.
66+
replace '${version}', fullVersion
67+
makeObfSourceJar = false // Unobfuscated sources jar
6968
}
7069

71-
configurations {
72-
embed
73-
compile.extendsFrom(embed)
74-
}
75-
76-
dependencies {
77-
embed 'com.flowpowered:flow-math:1.0.3'
78-
embed 'org.jgrapht:jgrapht-core:1.1.0'
79-
embed 'com.github.DimensionalDevelopment:poly2tri.java:master-SNAPSHOT'
80-
compileOnly 'com.github.DimensionalDevelopment:AnnotatedNBT:-SNAPSHOT'
81-
compileOnly 'com.github.OpenCubicChunks:CubicChunks:MC_1.12-SNAPSHOT'
70+
// Tasks
71+
compileJava {
72+
//options.compilerArgs += "-proc:only" // To debug AnnotatedNBT code generation
8273
}
8374

8475
jar {

gradle/wrapper/gradle-wrapper.jar

-454 Bytes
Binary file not shown.
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
#Tue Dec 19 19:32:34 EST 2017
21
distributionBase=GRADLE_USER_HOME
32
distributionPath=wrapper/dists
43
zipStoreBase=GRADLE_USER_HOME
54
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-all.zip

gradlew

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/main/java/org/dimdev/dimdoors/DimDoors.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.dimdev.dimdoors;
22

33
import net.minecraft.entity.player.EntityPlayer;
4-
import net.minecraft.entity.player.EntityPlayerMP;
54
import net.minecraft.util.text.TextComponentTranslation;
65
import org.dimdev.dimdoors.shared.ModConfig;
76
import org.dimdev.dimdoors.shared.commands.CommandFabricConvert;
@@ -49,7 +48,7 @@ public class DimDoors {
4948
@Override
5049
@SideOnly(Side.CLIENT)
5150
public ItemStack getTabIconItem() {
52-
return new ItemStack(ModItems.DIMENSIONAL_DOOR);
51+
return new ItemStack(ModItems.IRON_DIMENSIONAL_DOOR);
5352
}
5453
};
5554

src/main/java/org/dimdev/dimdoors/client/ModelManager.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,24 +31,24 @@ public static void registerModels() {
3131
register(getItemFromBlock(ModBlocks.WOOD_DIMENSIONAL_TRAPDOOR));
3232

3333
//Item registration
34-
register(ModItems.DIMENSIONAL_DOOR);
34+
register(ModItems.IRON_DIMENSIONAL_DOOR);
3535
register(ModItems.GOLD_DIMENSIONAL_DOOR);
3636
register(ModItems.GOLD_DOOR);
37-
register(ModItems.PERSONAL_DIMENSIONAL_DOOR);
37+
register(ModItems.QUARTZ_DIMENSIONAL_DOOR);
3838
register(ModItems.QUARTZ_DOOR);
3939
register(ModItems.STABLE_FABRIC);
40-
register(ModItems.CHAOS_DOOR);
41-
register(ModItems.WARP_DIMENSIONAL_DOOR);
40+
register(ModItems.UNSTABLE_DIMENSIONAL_DOOR);
41+
register(ModItems.WOOD_DIMENSIONAL_DOOR);
4242
register(ModItems.WORLD_THREAD);
43-
register(ModItems.RIFT_CONNECTION_TOOL);
43+
register(ModItems.RIFT_CONFIGURATION_TOOL);
4444
register(ModItems.RIFT_BLADE);
4545
register(ModItems.RIFT_REMOVER);
4646
register(ModItems.RIFT_SIGNATURE);
4747
register(ModItems.STABILIZED_RIFT_SIGNATURE);
48-
register(ModItems.BOOTS_WOVEN_WORLD_THREAD);
49-
register(ModItems.CHESTPLATE_WOVEN_WORLD_THREAD);
50-
register(ModItems.HELMET_WOVEN_WORLD_THREAD);
51-
register(ModItems.LEGGINGS_WOVEN_WORLD_THREAD);
48+
register(ModItems.WOVEN_WORLD_THREAD_BOOTS);
49+
register(ModItems.WOVEN_WORLD_THREAD_CHESTPLATE);
50+
register(ModItems.WOVEN_WORLD_THREAD_HELMET);
51+
register(ModItems.WOVEN_WORLD_THREAD_LEGGINGS);
5252
}
5353

5454
public static void registerModelVariants() {

src/main/java/org/dimdev/dimdoors/shared/CraftingManager.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ public static void registerRecipes(RegistryEvent.Register<IRecipe> event) { // T
4747
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.STABLE_FABRIC, 1),
4848
"yxy", 'x', Items.ENDER_PEARL, 'y', ModItems.WORLD_THREAD));
4949

50-
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.DIMENSIONAL_DOOR, 1),
50+
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.IRON_DIMENSIONAL_DOOR, 1),
5151
"yxy", 'x', ModItems.STABLE_FABRIC, 'y', Items.IRON_DOOR));
5252

53-
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.CHAOS_DOOR, 1),
53+
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.UNSTABLE_DIMENSIONAL_DOOR, 1),
5454
"xyx", 'x', Items.ENDER_EYE, 'y', Items.IRON_DOOR));
5555

56-
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.WARP_DIMENSIONAL_DOOR, 1),
56+
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.WOOD_DIMENSIONAL_DOOR, 1),
5757
"yxy", 'x', Items.ENDER_PEARL, 'y', Items.OAK_DOOR));
5858

5959
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModBlocks.WOOD_DIMENSIONAL_TRAPDOOR, 1),
@@ -65,7 +65,7 @@ public static void registerRecipes(RegistryEvent.Register<IRecipe> event) { // T
6565
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.GOLD_DOOR, 1),
6666
"yy", "yy", "yy", 'y', Items.GOLD_INGOT));
6767

68-
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.PERSONAL_DIMENSIONAL_DOOR, 1),
68+
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.QUARTZ_DIMENSIONAL_DOOR, 1),
6969
"yx", 'x', ModItems.STABLE_FABRIC, 'y', ModItems.QUARTZ_DOOR));
7070

7171
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.QUARTZ_DOOR, 1),
@@ -75,7 +75,7 @@ public static void registerRecipes(RegistryEvent.Register<IRecipe> event) { // T
7575
"y", "y", "x", 'y', ModItems.STABLE_FABRIC, 'x', Items.IRON_SWORD));
7676

7777
//should not be craftable
78-
/*event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.RIFT_CONNECTION_TOOL),
78+
/*event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.RIFT_CONFIGURATION_TOOL),
7979
" w ", "xyx", "xzx", 'z', Items.DIAMOND_SHOVEL, 'y', ModItems.STABLE_FABRIC, 'x', ModItems.WORLD_THREAD, 'w', Items.DIAMOND));*/
8080

8181
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.RIFT_REMOVER),
@@ -93,28 +93,28 @@ public static void registerRecipes(RegistryEvent.Register<IRecipe> event) { // T
9393
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.STABILIZED_RIFT_SIGNATURE),
9494
" x ", "xyx", " x ", 'x', ModItems.STABLE_FABRIC, 'y', ModItems.RIFT_SIGNATURE));
9595

96-
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.HELMET_WOVEN_WORLD_THREAD),
96+
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.WOVEN_WORLD_THREAD_HELMET),
9797
"xxx", "x x", 'x', ModItems.WORLD_THREAD));
9898

99-
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.CHESTPLATE_WOVEN_WORLD_THREAD),
99+
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.WOVEN_WORLD_THREAD_CHESTPLATE),
100100
"x x", "xxx", "xxx", 'x', ModItems.WORLD_THREAD));
101101

102-
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.LEGGINGS_WOVEN_WORLD_THREAD),
102+
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.WOVEN_WORLD_THREAD_LEGGINGS),
103103
"xxx", "x x", "x x", 'x', ModItems.WORLD_THREAD));
104104

105-
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.BOOTS_WOVEN_WORLD_THREAD),
105+
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.WOVEN_WORLD_THREAD_BOOTS),
106106
"x x", "x x", 'x', ModItems.WORLD_THREAD));
107107

108-
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.HELMET_WOVEN_WORLD_THREAD),
108+
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.WOVEN_WORLD_THREAD_HELMET),
109109
"xyx", "x x", 'x', ModItems.WORLD_THREAD, 'y', Items.LEATHER_HELMET));
110110

111-
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.CHESTPLATE_WOVEN_WORLD_THREAD),
111+
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.WOVEN_WORLD_THREAD_CHESTPLATE),
112112
"x x", "xyx", "x x", 'x', ModItems.WORLD_THREAD, 'y', Items.LEATHER_CHESTPLATE));
113113

114-
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.LEGGINGS_WOVEN_WORLD_THREAD),
114+
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.WOVEN_WORLD_THREAD_LEGGINGS),
115115
"xyx", "x x", "x x", 'x', ModItems.WORLD_THREAD, 'y', Items.LEATHER_LEGGINGS));
116116

117-
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.BOOTS_WOVEN_WORLD_THREAD),
117+
event.getRegistry().register(makeShapedRecipe(new ItemStack(ModItems.WOVEN_WORLD_THREAD_BOOTS),
118118
" y ", "x x", 'x', ModItems.WORLD_THREAD, 'y', Items.LEATHER_BOOTS));
119119
}
120120
}

src/main/java/org/dimdev/dimdoors/shared/RayTraceHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.dimdev.dimdoors.shared;
22

3-
import org.dimdev.dimdoors.shared.rifts.TileEntityRift;
3+
import org.dimdev.dimdoors.shared.tileentities.TileEntityRift;
44
import org.dimdev.dimdoors.shared.tileentities.TileEntityFloatingRift;
55
import net.minecraft.entity.EntityLivingBase;
66
import net.minecraft.util.math.RayTraceResult;

src/main/java/org/dimdev/dimdoors/shared/blocks/BlockDimensionalDoorIron.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public BlockDimensionalDoorIron() {
2424

2525
@Override
2626
public Item getItem() {
27-
return ModItems.DIMENSIONAL_DOOR;
27+
return ModItems.IRON_DIMENSIONAL_DOOR;
2828
}
2929

3030
@Override

0 commit comments

Comments
 (0)