Switch renaming from modal to sidebar

[giemic8]

Is your feature request related to a problem? Please describe.
Renaming currently takes place via a modal. In the future, this will be done via an input field. This has already been implemented for the environment variables and will now be implemented for the main top bar.

Describe the solution you'd like
Abstract the renaming function in the Environment Table (EnvironmentEditor.tsx) and also use it in the MainSideBar.

Hint
Delete the RenameModal-Component if not used in an other way.

[giemic8]

@Ladzsz Is this perhaps a topic for you?

[Ladzsz]

@Ladzsz Is this perhaps a topic for you?

Ill check it out once i finish my current pull request!

[Ladzsz]

@Ladzsz Is this perhaps a topic for you?

Also love that im being considered for issues on the project :)

Makes me feel like im apart of the team haha!

[Ladzsz]

So looking at it now since you said the input field is already implemented do you basically just want me to remove the modal?

[SoulKa]

Yes the modal should not be used anymore for the rename and instead the inline editing should be used just as in the EnvironmentEditor :)

[Ladzsz]

Yes the modal should not be used anymore for the rename and instead the inline editing should be used just as in the EnvironmentEditor :)

Gotcha ill take a look tomorrow.

[Ladzsz]

question do you guys want the same renaming scheme and set up as the one you have for environmental variables? if so where can i find this setup?

[Ladzsz]

wait hold on think i got it

[Ladzsz]

update got an input editing thing working just gotta do some tweaks to make it more user friendly but the core functionality. works!

[Ladzsz]

Right now, the edit logic only updates local state. i checked the edit function inside environment editor.tsx but i dont see anything like local storage or any backend connection for a save how exactly were we saving before? that way i can make the edit work with the same method.

[SoulKa]

Call order:

• Rename in NamingModal:

  trufos/src/renderer/components/sidebar/SidebarRequestList/Nav/Dropdown/modals/NamingModal.tsx

  Lines 26 to 41 in 30a015d

  	const handleSave = () => {
  	onClose();
  	if (createType) {
  	if (createType === 'folder') {
  	addNewFolder(name, trufosObject.id);
  	} else if (createType === 'request') {
  	addNewRequest(name, trufosObject.id);
  	}
  	} else {
  	if (isFolder(trufosObject)) {
  	renameFolder(trufosObject.id, name);
  	} else if (isRequest(trufosObject)) {
  	renameRequest(trufosObject.id, name);
  	}
  	}
  	};

• Rename in collectionStore which sends the call to the main process:

  trufos/src/renderer/state/collectionStore.ts

  Lines 201 to 212 in 30a015d

  	renameRequest: async (id: TrufosRequest['id'], title: string) => {
  	const request = selectRequest(get(), id);
  	if (request == null) return;
  	await eventService.rename(request, title);
  	set((state) => {
  	state.requests.set(id, {
  	...request,
  	title,
  	});
  	});
  	},

• Rename in MainEventService of the main process which ultimately calls the PersistenceService to move the folder:

  trufos/src/main/event/main-event-service.ts

  Lines 172 to 174 in 30a015d

  	async rename(object: Folder | TrufosRequest, newTitle: string): Promise<void> {
  	await persistenceService.rename(object, newTitle);
  	}

• Rename in PersistenceService:

  trufos/src/main/persistence/service/persistence-service.ts

  Lines 82 to 110 in 30a015d

  	/**
  	* Renames a trufos object on the file system.
  	* @param object trufos object to be renamed
  	* @param title new title of the object
  	*/
  	public async rename(object: Folder | TrufosRequest | Collection, title: string) {
  	object.title = title;
  	const oldDirPath = this.getOrCreateDirPath(object);
  	this.idToPathMap.delete(object.id); // force recreation of path after rename
  	const newDirPath = this.getOrCreateDirPath(object);
  	if (oldDirPath !== newDirPath) {
  	logger.info('Renaming object at', oldDirPath, 'to', newDirPath);
  	await fs.rename(oldDirPath, newDirPath);
  	this.idToPathMap.set(object.id, newDirPath);
  	if (!isRequest(object)) {
  	for (const child of object.children) {
  	this.updatePathMapRecursively(child, newDirPath);
  	}
  	}
  	} else {
  	logger.info('Title changed but directory name unchanged for object', object.id);
  	}
  	// Persist new title to the info file so that a reload reflects the change.
  	// We only need to update the primary info file. Draft info files (hidden) represent unsaved changes and
  	// will be updated when they are explicitly saved.
  	await this.saveInfoFile(object, newDirPath);
  	}