Skip to content

Commit 7733782

Browse files
author
Marc Beinder
authored
Fix Release Note Generation (#61)
1 parent aeda02e commit 7733782

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

.github/workflows/_github_createAndReleaseActionDockerImage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ on:
2323

2424
jobs:
2525
BuildAndPushDockerImage:
26-
name: Build and Push Docker Image
26+
name: Build and Push Docker Image (${{inputs.imageName}})
2727
runs-on: ubuntu-latest
2828
steps:
2929
- name: Checkout

.github/workflows/_release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ jobs:
3232

3333
CreateRelease:
3434
name: Create Release
35+
needs: BuildActionImages
3536
runs-on: ubuntu-latest
3637
steps:
3738
- name: Create Release

actions/github/createRelease/main.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,9 @@ func generateCustomReleaseNotes(ctx context.Context, client *github.Client, owne
9797
latestRelease, _, err := client.Repositories.GetLatestRelease(ctx, owner, repo)
9898
var sinceTime *time.Time
9999
if err == nil {
100-
sinceTime = latestRelease.CreatedAt.GetTime()
100+
releaseTime := latestRelease.CreatedAt.GetTime().Add(time.Second)
101+
adjustedTime := releaseTime.Add(time.Second)
102+
sinceTime = &adjustedTime
101103
}
102104

103105
// Get merged PRs since the last release
@@ -121,9 +123,9 @@ func generateCustomReleaseNotes(ctx context.Context, client *github.Client, owne
121123

122124
// Add PR to release notes
123125
if pr.User != nil {
124-
releaseNotes.WriteString(fmt.Sprintf("* [#%d] %s by @%s\n", *pr.Number, *pr.Title, *pr.User.Login))
126+
releaseNotes.WriteString(fmt.Sprintf("* %s by @%s in #%d\n", *pr.Title, *pr.User.Login, *pr.Number))
125127
} else {
126-
releaseNotes.WriteString(fmt.Sprintf("* [#%d] %s\n", *pr.Number, *pr.Title))
128+
releaseNotes.WriteString(fmt.Sprintf("* %s in #%d \n", *pr.Title, *pr.Number))
127129
}
128130
}
129131

0 commit comments

Comments
 (0)