PyPi package

[chrisrichardson]

Original report by Dominique Orban (Bitbucket: optimizer, GitHub: optimizer).

---

It seems the PyPi package for FIAT is empty, pip install fiat fails with no package found. In the interim, this works though:

pip install -e git+https://bitbucket.org/fenics-project/fiat.git#egg=fiat

[chrisrichardson]

Original comment by Jan Blechta (Bitbucket: blechta, GitHub: blechta).

---

Format MWE to make it readable

[chrisrichardson]

Original comment by Jan Blechta (Bitbucket: blechta, GitHub: blechta).

---

It's 1954571. We need to get regression tests running.

[chrisrichardson]

Original comment by Jan Blechta (Bitbucket: blechta, GitHub: blechta).

---

I believe @knepley is correct here. Do you agree @martinal, @Meg so that we can just revert this change before release?

[chrisrichardson]

Original comment by Garth N. Wells (Bitbucket: garth-wells, GitHub: garth-wells).

---

Was this caused by confusion around what is the reference element in 1D, i.e. FIAT (-1, 1) and UFC (0, 1)?

[chrisrichardson]

Original comment by Martin Sandve Alnæs (Bitbucket: martinal, GitHub: martinal).

---

I'm not at all intimately familiar with FIAT.

If I understand the situation correctly, in the commit you mentioned above
the derivatives were scaled by 0.5 probably to "fix" some issue another place,
probably failing regression tests in FFC.

I'm guessing it's related to the difference between FIAT and FFC/UFC reference
cells [-1,+1] vs [0,1]. If this is correct, just reverting the above commit will show
up as wrong results somewhere else (e.g. ffc or dolfin tests) and a followup fix
will be needed somewhere.

[chrisrichardson]

Original comment by Jan Blechta (Bitbucket: blechta, GitHub: blechta).

---

Yes, Martin, it compensates with something else. I'll try bisecting FFC later to find the regression there.

[chrisrichardson]

Original comment by Jan Blechta (Bitbucket: blechta, GitHub: blechta).

---

Supposed fix in jan/fix-issue-9 and in next.

[chrisrichardson]

Original comment by Garth N. Wells (Bitbucket: garth-wells, GitHub: garth-wells).

---

@blechta Would it be a lot of work to add a simple py.test framework to FIAT? This example could go in as a test.

[chrisrichardson]

Original comment by Martin Sandve Alnæs (Bitbucket: martinal, GitHub: martinal).

---

Adding a py.test framework is trivial, the work is writing useful tests.

[chrisrichardson]

Original comment by Jan Blechta (Bitbucket: blechta, GitHub: blechta).

---

Agree with Martin.

I have pushed to jan/fix-issue-9

• 9ecfd8d regression test for this issue
• cb1d26c a notice of Dpc refel coord fix #3 which must be fixed otherwise the tests are useless

[chrisrichardson]

Original comment by Jan Blechta (Bitbucket: blechta, GitHub: blechta).

---

Fixed by f490794. Testing system changes will be merged after release.

[chrisrichardson]

Original comment by Matthew Knepley (Bitbucket: knepley, GitHub: knepley).

---

Thanks! Matt