Regression in `TokenBuffer#forceUseOfBigDecimal`

[sdeleuze]

Search before asking

• I searched in the issues and found nothing similar.

Describe the bug

Ad discussed here, #5667 done between 3.1.0-rc1 and 3.1.0 seems to break TokenBuffer#forceUseOfBigDecimal which is not taken in account anymore.

See

Version Information

3.1.0

Reproduction

See https://github.com/spring-projects/spring-framework/blob/main/spring-web/src/test/java/org/springframework/http/codec/JacksonTokenizerTests.java#L309-L324.

Expected behavior

When TokenBuffer#forceUseOfBigDecimal is used, the number type should be JsonParser.NumberType.BIG_DECIMAL like it was in 3.1.0-rc1.

Additional context

No response

[cowtowncoder]

Copied test from link above:

	@Test  // fails on Jackson 3.1.0: encounters NumberType.DOUBLE
	void useBigDecimalForFloats() {
		Flux<DataBuffer> source = Flux.just(stringBuffer("1E+2"));
		Flux<TokenBuffer> tokens = JacksonTokenizer.tokenize(
				source, this.objectMapper, false, true, -1);

		StepVerifier.create(tokens)
				.assertNext(tokenBuffer -> {
					JsonParser parser = tokenBuffer.asParser();
					JsonToken token = parser.nextToken();
					assertThat(token).isEqualTo(JsonToken.VALUE_NUMBER_FLOAT);
					JsonParser.NumberType numberType = parser.getNumberType();
					assertThat(numberType).isEqualTo(JsonParser.NumberType.BIG_DECIMAL);
				})
				.verifyComplete();
	}

[cowtowncoder]

@sdeleuze I think test could benefit from having configuration explicitly visible wrt TokenBuffer settings.

Or put another way, I think we'd need stand-alone test for Jackson side.

EDIT: never mind, figured it out, I think.

[cowtowncoder]

Accidentally merged fix directly in 3.1 (instead of PR) -- via 220d382 -- but I think I got it.

@sdeleuze If you could verify with 3.1.1-SNAPSHOT version that'd be great. I'll close this assuming it works but let me know if not and will continue working. :)

[sdeleuze]

All good with 3.1.1-SNAPSHOT thanks!

Notice that https://github.com/FasterXML/jackson-databind/wiki/Downloads#snapshots still documents only the old location, may be worth to document using https://central.sonatype.com/repository/maven-snapshots (not sure if that's for all recent versions or just 3.x).

[pjfanning]

I updated https://github.com/FasterXML/jackson-databind/wiki/Downloads

[cowtowncoder]

@sdeleuze Thank you for verifying!