Commit 0ad0181
fix: Address code review findings from commit 7caee47
## Dead Code Removal
- Removed unused LOGGER field and getLogger() method from PropertyUtil
- Removed unused imports: java.util.logging.Level and java.util.logging.Logger
- Removed testPrivateGetLogger() test that verified dead code
## Documentation Consistency
- Added @SInCE 1.0 tags to all FileException non-deprecated constructors
- Matches CommonsIOException pattern for API version tracking
- Addresses issue #142 (missing @SInCE tags)
## Log-and-Throw Anti-Pattern Fix
- Removed redundant logging in SoapUtil.getSoapFactory()
- Follows same "log or throw, not both" principle as commit 7caee47
- Maintains consistency with PropertyUtil refactoring
## Test Results
- All 286 tests pass (was 287, removed 1 dead code test)
- No compilation errors
- Consistent exception handling patterns across codebase
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>1 parent 7caee47 commit 0ad0181
4 files changed
Lines changed: 3 additions & 26 deletions
File tree
- src
- main/java/org/flossware/commons
- io
- util
- test/java/org/flossware/commons/util
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
| |||
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
| 56 | + | |
55 | 57 | | |
56 | 58 | | |
57 | 59 | | |
| |||
62 | 64 | | |
63 | 65 | | |
64 | 66 | | |
| 67 | + | |
65 | 68 | | |
66 | 69 | | |
67 | 70 | | |
| |||
Lines changed: 0 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
29 | 27 | | |
30 | 28 | | |
31 | 29 | | |
| |||
35 | 33 | | |
36 | 34 | | |
37 | 35 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | 36 | | |
54 | 37 | | |
55 | 38 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | 60 | | |
62 | 61 | | |
63 | 62 | | |
| |||
Lines changed: 0 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | 200 | | |
0 commit comments