Merge pull request #24 from GSTJ/chore/magic-tooling

chore: migrate to the magic tooling stack

Author: GSTJ

.eslintrc.js

@@ -13,29 +13,32 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  checks:
+    # Install, lint, format and typecheck are the shared workflow's; node comes
+    # from .nvmrc and pnpm from the `packageManager` field.
+    uses: GSTJ/magic/.github/workflows/ci.yml@main
+    with:
+      build-command: pnpm run build
+      test-command: pnpm run test
+      # `build/` is generated, so the only way to know the published tarball
+      # isn't empty is to pack one.
+      extra-command: npm pack --dry-run
+      # Nothing here uses turbo.
+      turbo-cache: false
+
+  # master's ruleset requires a status check literally named "Lint, test and
+  # build", and a called workflow reports as "<caller job> / <called job>", so
+  # it can never produce that context. This job carries the name instead. It is
+  # deletable the day the ruleset is pointed at the shared workflow's check —
+  # a repository settings change, which is not this PR's to make.
+  #
+  # `if: always()` matters: a job skipped because its dependency failed reports
+  # as skipped, and a skipped required check counts as passed.
   validate:
     name: Lint, test and build
+    needs: checks
+    if: always()
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v7
-
-      - uses: actions/setup-node@v7
-        with:
-          node-version: 24
-          cache: yarn
-
-      # `prepare` runs `expo-module prepare`, so this already builds once.
-      - run: yarn install --frozen-lockfile
-
-      # universe sets most of its rules to `warn`, so without this the step
-      # passes no matter what eslint finds.
-      - run: yarn lint --max-warnings 0
-
-      - run: yarn test
-
-      - run: yarn build
-
-      # `build/` is generated, so the only way to know the published tarball
-      # isn't empty is to pack one.
-      - name: Check the tarball contents
-        run: npm pack --dry-run
+      - name: Fail unless the shared workflow passed
+        run: '[ "${{ needs.checks.result }}" = "success" ]'

.github/workflows/ci.yml

@@ -34,22 +34,28 @@ jobs:
           # last one to work out the bump and the changelog entries.
           fetch-depth: 0
 
+      - uses: pnpm/action-setup@v4
+
       # No `registry-url` here on purpose: it writes an `.npmrc` holding a
-      # literal `${NODE_AUTH_TOKEN}`, and the `cache: yarn` probe then runs
-      # `yarn cache dir`, which dies on "Failed to replace env in config".
-      # The Release step below writes the token itself.
+      # literal `${NODE_AUTH_TOKEN}`, which the package-manager probes behind
+      # `cache:` choke on. The Release step below writes the token itself.
       - uses: actions/setup-node@v7
         with:
-          node-version: 24
-          cache: yarn
+          node-version-file: .nvmrc
+          cache: pnpm
+
+      # `prepare` builds, so this already produces `build/` once.
+      - run: pnpm install --frozen-lockfile
+
+      - run: pnpm run lint
 
-      - run: yarn install --frozen-lockfile
+      - run: pnpm run format
 
-      - run: yarn lint --max-warnings 0
+      - run: pnpm run typecheck
 
-      - run: yarn test
+      - run: pnpm run test
 
-      - run: yarn build
+      - run: pnpm run build
 
       # Publishes to npm, pushes the annotated tag and creates the GitHub
       # release. The version bump commit stays local, see .release-it.cjs.
@@ -73,7 +79,7 @@ jobs:
             args="$args --dry-run"
           fi
 
-          yarn release $args
+          pnpm run release $args
 
           echo "version=$(node -p "require('./package.json').version")" >> "$GITHUB_OUTPUT"
 

.github/workflows/release.yml

@@ -1,6 +1,6 @@
 node_modules
 .idea
 
-# Generated by `expo-module build`, which the `prepare` script runs on every
+# Generated by the `build` script, which the `prepare` script runs on every
 # install and on publish.
 build

.gitignore

@@ -0,0 +1 @@
+24

.nvmrc

@@ -41,7 +41,8 @@ module.exports = {
       header: "# Changelog",
       // Each release leaves a `chore(release)` bump commit and the merge commit
       // that lands it. Neither is worth a changelog line.
-      commitFilter: (commit) => !/^chore\(release\)/.test(commit.header ?? ""),
+      commitFilter: (commit) =>
+        !(commit.header ?? "").startsWith("chore(release)"),
       preset: {
         name: "conventionalcommits",
         types: [

.release-it.cjs

@@ -27,7 +27,6 @@ Before installing this package, you need completely remove Expo updates from you
 
 After installing this npm package, add the [config plugin](https://docs.expo.io/guides/config-plugins/) to the [`plugins`](https://docs.expo.io/versions/latest/config/app/#plugins) array of your `app.json` or `app.config.js`:
 
-
 ```json
 {
   "expo": {

README.md

@@ -1 +1 @@
-module.exports = require('expo-module-scripts/jest-preset-plugin');
+module.exports = require("expo-module-scripts/jest-preset-plugin");

jest.config.js

@@ -0,0 +1,5 @@
+// magic-oxfmt-config ignores `**/CHANGELOG.md` itself, so the local
+// re-declaration this file used to carry is gone. The `withoutIgnorePatterns`
+// opt-out 1.2.0 added is for repos that hand-write their changelog; this one's
+// is generated by @release-it/conventional-changelog, so the default is right.
+export { default } from "magic-oxfmt-config";

oxfmt.config.mts

@@ -0,0 +1,20 @@
+import { extendConfig } from "magic-oxlint-config";
+import base from "magic-oxlint-config/base";
+
+// `extendConfig` flattens the preset into a single config rather than going
+// through oxlint's `extends`, which is the only other supported shape and
+// cannot carry `ignorePatterns` — oxlint has no per-override ignore, so
+// magic-oxlint-config 1.2.0 stopped documenting `extends` entirely. Flattening
+// carries the ignore list and the preset's `env`/`globals` by construction,
+// with nothing local to drift from the preset.
+export default extendConfig(base, {
+  overrides: [
+    {
+      // `${version}` and friends in this file are release-it's own template
+      // syntax, interpolated by release-it at release time. They are supposed
+      // to reach it uninterpolated, so a real template literal would be the bug.
+      files: [".release-it.cjs"],
+      rules: { "no-template-curly-in-string": "off" },
+    },
+  ],
+});