Skip to content

GCop419.md

Latest commit

 

History

History
48 lines (35 loc) · 1.55 KB

GCop419.md

File metadata and controls

48 lines (35 loc) · 1.55 KB

GCop 419

"This statement is too long and hard to read. Press Enter at logical breaking points to split it into multiple lines."

Rule description

Long statements reduce code readability. Break logical operations to align it in a way that shows which operands are related to each other via the operator.

Helpful rules:

  • New line after an open paren.
  • Line breaks after commas.
  • Indent the inner method calls.
  • Line up parameters to a method that are on new lines.

Example 1

mykeyboard.AddButton(new InlineKeyboardButton(CustomWork.ReturnPreviousStep, "$" + Cover.CoverCallback.BackAdvertiseAreas + "," + CurrentButtonState.FK_CurrentBtnId), width + 1 == 2 ? ++height : height, width = width + 1 == 2 ? 0 : ++width);

should be 🡻

mykeyboard.AddButton(
    new InlineKeyboardButton(
        CustomWork.ReturnPreviousStep, 
        "$" + Cover.CoverCallback.BackAdvertiseAreas + "," + CurrentButtonState.FK_CurrentBtnId),
        width + 1 == 2 ? ++height : height,
        width = width + 1 == 2 ? 0 : ++width);

Example 2

shippedItems.AddRange(OrderItem.Fetch(market: this.MARKET, shipConfirmState: ORDERITEMSHIPCONFIRMSTATE.NONE, orderPlacedAfter: serverTime.AddDays(-7), orderPlacedBefore: serverTime.AddHours(-85)));

should be 🡻

shippedItems.AddRange(
    OrderItem.Fetch(market: this.MARKET,
                    shipConfirmState: ORDERITEMSHIPCONFIRMSTATE.NONE,
                    orderPlacedAfter: serverTime.AddDays(-7),
                    orderPlacedBefore: serverTime.AddHours(-85)));