Skip to content

Commit 3d2f918

Browse files
authored
perf: Tweak resources and bump version (#2)
1 parent 20910af commit 3d2f918

4 files changed

Lines changed: 4 additions & 21 deletions

File tree

workflow/Snakefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
snakemake.utils.min_version("8.11.2")
1+
snakemake.utils.min_version("9.0.0")
22

33
# Define wrapper versions
4-
wrapper_ver = "v5.8.3"
4+
wrapper_ver = "v5.10.0"
55

66

77
include: "rules/utils.smk"

workflow/rules/raw.smk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,6 @@ rule fastqc_raw:
8282
resources:
8383
# Memory is hard-coded to 250M per thread (https://github.com/bcbio/bcbio-nextgen/issues/2989)
8484
mem=lambda w, threads: f"{512* threads} MiB",
85-
runtime=lambda w, attempt: f"{1* attempt} h",
85+
runtime=lambda w, attempt: f"{2* attempt} h",
8686
wrapper:
8787
f"{wrapper_ver}/bio/fastqc"

workflow/rules/trim.smk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ elif config["reads"]["trim"]["tool"] == "adapterremoval":
132132
threads: 10
133133
resources:
134134
mem=lambda w, attempt: f"{15* attempt} GiB",
135-
runtime=lambda w, attempt: f"{2* attempt} h",
135+
runtime=lambda w, attempt: f"{3* attempt} h",
136136
wrapper:
137137
f"{wrapper_ver}/bio/adapterremoval"
138138

workflow/rules/utils.smk

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,6 @@ from typing import List, Dict
99
### General
1010

1111

12-
def flatten(list_of_lists: List) -> List:
13-
"""Flatten an irregular list of lists recursively
14-
15-
https://stackoverflow.com/a/53778278
16-
17-
:param list_of_lists: A list of lists
18-
:return result: A string that has been flattened from a list of lists
19-
"""
20-
result = list()
21-
for i in list_of_lists:
22-
if isinstance(i, list):
23-
result.extend(flatten(i))
24-
else:
25-
result.append(str(i))
26-
return result
27-
28-
2912
def expand_pandas(string: List, df: pd.DataFrame, allow_missing=False) -> List:
3013
"""Expand string following columns in the dataframe"""
3114
return set(

0 commit comments

Comments
 (0)