mtproxy_secret_connections is wrong for non-direct mode

[morpheus017]

Hello there!

mtproxy_secret_connections metric quickly goes negative.

looks like D->extra_int2 is set after notification_event_insert_tcp_conn_ready, so mtproto_ext_rpc_ready always receives sid = 0

[github-actions]

Thank you for opening this issue.

This project is maintained by a single developer in their free time.
Upstream TelegramMessenger/MTProxy is abandoned. This fork is the only actively maintained version.

Continued development depends on community support:

• GitHub Sponsors — sponsors' issues are prioritized
• Donate via Tribute — cards, worldwide
• YooMoney — cards & wallets (Russia-friendly)
• Boosty
• TON: UQBOGq_b3eL63Qfkj6ykoBibK3zGJDQzLK91v2q-UCY7BPeb (send via @wallet in Telegram)
• USDT (TRC-20): TNVSj1QjZ5jqdaeshe7VCpXWo2S1n936Hj
• BTC: bc1qvxxldmanwggula7992uun5a2qxm65ej9h0unj7
• GetPageSpeed RPM packages — production-ready install with support

Issues without community interest may be closed after 60 days of inactivity.

[dvershinin]

Fixed in v3.5.3.

Root cause: the per-secret counter increment fired at connection acceptance (before the handshake identified the secret), so extra_int2 was always 0 — exactly as you diagnosed. The decrement on close found the real secret index, producing the negative drift.

The fix moves the increment to after the handshake succeeds, and clears extra_int2 on all failure paths (TLS pass-through, validation failure) to prevent spurious decrements.

Please update and confirm the counters stay sane under load.

[morpheus017]

No a fan of AI solution, but it seems to work. Thank you!