feat: introduce validateFields method to SourceConnectionConfig and implement validation for all source configurations

Author: pratickchokhani

v2/spanner-common/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/shard/CassandraShard.java

@@ -30,7 +30,8 @@ public CassandraShard(OptionsMap optionsMap) {
     extractAndSetHostAndPort();
   }
 
-  private void validateFields() {
+  @Override
+  public void validateFields() {
     if (getContactPoints() == null || getContactPoints().isEmpty()) {
       throw new IllegalArgumentException("CONTACT_POINTS cannot be null or empty.");
     }

v2/spanner-common/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/shard/Shard.java

@@ -197,4 +197,37 @@ public int hashCode() {
         secretManagerUri,
         dbNameToLogicalShardIdMap);
   }
+
+  public void validateFields() {
+    if (logicalShardId == null) {
+      throw new IllegalArgumentException("logicalShardId cannot be null");
+    }
+    if (host == null) {
+      throw new IllegalArgumentException("host cannot be null");
+    }
+    if (port == null) {
+      throw new IllegalArgumentException("port cannot be null");
+    }
+    if (user == null) {
+      throw new IllegalArgumentException("user cannot be null");
+    }
+    if (password == null) {
+      throw new IllegalArgumentException("password cannot be null");
+    }
+    if (dbName == null) {
+      throw new IllegalArgumentException("dbName cannot be null");
+    }
+    if (namespace == null) {
+      throw new IllegalArgumentException("namespace cannot be null");
+    }
+    if (secretManagerUri == null) {
+      throw new IllegalArgumentException("secretManagerUri cannot be null");
+    }
+    if (connectionProperties == null) {
+      throw new IllegalArgumentException("connectionProperties cannot be null");
+    }
+    if (dbNameToLogicalShardIdMap == null) {
+      throw new IllegalArgumentException("dbNameToLogicalShardIdMap cannot be null");
+    }
+  }
 }

v2/spanner-common/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/source/config/AstraConnectionConfig.java

@@ -54,4 +54,20 @@ public String getAstraDbRegion() {
   public void setAstraDbRegion(String astraDbRegion) {
     this.astraDbRegion = astraDbRegion;
   }
+
+  @Override
+  public void validateFields() {
+    if (databaseId == null) {
+      throw new IllegalArgumentException("databaseId cannot be null");
+    }
+    if (astraToken == null) {
+      throw new IllegalArgumentException("astraToken cannot be null");
+    }
+    if (keySpace == null) {
+      throw new IllegalArgumentException("keySpace cannot be null");
+    }
+    if (astraDbRegion == null) {
+      throw new IllegalArgumentException("astraDbRegion cannot be null");
+    }
+  }
 }

v2/spanner-common/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/source/config/CassandraConnectionConfig.java

@@ -29,4 +29,11 @@ public CassandraConnectionConfig(OptionsMap optionsMap) {
   public OptionsMap getOptionsMap() {
     return optionsMap;
   }
+
+  @Override
+  public void validateFields() {
+    if (optionsMap == null) {
+      throw new IllegalArgumentException("optionsMap cannot be null");
+    }
+  }
 }

v2/spanner-common/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/source/config/JdbcShardConfig.java

@@ -33,4 +33,14 @@ public List<Shard> getShardConfigs() {
   public void setShardConfigs(List<Shard> shardConfigs) {
     this.shardConfigs = shardConfigs;
   }
+
+  @Override
+  public void validateFields() {
+    if (shardConfigs == null || shardConfigs.isEmpty()) {
+      throw new IllegalArgumentException("shardConfigs cannot be null or empty");
+    }
+    for (Shard shard : shardConfigs) {
+      shard.validateFields();
+    }
+  }
 }

v2/spanner-common/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/source/config/SourceConfigParser.java

@@ -69,27 +69,34 @@ public SourceConnectionConfig parseConfiguration(
       String sourceTypeStr, String sourceConfigFilePath) throws Exception {
 
     SourceType sourceType = SourceType.parseSourceType(sourceTypeStr);
-    switch (SourceType.parseSourceType(sourceTypeStr)) {
+    SourceConnectionConfig sourceConfig;
+    switch (sourceType) {
       case CASSANDRA:
         // Maps directly to the DataStax OptionsMap
-        return new CassandraConnectionConfig(
-            CassandraDriverConfigLoader.getOptionsMapFromFile(sourceConfigFilePath));
+        sourceConfig =
+            new CassandraConnectionConfig(
+                CassandraDriverConfigLoader.getOptionsMapFromFile(sourceConfigFilePath));
+        break;
       case ASTRA_DB:
         String astraFileContent = FileLoader.readConfigFilePath(sourceConfigFilePath);
         Map<String, Object> astraConfigMap = parseConfigToConfigMap(astraFileContent);
-        return mapper.convertValue(astraConfigMap, AstraConnectionConfig.class);
+        sourceConfig = mapper.convertValue(astraConfigMap, AstraConnectionConfig.class);
+        break;
       case MYSQL:
       case PG:
         String jdbcFileContent = FileLoader.readConfigFilePath(sourceConfigFilePath);
         Map<String, Object> jdbcConfigMap = parseConfigToConfigMap(jdbcFileContent);
         JdbcShardConfig jdbcShardConfig = mapper.convertValue(jdbcConfigMap, JdbcShardConfig.class);
+        jdbcShardConfig.validateFields();
         // Returns ordered list of shards
         jdbcShardConfig.getShardConfigs().sort(Comparator.comparing(Shard::getLogicalShardId));
         resolveShardSecret(jdbcShardConfig, sourceConfigFilePath);
         return jdbcShardConfig;
       default:
         throw new IllegalArgumentException("Unsupported source type: " + sourceType);
     }
+    sourceConfig.validateFields();
+    return sourceConfig;
   }
 
   /**

v2/spanner-common/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/source/config/SourceConnectionConfig.java

@@ -23,4 +23,11 @@
  *
  * <p>This interface will be expanded in Phase 2 during the platformization phase.
  */
-public interface SourceConnectionConfig {}
+public interface SourceConnectionConfig {
+
+  /**
+   * Validates that the source configuration is valid. Throws IllegalArgumentException if the
+   * configuration is invalid.
+   */
+  void validateFields();
+}