Graphite should support importing image files by opening them as a launch argument to the Mac app

[slrgt]

blender lets you set any painting app as an external editor but currently gets this error

maybe if default reaction to graphite trying to open an image file it would would open a new graphite file and import the image file that is being tried to be opened

[mugiwaraluffy56]

I'd like to work on this issue.

Plan:

• Detect file paths passed as launch arguments
• If the argument is an image file, create a new document
• Import the image into the document instead of showing an error

Let me know if this approach works .

[0HyperCube]

@mugiwaraluffy56 Perhaps Keavon didn't notice that importing files from paths specified from the CLI is already implemented in #3059

Graphite/desktop/src/app.rs

Lines 304 to 308 in 8f25eb6

	for path in launch_documents {
	tracing::info!("Opening file from command line: {}", path.display());
	if let Ok(content) = fs::read(&path) {
	let message = DesktopWrapperMessage::OpenFile { path, content };
	app_event_scheduler.schedule(AppEvent::DesktopWrapperMessage(message));

Just run the graphite command with the file you want to import:

launch_graphite_jpg.mp4

MacOsX requires you to add the file type to the plist and also implement a application(_:openFile:) thing (Apple Docs, discussion from winit, discussion from glfw). I guess this is not currently done. I hate OSX so won't be able to further help.

[Keavon]

I was not aware that works for non-.graphite image files, good! It sounds like the actual issue needing fixing is Mac-specific, good find.

[mugiwaraluffy56]

Got it, thanks for the clarification!
I’ll look into the macOS app lifecycle code and take this on 👍

[slrgt]

sweet! thanks yall!