Skip to content

Incompatible with latest zMenu #25

Description

@EinJOJO

zShop selling items does not work with the latest zMenu.

zMenu version 1.1.0.6 works fine.

And the isSimilar is done against ItemStack{GRASS_BLOCK x 1}

[13:54:00 INFO]: [fr.maxlego08.shop.buttons.ZItemButton] Player Ein_Jojo is trying to sell 1 of item ItemStack{GRASS_BLOCK x 1}
[13:54:00 INFO]: [zShop v3.3.3] Ein_Jojo has just sold x1 Grass Block for 3$.

But in other versions, for example the latest this the same action logs

[13:29:24 INFO]: [zShop v3.3.3] Ein_Jojo has purchased x1 Grass Block for 1,8$.
[13:29:28 INFO]: [fr.maxlego08.shop.buttons.ZItemButton] Player Ein_Jojo is trying to sell 1 of item ItemStack{GRASS_BLOCK x 1, UNSPECIFIC_META:{meta-type=UNSPECIFIC, lore=[{"text":"","extra":[{"text":"» ","extra":[{"text":"Buying price","extra":[{"text":": ","extra":[{"text":"1,8$","color":"yellow"}],"color":"dark_gray"}],"color":"gray"}],"italic":false,"color":"white"}],"italic":false}, {"text":"","extra":[{"text":"» ","extra":[{"text":"Selling price","extra":[{"text":": ","extra":[{"text":"3$","color":"yellow"}],"color":"dark_gray"}],"color":"gray"}],"italic":false,"color":"white"}],"italic":false}, {"text":"","extra":[{"text":"","italic":false}],"italic":false}, {"text":"","extra":[{"text":"» ","extra":[{"text":"Server buy limit","extra":[{"text":": ","extra":[{"text":"5","extra":[{"text":"/","extra":[{"text":"100 ","extra":[{"text":"(","extra":[{"text":"07 hours 25 minute(s) 33 seconds","extra":[{"text":")","color":"dark_gray"}],"color":"gray"}],"color":"dark_gray"}],"color":"#d1d1d1"}],"color":"gray"}],"color":"white"}],"color":"dark_gray"}],"color":"gray"}],"italic":false,"color":"white"}],"italic":false}, {"text":"","extra":[{"text":"","italic":false}],"italic":false}, {"text":"","extra":[{"text":"","extra":[{"text":"➥ ","color":"white"},{"text":"Left click to ","extra":[{"text":"ʙᴜʏ","underlined":true,"color":"white"}],"color":"gray"}],"italic":false}],"italic":false}, {"text":"","extra":[{"text":"","extra":[{"text":"➥ ","color":"white"},{"text":"Click wheel (or drop key) to ","extra":[{"text":"sᴇʟʟ ᴇᴠᴇʀʏᴛʜɪɴɢ","underlined":true,"color":"white"}],"color":"gray"}],"italic":false}],"italic":false}, {"text":"","extra":[{"text":"","extra":[{"text":"➥ ","color":"white"},{"text":"Right click to ","extra":[{"text":"sᴇʟʟ","underlined":true,"color":"white"}],"color":"gray"}],"italic":false}],"italic":false}, {"text":"","extra":[{"text":"» ","extra":[{"text":"Buying price","extra":[{"text":": ","extra":[{"text":"1,8$","color":"yellow"}],"color":"dark_gray"}],"color":"gray"}],"italic":false,"color":"white"}],"italic":false}, {"text":"","extra":[{"text":"» ","extra":[{"text":"Selling price","extra":[{"text":": ","extra":[{"text":"3$","color":"yellow"}],"color":"dark_gray"}],"color":"gray"}],"italic":false,"color":"white"}],"italic":false}, {"text":"","extra":[{"text":"","italic":false}],"italic":false}, {"text":"","extra":[{"text":"» ","extra":[{"text":"Server buy limit","extra":[{"text":": ","extra":[{"text":"5","extra":[{"text":"/","extra":[{"text":"100 ","extra":[{"text":"(","extra":[{"text":"07 hours 25 minute(s) 33 seconds","extra":[{"text":")","color":"dark_gray"}],"color":"gray"}],"color":"dark_gray"}],"color":"#d1d1d1"}],"color":"gray"}],"color":"white"}],"color":"dark_gray"}],"color":"gray"}],"italic":false,"color":"white"}],"italic":false}, {"text":"","extra":[{"text":"","italic":false}],"italic":false}, {"text":"","extra":[{"text":"","extra":[{"text":"➥ ","color":"white"},{"text":"Left click to ","extra":[{"text":"ʙᴜʏ","underlined":true,"color":"white"}],"color":"gray"}],"italic":false}],"italic":false}, {"text":"","extra":[{"text":"","extra":[{"text":"➥ ","color":"white"},{"text":"Click wheel (or drop key) to ","extra":[{"text":"sᴇʟʟ ᴇᴠᴇʀʏᴛʜɪɴɢ","underlined":true,"color":"white"}],"color":"gray"}],"italic":false}],"italic":false}, {"text":"","extra":[{"text":"","extra":[{"text":"➥ ","color":"white"},{"text":"Right click to ","extra":[{"text":"sᴇʟʟ","underlined":true,"color":"white"}],"color":"gray"}],"italic":false}],"italic":false}, {"text":"","extra":[{"text":"","italic":false}],"italic":false}, {"text":"","extra":[{"text":"» ","extra":[{"text":"Selling price","extra":[{"text":": ","extra":[{"text":"3$","color":"yellow"}],"color":"dark_gray"}],"color":"gray"}],"italic":false,"color":"white"}],"italic":false}], ItemFlags=[HIDE_ADDITIONAL_TOOLTIP], PublicBukkitValues={
"zmenu:zmenu-item": 1
}}}

The isSimilar check fails and the player gets told that he has not the item in the inventory.

Reproduce

With the default configuration on a server with vault, essentialsx, zmenu, and zshop

  • /shop
  • Try to sell any item

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions