Skip to content

Question about raising a PR for new features #20

@sjhloco

Description

@sjhloco

Hiya,

I have a customised version of nornir-rich (per_panel_var branch) which has a few extra print_result arguments:

  • print_empty_task (default True): If set to False will not print a task if the task result is Null or an empty string ("")
  • per_panel_var (default False): If set to True puts each result var in its own rich panel, if the var is a dictionary rather than having var name as the panel title uses key for each dictionary item (all displayed in the one panel)

The below image shows an example of the output with the arguments not used and used.

Image

I didn't intend to raise a PR as not sure how useful these features would be to others, however I have come across a problem where a package I published to PyPi (nornir-validate) uses this customised version yet due to the way PyPI installed packages work it will only use the default PyPI version of nornir-rich.

Would you be happy accept a PR for these changes, the default argument values mean that they don't effect the current operation. If so, is there any guidance on testing and documentation that you want me to follow, I have tried to keep the coding style similar. Alternatively, if you dont want a PR do you mind if I publish a customised version of nornir-rich in PyPi so I can use with my project?

Thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions