Implement conversion of Uniform to GeneralQuadratureTable#49
Open
w1th0utnam3 wants to merge 5 commits intoInteractiveComputerGraphics:masterfrom
Open
Implement conversion of Uniform to GeneralQuadratureTable#49w1th0utnam3 wants to merge 5 commits intoInteractiveComputerGraphics:masterfrom
w1th0utnam3 wants to merge 5 commits intoInteractiveComputerGraphics:masterfrom
Conversation
w1th0utnam3
force-pushed
the
quadrature-api
branch
from
f6e822a to
ce12ba9
Compare
Member
Author
|
Not sure what happened with CI here, maybe you can manually re-run it @Andlon? |
Member
Hmm, somehow I can't see anything about the CI at all, not sure what's happened here... |
w1th0utnam3
force-pushed
the
quadrature-api
branch
from
ce12ba9 to
d994bdc
Compare
Andlon
requested changes
Nov 18, 2022
Member
Andlon
left a comment
Andlon
left a comment
There was a problem hiding this comment.
Thanks, this looks useful! Please see comments.
Some very basic tests would also be nice.
Andlon
reviewed
Nov 21, 2022
Member
Andlon
left a comment
Andlon
left a comment
There was a problem hiding this comment.
Changes look good, I just still think that with_data_from_fn deserves a simple unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
UniformQuadratureTable::to_general(&self, num_elements)GeneralQuadratureTable::with_data(self, data)