Open
Conversation
4 tasks
IsmaelMartinez
added a commit
that referenced
this pull request
Apr 25, 2026
….8.1 (#2472) * fix(release): strip markdown from appdata <li> and bump manifest to 2.8.1 The first release-please run (PR #2471) showed two issues in the auto-generated AppStream description. Markdown bold and link syntax from CHANGELOG.md leaked verbatim into <li> elements (rendered as literal asterisks and bracketed strings in Flathub, GNOME Software, and KDE Discover), and the manifest still pointed at 2.8.0 even though v2.8.1 was already tagged, so release-please was preparing a duplicate 2.8.1 release. - scripts/update-appdata-xml.js: flatten [label](url) to label, drop **bold** markers, and strip the trailing short-sha parenthetical that duplicates the PR-number link. - .release-please-manifest.json: advance baseline to 2.8.1 so the next Release PR targets 2.8.2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(release): bound stripMarkdown regex quantifiers SonarCloud flagged the unbounded greedy quantifiers as potential ReDoS hotspots. The patterns are linear in practice (negated classes exclude their delimiter, so backtracking is one-step), but explicit upper bounds make the intent clear and silence the warning. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(release): drop \s* quantifiers in trailing-sha regex Sonar continued to flag the leading \s* in the trailing-sha pattern as a backtracking risk. Trim first, then require \s+ before the sha group, so the pattern has no unbounded whitespace quantifiers and the input it sees is already right-trimmed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(release): use literal space instead of \s+ before trailing sha release-please always emits a single space before the (shortsha) annotation, so a literal space is sufficient and removes the only remaining quantifier Sonar's heuristic was flagging on this line. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(release): use replaceAll for global stripMarkdown patterns SonarCloud's es2021/readability rule prefers replaceAll() when the regex has the /g flag and the operation is conceptually a replace-all. The trailing-sha removal stays on replace() because it's a single anchored match, not a global one. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
44506e3 to
da7a303
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



🤖 I have created a release beep boop
2.8.2 (2026-04-25)
Bug Fixes
This PR was generated with Release Please. See documentation.