chore: clear clippy backlog where mechanical, keep deliberate signaturesc

Author: Jobsecond

crates/core/src/mel.rs

@@ -328,7 +328,7 @@ fn reflect_pad(signal: &[f32], pad_l: usize, pad_r: usize) -> Result<Vec<f32>> {
 
 fn pad_sizes(win_length: usize, hop_length: usize) -> (usize, usize) {
     let diff = win_length - hop_length;
-    (diff / 2, (diff + 1) / 2)
+    (diff / 2, diff.div_ceil(2))
 }
 
 #[cfg(test)]

crates/core/src/model/tests.rs

@@ -16,9 +16,9 @@ fn joint_attention_mask_matches_region_rules() {
     let side = 6usize;
 
     assert_eq!(mask.len(), side * side);
-    assert_eq!(mask[0 * side + 1], 0.0);
-    assert_eq!(mask[0 * side + 2], 0.0);
-    assert_eq!(mask[0 * side + 4], -10_000.0);
+    assert_eq!(mask[1], 0.0);
+    assert_eq!(mask[2], 0.0);
+    assert_eq!(mask[4], -10_000.0);
     assert_eq!(mask[2 * side + 3], 0.0);
     assert_eq!(mask[4 * side + 5], -10_000.0);
     assert_eq!(mask[5 * side + 5], -10_000.0);
@@ -278,7 +278,6 @@ fn fake_config() -> GameModelConfig {
             midi_std: 1.0,
             ..Default::default()
         },
-        ..Default::default()
     }
 }
 

crates/core/src/model/weights.rs

@@ -981,7 +981,7 @@ fn validate_supported_config(cfg: &GameModelConfig) -> Result<()> {
     Ok(())
 }
 
-fn layer_scale_name<'a>(enabled: bool, name: &'a str) -> Option<&'a str> {
+fn layer_scale_name(enabled: bool, name: &str) -> Option<&str> {
     enabled.then_some(name)
 }
 

crates/core/src/notify.rs

@@ -50,7 +50,7 @@ impl Notifier for NullNotifier {
 }
 
 thread_local! {
-    static CURRENT_NOTIFIER: RefCell<Vec<(usize, usize)>> = RefCell::new(Vec::new());
+    static CURRENT_NOTIFIER: RefCell<Vec<(usize, usize)>> = const { RefCell::new(Vec::new()) };
 }
 
 pub(crate) fn with_notifier<T>(notifier: &dyn Notifier, f: impl FnOnce() -> T) -> T {

crates/core/src/tensor/cpu/util.rs

@@ -147,7 +147,7 @@ pub(super) fn suffix_broadcast_block_len(
     }
 
     let rank_diff = out.len() - rhs.len();
-    if out[..rank_diff].iter().any(|&dim| dim == 0) {
+    if out[..rank_diff].contains(&0) {
         return None;
     }
     if out[rank_diff..] != rhs[..] {

crates/output/src/midi_writer.rs

@@ -89,7 +89,7 @@ pub fn encode_midi(notes: &[Note], options: &MidiWriteOptions) -> Result<Vec<u8>
         tick: last_tick,
         kind: TrackEventKind::Meta(MetaMessage::EndOfTrack),
     });
-    events.sort_by(|left, right| left.tick.cmp(&right.tick));
+    events.sort_by_key(|left| left.tick);
 
     let mut prev_tick = 0u64;
     let mut track = Vec::with_capacity(events.len());

crates/service/src/lib.rs

@@ -74,7 +74,7 @@ fn get_chunk_semaphore() -> ChunkSemaphore {
             let max_concurrent = std::env::var("GAME_MAX_CONCURRENT_CHUNKS")
                 .ok()
                 .and_then(|s| s.parse::<usize>().ok())
-                .unwrap_or_else(|| rayon::current_num_threads());
+                .unwrap_or_else(rayon::current_num_threads);
             ChunkSemaphore::new(max_concurrent)
         })
         .clone()

src/main.rs

@@ -1043,7 +1043,7 @@ fn inspect(
     print_inspect_section("model_config");
     print_inspect_kv("name", display_or_dash(&model.config.name));
     print_inspect_kv("version", display_or_dash(&model.config.version));
-    print_inspect_kv("mode", model.config.mode.to_string());
+    print_inspect_kv("mode", &model.config.mode);
     print_inspect_kv("embedding dim", model.config.embedding_dim.to_string());
     print_inspect_kv("input dim", model.config.in_dim.to_string());
     print_inspect_kv("estimator out", model.config.estimator_out_dim.to_string());