Test Albers round-trip away from the poles - #366
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 92.35% 92.35%
=======================================
Files 40 40
Lines 1818 1818
=======================================
Hits 1679 1679
Misses 139 139 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #296.
Could not find a bug here. The implementation reproduces every intermediate of Snyder's ellipsoid worked example, m, q, n, C and ρ, with x and y within 5 mm, and no datum throws at the poles.
The pole error is arcsine conditioning.
asin(α/qₚ)reaches an argument of one there so the latitude keeps only half its digits, 2.8189985e-6° predicted against 2.8189981e-6° measured at lat -90. α itself is accurate to 1e-16 so nothing upstream is losing precision.So this only drops the blanket skip in fwdbwd.jl and keeps a narrow one at lat ±90. Albers gets round-trip coverage everywhere else in both float types. Leaving it to you whether that closes #296.