Skip to content

Update jac_lin_coord methods - #501

Merged
tmigot merged 24 commits into
JuliaSmoothOptimizers:mainfrom
arnavk23:main
Jul 27, 2025
Merged

Update jac_lin_coord methods#501
tmigot merged 24 commits into
JuliaSmoothOptimizers:mainfrom
arnavk23:main

Conversation

@arnavk23

@arnavk23 arnavk23 commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

The linear Jacobian part is independent of x, so passing it became unnecessary.

  • jac_lin_coord(nlp, x)jac_lin_coord(nlp)
  • jac_lin_coord!(nlp, x, vals)jac_lin_coord!(nlp, vals)

Closes #404

@amontoison

Copy link
Copy Markdown
Member

@arnavk23 It is a breaking change if we drop the signature with x, we should still support the old API and make it deprecated.

@tmigot tmigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnavk23

Copy link
Copy Markdown
Contributor Author

@tmigot All test have passed except the breakage/upload one.

@arnavk23
arnavk23 requested a review from tmigot July 12, 2025 08:46

@tmigot tmigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnavk23 for these changes. I gave some thoughts about @amontoison 's comment, and it's a good idea to deprecate these functions instead of removing them directly.
Using the macro @deprecate when somebody uses the "old" variant it should receive a warning saying that the function is deprecated and point to the variant.

Comment thread src/nlp/api.jl
Comment thread src/nlp/api.jl
Comment thread src/nlp/api.jl
Comment thread src/nlp/api.jl
Comment thread src/nlp/api.jl
@arnavk23
arnavk23 requested a review from tmigot July 15, 2025 03:36

@tmigot tmigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnavk23 for the changes. I made some comments.
I think we also miss the functions jprod and jtprod

Comment thread src/nlp/api.jl Outdated
Comment thread src/nlp/api.jl Outdated
Comment thread src/nlp/api.jl Outdated
Comment thread src/nlp/api.jl Outdated
Comment thread src/nlp/api.jl Outdated
Comment thread src/nlp/api.jl Outdated
Comment thread src/nlp/api.jl Outdated
Comment thread docs/src/guidelines.md Outdated
arnavk23 and others added 8 commits July 23, 2025 16:38
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
@tmigot

tmigot commented Jul 23, 2025

Copy link
Copy Markdown
Member

We also need to remove the x for the function jprod_lin, jprod_lin!, jtprod_lin and jtprod_lin!

@arnavk23
arnavk23 requested a review from tmigot July 23, 2025 18:49
Comment thread src/nlp/api.jl Outdated
Comment thread src/nlp/api.jl Outdated
Comment thread src/nlp/api.jl
Comment thread src/nlp/api.jl
Comment thread test/nls/api.jl Outdated
Comment thread src/nlp/api.jl Outdated
Comment thread src/nlp/api.jl Outdated
@arnavk23
arnavk23 requested a review from tmigot July 26, 2025 20:29
Comment thread src/nlp/api.jl Outdated
Comment thread test/nlp/simple-model.jl Outdated
Comment thread test/nlp/simple-model.jl Outdated
Comment thread test/nls/simple-model.jl Outdated
Comment thread test/nlp/dummy-model.jl Outdated
arnavk23 and others added 5 commits July 27, 2025 19:19
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
@arnavk23
arnavk23 requested a review from tmigot July 27, 2025 13:57

@tmigot tmigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arnavk23 !

@tmigot
tmigot merged commit 3091fb0 into JuliaSmoothOptimizers:main Jul 27, 2025
72 of 73 checks passed
@klamike klamike mentioned this pull request Nov 20, 2025
amontoison added a commit that referenced this pull request Dec 5, 2025
amontoison added a commit that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jac_lin_coord doesn't need to know x

3 participants