Update jac_lin_coord methods - #501
Conversation
|
@arnavk23 It is a breaking change if we drop the signature with |
tmigot
left a comment
There was a problem hiding this comment.
Thanks @arnavk23 for the PR.
Can you also adapt jac_lin_op and jac_lin_op! https://github.com/arnavk23/NLPModels.jl/blob/504a3c29574998b892d7f598283db466a86e391e/src/nlp/api.jl#L737
|
@tmigot All test have passed except the breakage/upload one. |
tmigot
left a comment
There was a problem hiding this comment.
Thanks @arnavk23 for these changes. I gave some thoughts about @amontoison 's comment, and it's a good idea to deprecate these functions instead of removing them directly.
Using the macro @deprecate when somebody uses the "old" variant it should receive a warning saying that the function is deprecated and point to the variant.
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
|
We also need to remove the |
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
This reverts commit 3091fb0.
This reverts commit 3091fb0.
The linear Jacobian part is independent of
x, so passing it became unnecessary.jac_lin_coord(nlp, x)→jac_lin_coord(nlp)jac_lin_coord!(nlp, x, vals)→jac_lin_coord!(nlp, vals)Closes #404