Skip to content

Commit 9ea82b0

Browse files
committed
fix issues from comment
1 parent 5458f38 commit 9ea82b0

3 files changed

Lines changed: 14 additions & 11 deletions

File tree

packages/insomnia-smoke-test/server/cloud-sync-api.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ const rawBlobs: Record<string, string> = {
287287
'{"_id":"mcp-req_18ee6d8bec7645ada7c4ac48d416bdb0","authentication":{},"connected":false,"created":1769408435331,"description":"","env":[],"headers":[{"name":"User-Agent","value":"insomnia/12.3.0"}],"mcpStdioAccess":false,"parentId":"wrk_efab8e758b97459bab2659d8fdcf8627","roots":[],"sslValidation":true,"subscribeResources":[],"transportType":"streamable-http","type":"McpRequest","url":"http://localhost:4010/mcp"}',
288288
};
289289
const defaultBranches = [{ name: 'master' }, { name: 'develop' }];
290-
const deletedProjectIds: string[] = [];
290+
let deletedProjectIds: string[] = [];
291291
let cloudSyncApiEnabled = false;
292292
let remoteHasNewCommit = false;
293293

@@ -307,6 +307,11 @@ export default function setup(app: Application) {
307307
return res.status(400).json({ error: 'enabled must be boolean value' });
308308
}
309309
cloudSyncApiEnabled = enabled;
310+
if (!enabled) {
311+
// clear the test data when cloud sync is disabled to avoid affecting other tests
312+
deletedProjectIds = [];
313+
remoteHasNewCommit = false;
314+
}
310315
return res.status(200).send();
311316
});
312317

packages/insomnia-smoke-test/tests/smoke/cloud-sync.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ test.describe('Cloud Sync', () => {
147147
// delete workspace locally
148148
await page.getByLabel('My Collection R1').getByTestId('DropdownButton').click();
149149
await page.getByRole('button', { name: 'Delete' }).click();
150-
await page.getByText('Remove Local CopyThe project').click();
150+
await page.getByText('Remove Local Copy').click();
151151
await page.getByRole('button', { name: 'Delete Workspace' }).click();
152152
// check workspace is deleted locally
153153
await expect.soft(page.getByLabel('Collection Project')).toBeVisible();

packages/insomnia/src/ui/components/dropdowns/workspace-card-dropdown.tsx

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -312,24 +312,22 @@ export const WorkspaceCardDropdown: FC<Props> = props => {
312312
aria-label="Remove Local Copy"
313313
className="flex-1 rounded-sm border border-solid border-(--hl-md) p-4 transition-colors hover:bg-(--hl-xs) focus:bg-(--hl-sm) focus:outline-hidden data-disabled:opacity-25 data-selected:border-(--color-surprise) data-selected:ring-2 data-selected:ring-(--color-surprise)"
314314
>
315-
<div className="flex items-center gap-2">
315+
<div>
316316
<Heading className="text-lg font-bold">Remove Local Copy</Heading>
317+
<p className="pt-2">The project will still exist on the Cloud.</p>
317318
</div>
318-
<p className="pt-2">The project will still exist on the Cloud.</p>
319319
</Radio>
320320
<Radio
321321
value="false"
322322
aria-label="Delete Permanently"
323323
className="flex-1 rounded-sm border border-solid border-(--hl-md) p-4 transition-colors hover:bg-(--hl-xs) focus:bg-(--hl-sm) focus:outline-hidden data-disabled:opacity-25 data-selected:border-(--color-surprise) data-selected:ring-2 data-selected:ring-(--color-surprise)"
324324
>
325-
<div className="flex items-center gap-2">
326-
<Heading className="text-lg font-bold">
327-
<span>Delete Permanently</span>
328-
</Heading>
325+
<div>
326+
<Heading className="text-lg font-bold">Delete Permanently</Heading>
327+
<p className="pt-2">
328+
The project will be deleted everywhere. You cannot undo this action.
329+
</p>
329330
</div>
330-
<p className="pt-2">
331-
The project will be deleted everywhere. You cannot undo this action.
332-
</p>
333331
</Radio>
334332
</div>
335333
</RadioGroup>

0 commit comments

Comments
 (0)