Commit 113c90c
committed
refactor: UI primitives, widgets split, brand sources/, SCSS theming
Post-Part-A refinement pass. Seven coherent changes that tighten
naming discipline, deduplicate view SCSS, isolate web sources from
shared HUD vocabulary, and fix the silently-broken brand theming
chain. 23 files staged.
1. Three new shared/components/ui/ primitives
data-point.vue <UiDataPoint> label/value tile (sm | lg)
chip.vue <UiChip> lowercase pill (solid | overflow)
badge.vue <UiBadge> uppercase status pill (active | dim)
Replaced ~12 inline duplicates across stats.vue, card.vue, and
detail.vue. ~40 lines of duplicated SCSS removed from consumers.
All props-in-DOM-out — correctly placed in ui/ (no side-effects).
2. shared/widgets/ split by kind
widgets/audio-meter.vue to widgets/hud/audio-meter.vue
widgets/live-readout.vue to widgets/ui/live-readout.vue
Mirrors the shared/components/hud|ui split: audio-meter is
OBS-coupled (HUD-domain), live-readout is domain-agnostic.
Consumers import via @widgets/hud/* and @widgets/ui/*.
3. Filenames describe purpose, never repeat the alias kind (Rule G)
sections/meta.vue to sections/stats.vue
ui/metric.vue to ui/data-point.vue
ui/status.vue to ui/status-dot.vue
views/utils/parse-emphasis.js to views/utils/markup.js
"meta" was ambiguous (metadata/HTML-meta/meta-programming).
"metric of what?" / "status shown how?" tests failed — multi-
word names answer the question. Modals stay single-word
(base/preview/detail.vue) because @modals/ already supplies
"modal" — base-modal.vue would be redundant. Bindings keep
the kind: <BaseModal>, <UiDataPoint>, <StatsSection>.
4. Utils as topic-based libraries (Rule J)
markup.js holds parseEmphasis as a named export. Future markup
parsers (parseLinks, parseCodeSpans) live in the same file.
Never one-function-per-file. Composables exempt — one useX
per file because hooks own state and lifecycle.
5. Brand folder restructured to mirror src/shared/
@brand/hud/cam-log.vue to @brand/sources/hud/cam-log.vue
@brand/animation/ to @brand/sources/animation/
@brand/scene/ to @brand/sources/scene/
Eliminates the clash where @brand/hud/ (web sources) and @hud/
(shared HUD primitives) both used "hud". brand-loader.js globs
updated; resolveComponent() key pattern now
/<brand>/sources/<type>/<id>.vue. Reserved slots documented
for brand-private components/{hud,ui}/, composables/,
widgets/{hud,ui}/ (created only when 2+ files exist, Rule F).
6. <UiIcon> multi-pool SVG discovery
Previously globbed only @shared/assets/svg/*.svg. Now also
globs /@*/assets/svg/*.svg — any brand can drop SVGs in its
own assets/svg/ folder and reference them by filename. Brand
SVGs override shared SVGs on filename collision (useful for
brand-flavored overrides of shared primitives).
7. Brand theming — SCSS single source of truth
Fixed three silently-broken things:
- @<brand>/styles/_theme.scss was orphaned (never imported).
- brand.js colors duplicated the SCSS values.
- brand.js held only a subset of palette ranges.
Fix: src/main.js eagerly globs /@*/styles/_theme.scss so Vite
bundles every brand theme into global CSS. brand.js lost its
colors field entirely. App.vue dropped brand_theme_vars and
only applies .brand-<handle> on route change — the CSS
cascade does the rest. brand-loader test flipped from "has
colors object" to "does NOT carry colors field" (enforcement).
Verified: grep brand-kyonax-on-tech dist/assets/*.css
matches in the production bundle.
Validation: 27/27 tests pass, 0 lint errors (7 pre-existing
warnings in use-audio-analyzer.js), production build clean in
1.25s.
Modified-by: Cristian D. Moreno (Kyonax) <kyonax25@gmail.com>1 parent 0619e67 commit 113c90c
23 files changed
Lines changed: 477 additions & 384 deletions
File tree
- @kyonax_on_tech
- sources/hud
- styles
- src
- views
- components
- elements
- modals
- sections
- utils
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
| |||
23 | 26 | | |
24 | 27 | | |
25 | 28 | | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | 29 | | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
79 | | - | |
| 78 | + | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
14 | 20 | | |
15 | 21 | | |
| 22 | + | |
16 | 23 | | |
17 | 24 | | |
18 | 25 | | |
19 | 26 | | |
20 | 27 | | |
21 | 28 | | |
22 | 29 | | |
| 30 | + | |
23 | 31 | | |
24 | 32 | | |
25 | 33 | | |
26 | 34 | | |
| 35 | + | |
27 | 36 | | |
28 | 37 | | |
29 | 38 | | |
30 | 39 | | |
31 | 40 | | |
32 | 41 | | |
33 | 42 | | |
| 43 | + | |
34 | 44 | | |
35 | 45 | | |
36 | 46 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
| 8 | + | |
12 | 9 | | |
13 | 10 | | |
14 | 11 | | |
15 | 12 | | |
16 | 13 | | |
17 | | - | |
18 | 14 | | |
19 | 15 | | |
20 | 16 | | |
21 | 17 | | |
22 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | 32 | | |
55 | 33 | | |
56 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
12 | 22 | | |
13 | 23 | | |
14 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
24 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| |||
51 | 53 | | |
52 | 54 | | |
53 | 55 | | |
54 | | - | |
| 56 | + | |
55 | 57 | | |
56 | 58 | | |
57 | 59 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
61 | 61 | | |
62 | | - | |
63 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
64 | 71 | | |
65 | 72 | | |
66 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
0 commit comments