Replace assert with ValueError in PortField validation

Assertions can be stripped with python -O, silently disabling
port range validation. Use ValueError with a descriptive message
instead.

Closes #34

Author: dannywillems

leakix/field.py

@@ -59,7 +59,8 @@ def __init__(self, ip: str, operator: Operator | None = None) -> None:
 
 class PortField(CustomField):
     def __init__(self, port: int, operator: Operator | None = None) -> None:
-        assert 0 <= port < 65536
+        if not (0 <= port < 65536):
+            raise ValueError(f"Port must be between 0 and 65535, got {port}")
         super().__init__(v=str(port), operator=operator, field_name="port")
 
 

tests/test_query.py

@@ -161,11 +161,11 @@ def test_serialize_with_max_port(self) -> None:
         assert field.serialize() == "port:65535"
 
     def test_invalid_port_negative(self) -> None:
-        with pytest.raises(AssertionError):
+        with pytest.raises(ValueError):
             PortField(-1)
 
     def test_invalid_port_too_large(self) -> None:
-        with pytest.raises(AssertionError):
+        with pytest.raises(ValueError):
             PortField(65536)
 
     def test_serialize_with_greater_operator(self) -> None: