fix: add missing tostring() call

[jjangsangy]

Hardware

• OS: Windows 10
• Shell: Powershell 7

Issue Description

When running lua-language-server --check ., the process would throw internal errors during initialization, specifically:
script\locale-loader.lua:5: attempt to index a number value (local 'k')

Root Cause Analysis

The error was traced to the locale-loader.lua script within the lua-language-server installation.

• The en-US locale definition file (meta.lua) contains numeric keys (e.g., utf8.offset[55]).
• The mergeKey function in locale-loader.lua assumed all keys k were strings and attempted to call string methods (k:sub(...)) on them.
• When k was a number (from the array-like part of meta.lua), this caused the crash.

Applied Fix:
Explicitly convert the key k to a string before processing.

Verification

After applying the patch, lua-language-server --check . runs successfully with no initialization errors:
Diagnosis completed, no problems found

[gemini-code-assist]

Summary of Changes

Hello @jjangsangy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical initialization error in the lua-language-server that occurred when numeric keys were encountered during locale loading. By ensuring all keys are explicitly converted to strings before string manipulation, the change prevents crashes and allows the language server to function correctly, thereby improving its robustness and reliability.

Highlights

• Error Fix: Addresses an internal error in lua-language-server when running lua-language-server --check ., specifically an "attempt to index a number value" in locale-loader.lua.
• Root Cause: The error was caused by the mergeKey function in locale-loader.lua attempting to call string methods on numeric keys, which can occur when processing locale definition files like meta.lua.
• Solution: Implemented a fix by explicitly converting the key k to a string using tostring(k) before any string operations are performed on it within the mergeKey function.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a crash in locale-loader.lua caused by attempting to perform string operations on a numeric key from a locale file. The fix, which explicitly converts the key to a string using tostring(), is correct and effectively resolves the issue. The change is minimal and well-targeted. The PR also includes minor stylistic adjustments that improve code consistency. The problem, root cause, and verification are clearly explained in the description. This is a solid bug fix.