Skip to content

Commit 49d3a7b

Browse files
Spencer Bryngelsonclaude
andcommitted
ci: remove dead rm -rf build, add gpu_partition default
- Remove no-op 'rm -rf build' inside 'if [ ! -d build ]' guard in common/test.sh and common/bench.sh. - Default gpu_partition to 'batch' before dynamic selection to prevent unbound variable error if a new cluster is added. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 72c9c86 commit 49d3a7b

File tree

3 files changed

+1
-2
lines changed

3 files changed

+1
-2
lines changed

.github/scripts/submit-slurm-job.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ if [ "$device" = "cpu" ]; then
9595
esac
9696
elif [ "$device" = "gpu" ]; then
9797
# Determine GPU partition
98+
gpu_partition="batch"
9899
if [ "$gpu_partition_dynamic" = "true" ]; then
99100
# Use pre-selected bench partition if available, otherwise query sinfo
100101
if [ -n "${BENCH_GPU_PARTITION:-}" ]; then

.github/workflows/common/bench.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ fi
2323
# --- Build (if not pre-built on login node) ---
2424
# Phoenix builds inside SLURM; Frontier pre-builds via build.sh on the login node.
2525
if [ ! -d "build" ]; then
26-
rm -rf build
2726
source .github/scripts/retry-build.sh
2827
retry_build ./mfc.sh build -j $n_jobs $build_opts || exit 1
2928
fi

.github/workflows/common/test.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ build_opts="$gpu_opts"
1111
# --- Build (if not pre-built on login node) ---
1212
# Phoenix builds inside SLURM; Frontier pre-builds via build.sh on the login node.
1313
if [ ! -d "build" ]; then
14-
rm -rf build
1514
source .github/scripts/retry-build.sh
1615

1716
# Phoenix: smoke-test the syscheck binary to catch architecture mismatches

0 commit comments

Comments
 (0)