Microblog: appended image links do not contain all images

[safetycar]

Describe the bug
Some posts don't display all the images.

On which Mbin instance did you find the bug?
fedia.io

Which Mbin version was running on the instance?
1.9.1

To Reproduce

• Look at this fedia.io entry which contains a imageset in fedia.io (screenshot below).
• See that the expand links and the default image are both the same, and there is no other image visible.
• Go to the original and see that it contains 2 different images (screenshot below).

Expected behavior
There should be a way to see both images but it is not always the case.

Screenshots
Fedia:

Original:

Desktop (please complete the following information):

• Windows
• Firefox
• 149.0

Smartphone (please complete the following information):

Additional context
I have made some code searches in the repo without following them too deep.

But I'm very suspicious of this array_shift:
https://github.com/MbinOrg/mbin/blob/main/src/Service/ActivityPubManager.php#L960

Together with picking the tallest image:
https://github.com/MbinOrg/mbin/blob/main/src/Service/ActivityPubManager.php#L520-L524

If my suspicion is correct the first image was discarded because it was originally expected to be used as the main image but then stopped being the case because of the second.

[BentiGorlich]

Duplicate of #1645

[safetycar]

I can see that there is some similarity with the other issue.

But I'm what I was trying to say is that in the expand links there is one image link missing.
There are images that you can't see from the current instance without moving to the other.

If only at least all links appeared even if in some cases it can be a duplicate of the main image, it probably would be better than the case where there are images missing.

[BentiGorlich]

The link is inserted for each attached image. But since we can only save one image you only get one link. It is the exact same issue regarding the code :)

[safetycar]

Sorry to insist, It's just that I don't think we are talking about the same thing.

For example this is an original post:

And this is one in fedia:

There are 3 buttons that say "image/jpeg". And actually now that I pay more attention is still the case that there is already a duplicate when there is an image missing.

The image for display is an added bonus from my pov, What I see as a bigger issue is having one of the original links missing.

[BentiGorlich]

Ok, I just looked at the code and the place where the problem is is somewhere around here:

mbin/src/Service/ActivityPub/Note.php

Line 199 in 4bde932

if ($media = $this->objectExtractor->getExternalMediaBody($object)) {

We actually append a links to all images we could not save to the post. So this is not in the original post, that is why I was confused. However this is the patch to at least have the possibility to look at the pictures missing on our end. This would still be solved by just having the ability to save all pictures locally, but since this is a bug in our code, I reopened the issue. And yeah it is the array_shift that is introducing this problem I think:

mbin/src/Service/ActivityPubManager.php

Line 960 in 0f8a444

array_shift($images);

That did probably work sometime, but since we changed it to use the highest resolution image it does not work anymore