code error in helpers/genNetCDF/Topography.py

[wwwliye]

question1: in Topography.py, in function "genHill": j = (np.arange(self.nx) - self.ny/2) / self.ny * np.pi *2, is this nx should be ny?

question2: in icar, if all variables's levels must be same? in wrfout data , vertical velocity w's levels are u's levels plus 1,
when running icar, there will be some errors.

question3: also in Topography.py, is Schar's advection test's code correct?, in Schar's article in 2004, I don't found the same formula ,especially "hgt = (
hill_height *
self.h_x(ig, lmbda) * self.h_x_star( ig, a)
)" , that make me very confused

hope your reply, thank you !

[gutmann]

Hi @wwwliye thanks for filing this issue.

Q1: I think @scrasmussen assigned himself to fix this, it does look like there is an inconsistency there.

Q2: ICAR does not read in the "w" field, so it shouldn't be an issue. At one point, ICAR had an option to interpolate, e.g. Z and P if they were on interface levels instead of mass levels, though I think that functionality may have been dropped with the move to v2. I recommend having all forcing data on the same levels.

Q3: I am not sure, this may have used a different topographic hill than in Christoph Schar's paper, I'm not sure if @scrasmussen or @bertjebertjek are best to answer this one.

[scrasmussen]

question1: in Topography.py, in function "genHill": j = (np.arange(self.nx) - self.ny/2) / self.ny * np.pi *2, is this nx should be ny?

Thank you for pointing this out! It will be fixed in an upcoming PR.

question3: also in Topography.py, is Schar's advection test's code correct?, in Schar's article in 2004, I don't found the same formula ,especially "hgt = ( hill_height * self.h_x(ig, lmbda) * self.h_x_star( ig, a) )" , that make me very confused

In the paper, on pdf page 7 and page 2465 is the following diagram:

and in the second column's second paragraph we find "For all tests we use a computational domain that is confined above by a rigid lid at H 5 25 km and that is periodic in the x direction."

This should match up to the generated file? I'll ping the person who wrote this to double check my interpretation is correct, @bertjebertjek.

[bertjebertjek]

Hey, sorry for the late reply.
wrt the Schaer's topography, I dont recall where i got the formula from. Potentially from @d-reynolds , or I made it up myself? Anyway, it looks pretty similar to me: