Skip to content

Tessellation API update #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ktangsali merged 1 commit into from
Nov 10, 2025
Merged

Tessellation API update #272

ktangsali merged 1 commit into from
Nov 10, 2025

Conversation

@ktangsali
Copy link
Collaborator

@ktangsali ktangsali commented Nov 6, 2025

PhysicsNeMo Pull Request

Description

Tessellation API changed in upstream. This fix updates sym implementation.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@ktangsali ktangsali changed the base branch from main to 2.3.0-rc November 6, 2025 19:04
@ktangsali ktangsali requested a review from coreyjadams November 6, 2025 19:05
@ktangsali
Copy link
Collaborator Author

ktangsali commented Nov 6, 2025

/blossom-ci

coreyjadams
coreyjadams reviewed Nov 6, 2025
View reviewed changes
Copy link
Collaborator

@coreyjadams coreyjadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern here is the derivative syntax. I'm not sure what was done / intended in the past, but for sure the SDF function in physicsnemo is not returning a derivative.

Thoughts?

@ktangsali
Copy link
Collaborator Author

ktangsali commented Nov 7, 2025

/blossom-ci

2 similar comments
@ktangsali
Copy link
Collaborator Author

ktangsali commented Nov 7, 2025

/blossom-ci

@ktangsali
Copy link
Collaborator Author

ktangsali commented Nov 10, 2025

/blossom-ci

@ktangsali ktangsali merged commit a094673 into NVIDIA:2.3.0-rc Nov 10, 2025
1 check passed
@ktangsali ktangsali deleted the tessellation-api-update branch November 10, 2025 03:45
coreyjadams pushed a commit that referenced this pull request Nov 25, 2025
@ktangsali
2.3.0 rc Rebase 1 (#276)
fe9f6b5 
* Update package versions (#270)

* Update to use the new tessellation API (#272)

* update versions
@coreyjadams coreyjadams mentioned this pull request Jan 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coreyjadams coreyjadams coreyjadams approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ktangsali @coreyjadams