refactor: simplify uninstall.sh to only handle service and binary removal

Agent unregistration and config directory cleanup are already handled by
the Go code (tryUnregisterAgent and cleanupDataDirs). Remove the redundant
unregister_from_server and remove_config functions from the shell script.

The script now only does what Go code cannot: stop/disable/remove the
systemd/launchd service and delete the binary.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: andystime

scripts/uninstall.sh

@@ -1,14 +1,15 @@
 #!/bin/sh
 # GPU Go (ggo) Uninstallation Script
-# Usage: curl -sfL https://cdn.tensor-fusion.ai/archive/gpugo/uninstall.sh | sh
+#
+# When called from `ggo uninstall`, this script only handles service and binary
+# removal. Agent unregistration and config directory cleanup are done by the
+# Go code before/after this script runs.
+#
+# When called standalone (curl | sh), it still works but won't unregister the
+# agent from the server — users should run `ggo uninstall` instead.
 #
 # Environment variables:
 #   - GGO_INSTALL_DIR: Installation directory (default: /usr/local/bin)
-#
-# This script will:
-#   - Stop and remove the systemd service (Linux)
-#   - Remove the ggo binary
-#   - Clean up config directories
 
 set -e
 
@@ -57,22 +58,21 @@ remove_systemd_service() {
     if ! command -v systemctl >/dev/null 2>&1; then
         return 0
     fi
-    
+
     if [ ! -d /run/systemd/system ]; then
         return 0
     fi
-    
+
     SERVICE_FILE="/etc/systemd/system/${SYSTEMD_SERVICE_NAME}.service"
-    
+
     if [ ! -f "${SERVICE_FILE}" ]; then
         info "Systemd service not found, skipping..."
         return 0
     fi
-    
+
     info "Stopping systemd service..."
     SUDO=$(get_sudo)
 
-    # Stop and disable service, remove file, reload daemon (using cached sudo credentials)
     ${SUDO} systemctl stop "${SYSTEMD_SERVICE_NAME}" 2>/dev/null || true
 
     info "Disabling systemd service..."
@@ -83,24 +83,22 @@ remove_systemd_service() {
 
     info "Reloading systemd daemon..."
     ${SUDO} systemctl daemon-reload
-    
+
     info "Systemd service removed successfully!"
 }
 
 # --- Stop launchd service (macOS) ---
 remove_launchd_service() {
     PLIST_FILE="$HOME/Library/LaunchAgents/ai.tensor-fusion.ggo-agent.plist"
     PLIST_FILE_SYSTEM="/Library/LaunchDaemons/ai.tensor-fusion.ggo-agent.plist"
-    
-    # Check user launch agent
+
     if [ -f "${PLIST_FILE}" ]; then
         info "Stopping launchd user agent..."
         launchctl unload "${PLIST_FILE}" 2>/dev/null || true
         rm -f "${PLIST_FILE}"
         info "User launch agent removed!"
     fi
-    
-    # Check system launch daemon
+
     if [ -f "${PLIST_FILE_SYSTEM}" ]; then
         info "Stopping launchd system daemon..."
         SUDO=$(get_sudo)
@@ -113,11 +111,10 @@ remove_launchd_service() {
 # --- Remove binary ---
 remove_binary() {
     BINARY_PATH="${INSTALL_DIR}/${BINARY_NAME}"
-    
+
     if [ ! -f "${BINARY_PATH}" ]; then
         info "Binary not found at ${BINARY_PATH}, checking common locations..."
-        
-        # Check common locations
+
         for dir in /usr/local/bin /usr/bin /opt/bin "$HOME/.local/bin" "$HOME/bin"; do
             if [ -f "${dir}/${BINARY_NAME}" ]; then
                 BINARY_PATH="${dir}/${BINARY_NAME}"
@@ -126,17 +123,16 @@ remove_binary() {
             fi
         done
     fi
-    
+
     if [ ! -f "${BINARY_PATH}" ]; then
         warn "ggo binary not found"
         return 0
     fi
-    
+
     info "Removing binary at ${BINARY_PATH}..."
 
     SUDO=$(get_sudo)
 
-    # Check if we need sudo
     if [ -w "$(dirname "${BINARY_PATH}")" ]; then
         if rm -f "${BINARY_PATH}" 2>/dev/null; then
             info "Binary removed!"
@@ -155,175 +151,14 @@ remove_binary() {
     fi
 }
 
-# --- Remove config directories ---
-remove_config() {
-    info "Removing configuration directories..."
-    
-    # User config
-    CONFIG_DIRS="$HOME/.config/ggo $HOME/.ggo $HOME/.gpugo"
-    
-    for dir in ${CONFIG_DIRS}; do
-        if [ -d "${dir}" ]; then
-            info "Removing ${dir}..."
-            rm -rf "${dir}"
-        fi
-    done
-    
-    # System config (Linux)
-    SUDO=$(get_sudo)
-    SYSTEM_DIRS="/var/lib/ggo /etc/ggo"
-    local system_cleanup_failed=false
-
-    for dir in ${SYSTEM_DIRS}; do
-        if [ -d "${dir}" ]; then
-            info "Removing ${dir}..."
-            if ${SUDO} rm -rf "${dir}" 2>/dev/null; then
-                info "Successfully removed ${dir}"
-            else
-                warn "Failed to remove ${dir} (permission denied or sudo not available)"
-                system_cleanup_failed=true
-            fi
-        fi
-    done
-    
-    # Root config (if running as root or with sudo)
-    local root_cleanup_failed=false
-    if [ "$(id -u)" -eq 0 ] || [ -n "$(get_sudo)" ]; then
-        if [ -d "/root/.config/ggo" ]; then
-            if ${SUDO} rm -rf "/root/.config/ggo" 2>/dev/null; then
-                info "Removed /root/.config/ggo"
-            else
-                warn "Failed to remove /root/.config/ggo (permission denied)"
-                root_cleanup_failed=true
-            fi
-        fi
-        if [ -d "/root/.ggo" ]; then
-            if ${SUDO} rm -rf "/root/.ggo" 2>/dev/null; then
-                info "Removed /root/.ggo"
-            else
-                warn "Failed to remove /root/.ggo (permission denied)"
-                root_cleanup_failed=true
-            fi
-        fi
-        if [ -d "/root/.gpugo" ]; then
-            if ${SUDO} rm -rf "/root/.gpugo" 2>/dev/null; then
-                info "Removed /root/.gpugo"
-            else
-                warn "Failed to remove /root/.gpugo (permission denied)"
-                root_cleanup_failed=true
-            fi
-        fi
-    else
-        # Check if root directories exist but we can't remove them
-        if [ -d "/root/.config/ggo" ] || [ -d "/root/.ggo" ] || [ -d "/root/.gpugo" ]; then
-            warn "Root configuration directories exist but sudo is not available"
-            root_cleanup_failed=true
-        fi
-    fi
-
-    info "Configuration directories removed!"
-
-    # Warn about manual cleanup if root cleanup failed
-    if [ "${root_cleanup_failed}" = "true" ] || [ "${system_cleanup_failed}" = "true" ]; then
-        echo ""
-        warn "==============================================="
-        warn "  MANUAL CLEANUP REQUIRED"
-        warn "==============================================="
-        warn "Some configuration directories could not be removed automatically."
-        warn "Please run the following commands with appropriate permissions:"
-        warn ""
-        if [ "${system_cleanup_failed}" = "true" ]; then
-            for dir in ${SYSTEM_DIRS}; do
-                if [ -d "${dir}" ]; then
-                    warn "  sudo rm -rf ${dir}"
-                fi
-            done
-        fi
-        if [ -d "/root/.config/ggo" ]; then
-            warn "  sudo rm -rf /root/.config/ggo"
-        fi
-        if [ -d "/root/.ggo" ]; then
-            warn "  sudo rm -rf /root/.ggo"
-        fi
-        if [ -d "/root/.gpugo" ]; then
-            warn "  sudo rm -rf /root/.gpugo"
-        fi
-        warn "==============================================="
-        echo ""
-    fi
-}
-
-# --- Unregister from server ---
-unregister_from_server() {
-    # Search for ggo binary in multiple locations
-    local binary_path=""
-    local search_paths="${GGO_INSTALL_DIR:-/usr/local/bin}/${BINARY_NAME} /usr/local/bin/${BINARY_NAME} /usr/bin/${BINARY_NAME} /opt/bin/${BINARY_NAME} ${HOME}/.local/bin/${BINARY_NAME} ${HOME}/bin/${BINARY_NAME}"
-
-    for path in ${search_paths}; do
-        if [ -f "${path}" ] && [ -x "${path}" ]; then
-            binary_path="${path}"
-            break
-        fi
-    done
-
-    if [ -z "${binary_path}" ]; then
-        warn "ggo binary not found in common locations, skipping server unregistration"
-        warn "Searched: ${search_paths}"
-        return 0
-    fi
-
-    info "Unregistering agent from server (using binary at ${binary_path})..."
-
-    # Check if agent config exists in root directory (agent mode)
-    # If so, we need to run unregister with sudo
-    local needs_sudo=false
-    SUDO=$(get_sudo)
-
-    # Try to check for root config files (need sudo to access root's home)
-    if [ -n "${SUDO}" ]; then
-        if ${SUDO} test -f "/root/.gpugo/config/config.json" || \
-           ${SUDO} test -f "/root/.gpugo/config/agent.yaml" || \
-           ${SUDO} test -f "/root/.config/ggo/agent.yaml"; then
-            needs_sudo=true
-            info "Agent config found in root directory, using sudo for unregistration"
-        fi
-    fi
-
-    # Run unregister command (don't suppress output so user can see what happened)
-    # When using sudo, explicitly specify root's config dir since the command
-    # defaults to the calling user's home directory, not root's
-    local unregister_result=0
-    if [ "${needs_sudo}" = "true" ]; then
-        SUDO=$(get_sudo)
-        if [ -n "${SUDO}" ]; then
-            ${SUDO} "${binary_path}" agent unregister --config-dir /root/.gpugo/config --force || unregister_result=$?
-        else
-            warn "Sudo not available, attempting unregister without sudo (may fail)"
-            "${binary_path}" agent unregister --force || unregister_result=$?
-        fi
-    else
-        "${binary_path}" agent unregister --force || unregister_result=$?
-    fi
-
-    # Check result - exit code 0 means command succeeded (either unregistered or was not registered)
-    if [ ${unregister_result} -eq 0 ]; then
-        # Success - either unregistered or wasn't registered, both are fine
-        :
-    else
-        warn "Server unregistration failed (exit code: ${unregister_result})"
-        warn "Local config will still be removed"
-        warn "You may need to manually remove the agent from the server dashboard"
-    fi
-}
-
 # --- Main uninstallation ---
 main() {
     OS=$(detect_os)
-    
+
     if [ "${OS}" = "windows" ]; then
         fatal "Windows uninstallation is not supported by this script. Please use uninstall.ps1 or uninstall.bat instead."
     fi
-    
+
     echo ""
     echo "=========================================="
     echo "  GPU Go (ggo) Uninstaller"
@@ -338,10 +173,7 @@ main() {
         ${SUDO} -v 2>/dev/null || true
     fi
 
-    # Unregister from server (before removing binary and config)
-    unregister_from_server
-
-    # Remove services based on OS (graceful stop)
+    # Stop and remove service
     if [ "${OS}" = "linux" ]; then
         remove_systemd_service
     elif [ "${OS}" = "darwin" ]; then
@@ -350,10 +182,7 @@ main() {
 
     # Remove binary
     remove_binary
-    
-    # Remove config
-    remove_config
-    
+
     echo ""
     echo "=========================================="
     echo "  Uninstallation Complete!"