-
Notifications
You must be signed in to change notification settings - Fork 42
Proposal for ...clamp nodes #46
Description
Hello there, I am using the node pack a lot, thank you for that first of all! 🙏
Aside from its alpha and image composition management, it offers the ...clamp nodes, acting as passthroughs, which allows structuring group nodes perfectly.
Almost all workflow I build and publish use group nodes, and thus your node pack.
However unfortunately there is a node pack named ComfyUI-LatentClamp which actually misleads the "Find missing nodes" function of the Comfy Manager enough to result in users unknowingly installing the wrong pack, which obviously breaks my workflows and results in confused users asking for support.
Given the fact that it would be a small and quick change to rename the line of ...clamp nodes in this pack, and the fact that they don't actually clamp anything, I wanted to suggest renaming them, to solve this issue and improve the naming to be self-descriptive by calling them ...pass instead.
So basically all of "Clamp.py": ModelClamp → Model Pass ,...
I would also suggest a few additions to fill existing gaps, such as passthroughs for types: INT, FLOAT, NUMBER, STRING, DICT
In case you agree with the proposal, I could implement the changes and submit a PR if you're short on time.
Thank you for your time and efforts!
Best Regards