[19.0][MIG] crm_phonecall

Author: eugenios73

crm_phonecall/README.rst

@@ -1,3 +1,7 @@
+.. image:: https://odoo-community.org/readme-banner-image
+   :target: https://odoo-community.org/get-involved?utm_source=readme
+   :alt: Odoo Community Association
+
 ===============
 CRM Phone Calls
 ===============
@@ -13,17 +17,17 @@ CRM Phone Calls
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
     :target: https://odoo-community.org/page/development-status
     :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github
-    :target: https://github.com/OCA/crm/tree/18.0/crm_phonecall
+    :target: https://github.com/OCA/crm/tree/19.0/crm_phonecall
     :alt: OCA/crm
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall
+    :target: https://translation.odoo-community.org/projects/crm-19-0/crm-19-0-crm_phonecall
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/crm&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/crm&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -61,7 +65,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/crm/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/crm/issues/new?body=module:%20crm_phonecall%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/crm/issues/new?body=module:%20crm_phonecall%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -99,6 +103,9 @@ Contributors
   - Antoni Marroig <amarroig@apsl.net>
 
 - Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>
+- `Studio73 <https://studio73.es>`__:
+
+  - Eugenio Micó <eugenio@studio73.es>
 
 Maintainers
 -----------
@@ -113,6 +120,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/crm <https://github.com/OCA/crm/tree/18.0/crm_phonecall>`_ project on GitHub.
+This module is part of the `OCA/crm <https://github.com/OCA/crm/tree/19.0/crm_phonecall>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

crm_phonecall/__manifest__.py

@@ -3,7 +3,7 @@
 
 {
     "name": "CRM Phone Calls",
-    "version": "18.0.1.0.2",
+    "version": "19.0.1.0.0",
     "category": "Customer Relationship Management",
     "author": "Odoo S.A., Tecnativa, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/crm",

crm_phonecall/models/crm_phonecall.py

@@ -60,7 +60,6 @@ class CrmPhonecall(models.Model):
         column2="tag_id",
     )
     partner_phone = fields.Char(string="Phone")
-    partner_mobile = fields.Char("Mobile")
     priority = fields.Selection(
         selection=[("0", "Low"), ("1", "Normal"), ("2", "High")],
         default="1",
@@ -77,15 +76,13 @@ def _onchange_partner_id(self):
         """Contact number details should be change based on partner."""
         if self.partner_id:
             self.partner_phone = self.partner_id.phone
-            self.partner_mobile = self.partner_id.mobile
 
     @api.onchange("opportunity_id")
     def _onchange_opportunity_id(self):
         """Based on opportunity, change contact, tags, partner, team."""
         if self.opportunity_id:
             self.team_id = self.opportunity_id.team_id.id
             self.partner_phone = self.opportunity_id.phone
-            self.partner_mobile = self.opportunity_id.mobile
             self.partner_id = self.opportunity_id.partner_id.id
             self.tag_ids = self.opportunity_id.tag_ids.ids
 
@@ -123,7 +120,6 @@ def get_values_schedule_another_phonecall(self, vals):
             "team_id": vals.get("team_id") or self.team_id.id,
             "partner_id": self.partner_id.id,
             "partner_phone": self.partner_phone,
-            "partner_mobile": self.partner_mobile,
             "priority": self.priority,
             "opportunity_id": self.opportunity_id.id,
             "campaign_id": self.campaign_id.id,
@@ -198,7 +194,6 @@ def _prepare_opportunity_vals(self):
             "name": self.name,
             "partner_id": self.partner_id.id,
             "phone": self.partner_phone or self.partner_id.phone,
-            "mobile": self.partner_mobile or self.partner_id.mobile,
             "email_from": self.partner_id.email,
             "team_id": self.team_id.id,
             "description": self.description,

crm_phonecall/readme/CONTRIBUTORS.md

@@ -14,3 +14,5 @@
 - [APSL-Nagarro](https://apsl.tech):
   - Antoni Marroig  \<<amarroig@apsl.net>\>
 - Heliconia Solutions Pvt. Ltd. \<<https://www.heliconia.io>\>
+- [Studio73](https://studio73.es):
+  - Eugenio Micó  \<<eugenio@studio73.es>\>

crm_phonecall/report/crm_phonecall_report_view.xml

@@ -28,7 +28,7 @@
         <field name="name">By Sales Team</field>
         <field name="model_id">crm.phonecall.report</field>
         <field name="domain">[('state','=','done')]</field>
-        <field eval="False" name="user_id" />
+        <field name="user_ids" eval="False" />
         <field name="context">
             {'group_by': ['team_id'], 'pivot_measures': ['nbr_cases', 'duration']}
         </field>
@@ -37,7 +37,7 @@
         <field name="name">Delay To Close</field>
         <field name="model_id">crm.phonecall.report</field>
         <field name="domain">[('state','=','done')]</field>
-        <field eval="False" name="user_id" />
+        <field name="user_ids" eval="False" />
         <field name="context">
             {'group_by': ['team_id'], 'pivot_measures': ['delay_close']}
         </field>
@@ -46,7 +46,7 @@
         <field name="name">Phone Calls To Do</field>
         <field name="model_id">crm.phonecall.report</field>
         <field name="domain">[('state','in',('draft','open'))]</field>
-        <field eval="False" name="user_id" />
+        <field name="user_ids" eval="False" />
         <field name="context">
             {'group_by': ['team_id'], 'pivot_measures': ['nbr_cases']}
         </field>
@@ -97,7 +97,7 @@
                     string="Sales Team"
                 />
                 <field name="user_id" string="Salesperson" />
-                <group expand="0" string="Extended Filters...">
+                <group>
                     <field
                         filter_domain="[('partner_id','child_of',self)]"
                         name="partner_id"
@@ -106,7 +106,7 @@
                     <field name="opening_date" />
                     <field name="date_closed" />
                 </group>
-                <group expand="1" string="Group By">
+                <group>
                     <filter
                         context="{'group_by':'user_id'}"
                         name="Salesperson"
@@ -148,7 +148,7 @@
         <field name="name">Phone Calls Analysis</field>
         <field name="res_model">crm.phonecall.report</field>
         <field name="view_mode">pivot,graph</field>
-        <field name="context">{'search_default_team_id': active_id}</field>
+        <field name="context">{'search_default_team_id': id}</field>
     </record>
     <menuitem
         action="crm_phonecall_report_action"

crm_phonecall/security/crm_security.xml

@@ -2,10 +2,8 @@
 <odoo>
     <record id="group_scheduled_calls" model="res.groups">
         <field name="name">Show Scheduled Calls Menu</field>
-        <field name="category_id" ref="base.module_category_hidden" />
     </record>
     <record id="group_show_form_view" model="res.groups">
         <field name="name">Enable form view for phone calls</field>
-        <field name="category_id" ref="base.module_category_hidden" />
     </record>
 </odoo>

crm_phonecall/static/description/index.html

@@ -3,7 +3,7 @@
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
-<title>CRM Phone Calls</title>
+<title>README.rst</title>
 <style type="text/css">
 
 /*
@@ -360,16 +360,21 @@
 </style>
 </head>
 <body>
-<div class="document" id="crm-phone-calls">
-<h1 class="title">CRM Phone Calls</h1>
+<div class="document">
 
+
+<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme">
+<img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" />
+</a>
+<div class="section" id="crm-phone-calls">
+<h1>CRM Phone Calls</h1>
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:2593b2153817e6f354a6c439ac5e080a95dbe9676e3808ff05c220a83a4a0ca0
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/crm/tree/18.0/crm_phonecall"><img alt="OCA/crm" src="https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/crm-18-0/crm-18-0-crm_phonecall"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/crm&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/crm/tree/19.0/crm_phonecall"><img alt="OCA/crm" src="https://img.shields.io/badge/github-OCA%2Fcrm-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/crm-19-0/crm-19-0-crm_phonecall"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/crm&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module allows to manage phone calls in order to analyze them.</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
@@ -386,7 +391,7 @@ <h1 class="title">CRM Phone Calls</h1>
 </ul>
 </div>
 <div class="section" id="usage">
-<h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-1">Usage</a></h2>
 <p>To use this module, you need to:</p>
 <ol class="arabic simple">
 <li>Go to <em>CRM &gt; Phone Calls &gt; Logged Calls &gt; New</em>.</li>
@@ -400,31 +405,31 @@ <h1><a class="toc-backref" href="#toc-entry-1">Usage</a></h1>
 </ol>
 </div>
 <div class="section" id="known-issues-roadmap">
-<h1><a class="toc-backref" href="#toc-entry-2">Known issues / Roadmap</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-2">Known issues / Roadmap</a></h2>
 <ul class="simple">
 <li>Simplify the function schedule_another_phonecall returning always a
 recordset</li>
 </ul>
 </div>
 <div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/crm/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/crm/issues/new?body=module:%20crm_phonecall%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/crm/issues/new?body=module:%20crm_phonecall%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h1><a class="toc-backref" href="#toc-entry-4">Credits</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-4">Credits</a></h2>
 <div class="section" id="authors">
-<h2><a class="toc-backref" href="#toc-entry-5">Authors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-5">Authors</a></h3>
 <ul class="simple">
 <li>Odoo S.A.</li>
 <li>Tecnativa</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-6">Contributors</a></h3>
 <ul class="simple">
 <li>Odoo S.A.</li>
 <li><a class="reference external" href="https://www.tecnativa.com">Tecnativa</a><ul>
@@ -448,21 +453,26 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 </ul>
 </li>
 <li>Heliconia Solutions Pvt. Ltd. &lt;<a class="reference external" href="https://www.heliconia.io">https://www.heliconia.io</a>&gt;</li>
+<li><a class="reference external" href="https://studio73.es">Studio73</a>:<ul>
+<li>Eugenio Micó &lt;<a class="reference external" href="mailto:eugenio&#64;studio73.es">eugenio&#64;studio73.es</a>&gt;</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h3>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org">
 <img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
 </a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/crm/tree/18.0/crm_phonecall">OCA/crm</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/crm/tree/19.0/crm_phonecall">OCA/crm</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
 </div>
+</div>
 </body>
 </html>

crm_phonecall/tests/test_crm_phonecall.py

@@ -20,13 +20,10 @@ def setUpClass(cls):
             {
                 "name": "Partner1",
                 "phone": "123 456 789",
-                "mobile": "123 456 789",
                 "type": "contact",
             }
         )
-        cls.partner2 = partner_obj.create(
-            {"name": "Partner2", "phone": "789 654 321", "mobile": "789 654 321"}
-        )
+        cls.partner2 = partner_obj.create({"name": "Partner2", "phone": "789 654 321"})
         cls.phonecall1 = cls.env["crm.phonecall"].create(
             {
                 "name": "Call #1 for test",
@@ -40,7 +37,6 @@ def setUpClass(cls):
             {
                 "name": "Call #2 for test",
                 "partner_phone": "123 456 789",
-                "partner_mobile": "987 654 321",
                 "campaign_id": cls.campaign1.id,
                 "source_id": cls.source1.id,
                 "medium_id": cls.medium1.id,
@@ -50,23 +46,20 @@ def setUpClass(cls):
             {
                 "name": "Opportunity #1",
                 "phone": "111 111 111",
-                "mobile": "222 222 222",
                 "partner_id": cls.partner1.id,
             }
         )
         cls.opportunity2 = cls.env["crm.lead"].create(
             {
                 "name": "Opportunity #2",
                 "phone": "222 222 222",
-                "mobile": "333 333 333",
                 "partner_id": cls.partner2.id,
             }
         )
-        cls.tag = cls.env.ref("sales_team.categ_oppor1")
 
     def test_compute_phonecall_count_partner(self):
         partner = self.env["res.partner"].create(
-            {"name": "Partner3", "phone": "123 654 007", "mobile": "123 654 007"}
+            {"name": "Partner3", "phone": "123 654 007"}
         )
         phonecall = self.env["crm.phonecall"].create(
             {
@@ -80,7 +73,7 @@ def test_compute_phonecall_count_partner(self):
 
     def test_compute_duration(self):
         partner = self.env["res.partner"].create(
-            {"name": "Partner4", "phone": "123 456 007", "mobile": "123 456 007"}
+            {"name": "Partner4", "phone": "123 456 007"}
         )
         phonecall = self.env["crm.phonecall"].create(
             {
@@ -98,7 +91,6 @@ def test_onchange_partner(self):
         phonecall_form.partner_id = self.partner2
         phonecall_form.save()
         self.assertEqual(self.phonecall1.partner_phone, self.partner2.phone)
-        self.assertEqual(self.phonecall1.partner_mobile, self.partner2.mobile)
         self.assertFalse(self.phonecall1.date_closed)
         self.phonecall1.state = "done"
         self.assertTrue(self.phonecall1.date_closed)
@@ -112,7 +104,6 @@ def test_schedule_another_phonecall(self):
                 "schedule_time": False,
                 "name": "Test schedule method",
                 "action": "schedule",
-                "tag_ids": self.tag.ids,
             }
         )[self.phonecall1.id]
         self.assertNotEqual(phonecall2.id, self.phonecall1.id)
@@ -155,7 +146,6 @@ def test_convert2opportunity(self):
         result = self.phonecall2.action_button_convert2opportunity()
         lead = self.env["crm.lead"].browse(result["res_id"])
         self.assertEqual(lead.phone, self.phonecall2.partner_phone)
-        self.assertEqual(lead.mobile, self.phonecall2.partner_mobile)
 
     def test_make_meeting(self):
         """Make a meeting test."""