-
Notifications
You must be signed in to change notification settings - Fork 116
Description
Desired capability or behavior.
Currently the default height-energy and 2dof phase_infos have a phase_info_parameterization which changes the mission definition to match variables like design cruise altitude in the aircraft csv. This is not done consistently across all phase_infos in the codebase. The AviaryProblem has a special api defined just for phase_info_parameterization that can accept one of these defined functions. When using the L1 or CMD interface, it automatically uses any parameterization found, which changes phase_info without telling the user, and you have no way of turning it off without removing the parameterization function from the phase_info. In L2, it does not automatically do the parameterization unless the user imports the function from their phase_info file and manually provides it during add_phases()
TL;DR phase_info_parameterization is a hacky way to try and reconcile the fact that some mission information exists in the csv that we may want to use in a mission, but it is implemented in a very inconsistent and hard to use way. It is also completely undocumented, and users have to custom define the function every time (there is no template or default).
In my opinion, we should completely remove it, as a proper fix probably requires overhauling a good chunk of how we handle mission & aircraft definition (i.e. Aviary 2.0), and I don't want us to have to continue to support this in the meantime.