Add GITHUB_RUN_ID guards to Actions/Environments/Releases tests; add repo null checks; decouple teamPrefix from teamName in Teams tests

Author: MariusStorhaug

tests/Actions.Tests.ps1

@@ -19,6 +19,9 @@ BeforeAll {
     $testName = 'Actions'
     $os = $env:RUNNER_OS
     $id = $env:GITHUB_RUN_ID
+    if (-not $id) {
+        throw 'GITHUB_RUN_ID is required for Actions tests because it is used to build repository-scoped names for OIDC operations.'
+    }
 }
 
 Describe 'Actions' {
@@ -59,6 +62,9 @@ Describe 'Actions' {
                     $repo = $null
                 } else {
                     $repo = Get-GitHubRepository -Owner $Owner -Name $repoName
+                    if (-not $repo) {
+                        throw "Shared test repository '$repoName' was not found for owner '$Owner' (OwnerType: '$OwnerType'). Ensure the repository was provisioned and the repository name is correct."
+                    }
                     Write-Host ($repo | Select-Object * | Out-String)
                 }
             }

tests/Environments.Tests.ps1

@@ -23,6 +23,9 @@ BeforeAll {
     $testName = 'Environments'
     $os = $env:RUNNER_OS
     $id = $env:GITHUB_RUN_ID
+    if (-not $id) {
+        throw 'GITHUB_RUN_ID is required for Environments tests.'
+    }
 }
 
 Describe 'Environments' {
@@ -46,6 +49,9 @@ Describe 'Environments' {
 
             LogGroup "Using Repository - [$repoName]" {
                 $repo = Get-GitHubRepository -Owner $Owner -Name $repoName
+                if (($OwnerType -notin ('repository', 'enterprise')) -and (-not $repo)) {
+                    throw "Shared test repository '$repoName' was not found for owner '$Owner'. Ensure the repository was created before running the environment tests."
+                }
                 Write-Host ($repo | Select-Object * | Out-String)
             }
         }

tests/Releases.Tests.ps1

@@ -23,6 +23,9 @@ BeforeAll {
     $testName = 'Releases'
     $os = $env:RUNNER_OS
     $id = $env:GITHUB_RUN_ID
+    if (-not $id) {
+        throw 'GITHUB_RUN_ID must be set for run-scoped release tests.'
+    }
 }
 
 Describe 'Releases' {
@@ -45,6 +48,9 @@ Describe 'Releases' {
 
             LogGroup "Using Repository - [$repoName]" {
                 $repo = Get-GitHubRepository -Owner $Owner -Name $repoName
+                if (-not $repo) {
+                    throw "Expected shared test repository '$Owner/$repoName' was not found. Get-GitHubRepository returned no result, so release tests cannot continue."
+                }
                 Write-Host ($repo | Select-Object * | Out-String)
             }
         }

tests/Teams.Tests.ps1

@@ -44,19 +44,18 @@ Describe 'Teams' {
                 }
             }
             $teamPrefix = "$testName`_$os`_$TokenType`_$id"
-            $teamName = $teamPrefix
 
             switch ($OwnerType) {
                 'organization' {
-                    Get-GitHubTeam -Organization $owner | Where-Object { $_.Name -like "$teamName*" } | Remove-GitHubTeam -Confirm:$false
+                    Get-GitHubTeam -Organization $owner | Where-Object { $_.Name -like "$teamPrefix*" } | Remove-GitHubTeam -Confirm:$false
                 }
             }
         }
 
         AfterAll {
             switch ($OwnerType) {
                 'organization' {
-                    $teamsToRemove = Get-GitHubTeam -Organization $owner | Where-Object { $_.Name -like "$teamName*" }
+                    $teamsToRemove = Get-GitHubTeam -Organization $owner | Where-Object { $_.Name -like "$teamPrefix*" }
                     LogGroup 'Teams to remove' {
                         Write-Host "$($teamsToRemove | Format-List | Out-String)"
                     }