Skip to content

Commit c8bf992

Browse files
committed
chore(code): bump diffs package version
1 parent 5ed6aa4 commit c8bf992

8 files changed

Lines changed: 72 additions & 17 deletions

File tree

apps/code/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@
101101
"@opentelemetry/semantic-conventions": "^1.39.0",
102102
"@parcel/watcher": "^2.5.6",
103103
"@phosphor-icons/react": "^2.1.10",
104-
"@pierre/diffs": "^1.1.21",
104+
"@pierre/diffs": "^1.2.10",
105105
"@posthog/agent": "workspace:*",
106106
"@posthog/api-client": "workspace:*",
107107
"@posthog/core": "workspace:*",

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"dependencies": {
1919
"@modelcontextprotocol/ext-apps": "^1.1.2",
2020
"@modelcontextprotocol/sdk": "^1.12.1",
21-
"@pierre/diffs": "^1.1.21",
21+
"@pierre/diffs": "^1.2.10",
2222
"@posthog/api-client": "workspace:*",
2323
"@posthog/di": "workspace:*",
2424
"@posthog/platform": "workspace:*",

packages/core/src/code-review/diffAnnotations.test.ts

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import type { FileDiffMetadata } from "@pierre/diffs";
22
import { describe, expect, it } from "vitest";
33
import {
4+
buildCommentMergedOptions,
45
buildDraftAnnotations,
56
buildHunkAnnotations,
67
getLastChangeLineNumber,
@@ -80,3 +81,24 @@ describe("buildDraftAnnotations", () => {
8081
});
8182
});
8283
});
84+
85+
describe("buildCommentMergedOptions", () => {
86+
it.each([
87+
{ hasOpenComment: false, expectedEnabled: true },
88+
{ hasOpenComment: true, expectedEnabled: false },
89+
])(
90+
"with hasOpenComment=$hasOpenComment sets selection/gutter enabled=$expectedEnabled and routes both callbacks to the handler",
91+
({ hasOpenComment, expectedEnabled }) => {
92+
const handler = () => {};
93+
const merged = buildCommentMergedOptions(
94+
undefined,
95+
hasOpenComment,
96+
handler,
97+
);
98+
expect(merged.enableLineSelection).toBe(expectedEnabled);
99+
expect(merged.enableGutterUtility).toBe(expectedEnabled);
100+
expect(merged.onLineSelectionEnd).toBe(handler);
101+
expect(merged.onGutterUtilityClick).toBe(handler);
102+
},
103+
);
104+
});

packages/core/src/code-review/diffAnnotations.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,5 +61,6 @@ export function buildCommentMergedOptions(
6161
enableLineSelection: !hasOpenComment,
6262
enableGutterUtility: !hasOpenComment,
6363
onLineSelectionEnd: handleLineSelectionEnd,
64+
onGutterUtilityClick: handleLineSelectionEnd,
6465
};
6566
}

packages/ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
"@lezer/highlight": "^1.2.3",
5353
"@modelcontextprotocol/ext-apps": "^1.1.2",
5454
"@modelcontextprotocol/sdk": "^1.12.1",
55-
"@pierre/diffs": "^1.1.21",
55+
"@pierre/diffs": "^1.2.10",
5656
"@posthog/agent": "workspace:*",
5757
"@posthog/api-client": "workspace:*",
5858
"@posthog/core": "workspace:*",

packages/ui/src/features/code-review/constants.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ export const DIFF_METRICS = {
99
lineHeight: 20,
1010
diffHeaderHeight: 31,
1111
hunkSeparatorHeight: 32,
12-
fileGap: 8,
12+
spacing: 8,
1313
} as const;

pnpm-lock.yaml

Lines changed: 44 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pnpm-workspace.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ minimumReleaseAgeExclude:
5151
- '@anthropic-ai/claude-agent-sdk-win32-x64'
5252
- '@anthropic-ai/sdk'
5353
- '@pierre/diffs'
54+
- '@pierre/theming'
5455
- '@posthog/quill'
5556
- '@posthog/quill-tokens'
5657
- '@tanstack/devtools-core'

0 commit comments

Comments
 (0)