Skip to content

Commit f855ab4

Browse files
refactor(inbox): polish health checks copy and docs link
Address review feedback: - Toggle/responder copy now recommends keeping health checks enabled and notes it detects PostHog integration problems and suggests fixes automatically. - Point the docs link at https://posthog.com/docs/sdk-health. - Drop the inbox CLAUDE.md note added for this source. Generated-By: PostHog Code Task-Id: 2b579b6c-3075-475e-8a1f-021df07cb260
1 parent 1e57831 commit f855ab4

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

packages/ui/src/features/inbox/CLAUDE.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ When adding or changing UI, reuse those primitives first. Avoid encoding one-off
136136
- Do not put page-level Inbox title or navigation into the global app header; `InboxView` owns the Inbox page chrome.
137137
- Do not add a configure shortcut back into the Inbox header; Responders configuration is a sidebar destination.
138138
- Scout (`signals_scout`) is a real Cloud source product. Keep it covered wherever source products surface: `INBOX_SOURCE_OPTIONS`, `SOURCE_PRODUCT_META`, and the scout-name display in `SignalCard`.
139-
- Health checks (`health_checks` / `health_issue`) is a real Cloud source product — instrumentation issues (missing events, proxy gaps, outdated SDKs) surfaced from PostHog's health checks. Keep it covered wherever source products surface: the `SourceProduct` union, `SignalSourceConfig`, the source toggle (`SignalSourceToggles`, `useSignalSourceToggles`, `signalSourceService`), `SOURCE_PRODUCT_META`, `INBOX_SOURCE_OPTIONS`, and the source line in `SignalCard`.
140139
- Scout management UI (fleet configuration, run history) lives in `features/scouts/` and is backed by the PostHog Cloud scout endpoints (`/api/projects/{teamId}/signals/scout/`). Do not add scout controls that have no backing endpoint there.
141140
- Do not put preview shims or mock report data in `apps/code/index.html`; the app shell should stay minimal.
142141
- Do not call `electronTRPC` directly from Inbox code. Use the existing API client, React Query hooks, or tRPC client wrappers.

packages/ui/src/features/inbox/components/SignalSourceToggles.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,12 +335,12 @@ export function SignalSourceToggles({
335335
<SignalSourceToggleCard
336336
icon={<HeartbeatIcon size={20} />}
337337
label="Health checks"
338-
description="Instrumentation issues — missing events, proxy gaps, outdated SDKs"
338+
description="Recommended — detects problems with your PostHog integration (missing events, proxy gaps, outdated SDKs) and automatically suggests fixes."
339339
checked={value.health_checks}
340340
onCheckedChange={toggleHealthChecks}
341341
disabled={disabled}
342342
syncStatus={sourceStates?.health_checks?.syncStatus}
343-
docsUrl="https://posthog.com/docs/product-analytics/troubleshooting"
343+
docsUrl="https://posthog.com/docs/sdk-health"
344344
docsLabel="Health checks"
345345
/>
346346
<SignalSourceToggleCard

packages/ui/src/features/inbox/components/responderAgentMeta.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ export const RESPONDER_AGENT_GROUPS: ResponderAgentGroup[] = [
3535
sourceProduct: "health_checks",
3636
label: "Health checks",
3737
description:
38-
"Instrumentation issues – missing events, proxy gaps, outdated SDKs.",
39-
docsUrl: "https://posthog.com/docs/product-analytics/troubleshooting",
38+
"Recommended — detects problems with your PostHog integration and suggests fixes automatically.",
39+
docsUrl: "https://posthog.com/docs/sdk-health",
4040
docsLabel: "Health checks",
4141
},
4242
{

0 commit comments

Comments
 (0)