support starting serve-d autocomplete with old DCD versions

Author: WebFreak001

source/served/backend/lazy_workspaced.d

@@ -26,6 +26,11 @@ class LazyWorkspaceD : WorkspaceD
 			return wasAccessed;
 		}
 
+		bool isPending(string component) const
+		{
+			return lazyComponents.any!(c => c.info.name == component);
+		}
+
 		void onLazyLoad(string component, LazyLoadHook hook)
 		{
 			foreach (com; instanceComponents)

source/served/extension.d

@@ -445,13 +445,29 @@ void doGlobalStartup(UserConfiguration config)
 						action = translate!"d.ext.compileProgram"("DCD");
 					else
 						action = translate!"d.ext.downloadProgram"("DCD");
+					string continueAnyway = translate!"d.served.ignoreDCDUpdate";
 
-					auto res = rpc.window.requestMessage(MessageType.error, outdatedMessage, [
-							action
-						]);
+					string[] actions = [action, continueAnyway];
+					if (!backend.has!DCDComponent)
+						actions.length--;
+
+					auto res = rpc.window.requestMessage(MessageType.error, outdatedMessage, actions);
 
 					if (res == action)
 						spawnFiber("updateDCD", (&updateDCD).toDelegate);
+					else if (res == continueAnyway)
+					{
+						import served.backend.lazy_workspaced : LazyWorkspaceD;
+
+						backend.get!DCDComponent.ignoreOutdatedForSession();
+						dcdUpdating = false;
+						foreach (instance; backend.instances) {
+							if (auto lazyInstance = cast(LazyWorkspaceD.LazyInstance) instance) {
+								if (!lazyInstance.isPending("dcd"))
+									startDCDServer(instance, instance.cwd.uriFromFile);
+							}
+						}
+					}
 				});
 			}
 		}

views/de.txt

@@ -166,6 +166,7 @@ d.coverage.tooltip: Testabdeckung in dieser Datei wurde aus der zugehörigen .ls
 
 d.served.failDCD: Konnte DCD nicht starten. (Projekt={0}, Pfad={1}, {2})
 d.served.outdatedDCD: DCD ist veraltet. (gesucht={0}, installiert={1})
+d.served.ignoreDCDUpdate: Trotzdem verwenden
 d.served.failDscanner: Konnte DScanner nicht starten. (Projekt={0}, Pfad={1})
 d.served.tooManySubprojects.path: Nach Einstellung d.manyProjectsThreshold sind zu viele Projekte in dieser Projektmappe.\n\nSoll `{0}` geladen werden?
 d.served.tooManySubprojects.load: Alle Laden

views/en.txt

@@ -172,6 +172,7 @@ d.coverage.tooltip: Coverage in this file generated from the according .lst file
 
 d.served.failDCD: Could not start DCD. (root={0}, path={1}, {2})
 d.served.outdatedDCD: DCD is outdated. (target={0}, installed={1})
+d.served.ignoreDCDUpdate: Continue anyway
 d.served.failDscanner: Could not start DScanner. (root={0}, path={1})
 d.served.tooManySubprojects.path: There are too many subprojects in this project according to d.manyProjectsThreshold\n\nDo you want to load `{0}`?
 d.served.tooManySubprojects.load: Load

workspace-d/source/workspaced/com/dcd.d

@@ -41,8 +41,8 @@ class DCDComponent : ComponentWrapper
 		installedVersion = workspaced.globalConfiguration.get("dcd", "_installedVersion", "");
 
 		if (installedVersion.length
-				&& this.clientPath == workspaced.globalConfiguration.get("dcd", "_clientPath", "")
-				&& this.serverPath == workspaced.globalConfiguration.get("dcd", "_serverPath", ""))
+			&& this.clientPath == workspaced.globalConfiguration.get("dcd", "_clientPath", "")
+			&& this.serverPath == workspaced.globalConfiguration.get("dcd", "_serverPath", ""))
 		{
 			if (workspaced.globalConfiguration.get("dcd", "_usingInternal", false))
 				client = new BuiltinDCDClient();
@@ -68,7 +68,8 @@ class DCDComponent : ComponentWrapper
 		trace("Detected dcd-server ", serverPathInfo, installedVersion);
 
 		if (!checkVersion(installedVersion, BuiltinDCDClient.minSupportedServerInclusive)
-				|| checkVersion(installedVersion, BuiltinDCDClient.maxSupportedServerExclusive))
+			|| checkVersion(installedVersion, BuiltinDCDClient
+				.maxSupportedServerExclusive))
 		{
 			trace("Using dcd-client instead of internal workspace-d client");
 
@@ -93,19 +94,20 @@ class DCDComponent : ComponentWrapper
 		assert(this.clientPath == clientPath);
 		assert(this.serverPath == serverPath);
 
-		//dfmt off
 		if (isOutdated)
 			workspaced.messageHandler.warn(refInstance, "dcd",
 				WarningId.dcdOutdated, "DCD is outdated");
-		//dfmt on
 
 		workspaced.globalConfiguration.set("dcd", "_usingInternal",
-				cast(ExternalDCDClient) client ? false : true);
+			cast(ExternalDCDClient) client ? false : true);
 		workspaced.globalConfiguration.set("dcd", "_clientPath", clientPath);
 		workspaced.globalConfiguration.set("dcd", "_serverPath", serverPath);
 		workspaced.globalConfiguration.set("dcd", "_installedVersion", installedVersion);
 	}
 
+	// using both static and __gshared because it didn't work without both for me, but I couldn't isolate it
+	static __gshared bool ignoreOutdatedThisSession = false; // @suppress(dscanner.unnecessary.duplicate_attribute)
+
 	/// Returns: true if DCD version is less than latestKnownVersion or if server and client mismatch or if it doesn't exist.
 	bool isOutdated()
 	{
@@ -123,19 +125,28 @@ class DCDComponent : ComponentWrapper
 			}
 		}
 
+		if (ignoreOutdatedThisSession)
+			return false;
+
 		if (installedVersion.isLocallyCompiledDCD)
 			return false;
 
 		return !checkVersion(installedVersion, latestKnownVersion);
 	}
 
+	/// During the runtime of this serve-d run, ignore DCD outdated warnings.
+	void ignoreOutdatedForSession()
+	{
+		ignoreOutdatedThisSession = true;
+	}
+
 	/// Returns: The current detected installed version of dcd-client.
 	///          Ends with `"-workspaced-builtin"` if this is using the builtin
 	///          client.
 	string clientInstalledVersion() @property const
 	{
-		return cast(ExternalDCDClient) client ? installedVersion :
-			BuiltinDCDClient.clientVersion ~ "-workspaced-builtin";
+		return cast(ExternalDCDClient) client ? installedVersion
+			: BuiltinDCDClient.clientVersion ~ "-workspaced-builtin";
 	}
 
 	/// Returns: The current detected installed version of dcd-server. `null` if
@@ -208,7 +219,8 @@ class DCDComponent : ComponentWrapper
 
 		client.runningPort = port;
 		client.socketFile = buildPath(tempDir,
-				"workspace-d-sock" ~ thisProcessID.to!string ~ "-" ~ uniform!ulong.to!string(36));
+			"workspace-d-sock" ~ thisProcessID.to!string ~ "-"
+				~ uniform!ulong.to!string(36));
 
 		string[] serverArgs;
 		static if (platformSupportsDCDUnixSockets)
@@ -218,7 +230,7 @@ class DCDComponent : ComponentWrapper
 
 		trace("Start dcd-server ", serverArgs);
 		serverPipes = raw(serverArgs ~ imports,
-				Redirect.stdin | Redirect.stderr | Redirect.stdoutToStderr);
+			Redirect.stdin | Redirect.stderr | Redirect.stdoutToStderr);
 		while (!serverPipes.stderr.eof)
 		{
 			string line = serverPipes.stderr.readln();
@@ -361,8 +373,11 @@ class DCDComponent : ComponentWrapper
 				}
 
 				ret.finish(client.requestSymbolSearch(query)
-					.map!(a => DCDSearchResult(a.symbolFilePath,
-					cast(int)a.symbolLocation, [cast(char) a.kind].idup)).array);
+					.map!(a => DCDSearchResult(
+					a.symbolFilePath,
+					cast(int) a.symbolLocation,
+					[cast(char) a.kind].idup
+					)).array);
 			}
 			catch (Throwable t)
 			{
@@ -382,7 +397,9 @@ class DCDComponent : ComponentWrapper
 	void addImports(string[] imports)
 	{
 		imports.sort!"a<b";
-		knownImports = multiwayUnion([knownImports.filterNonEmpty, imports.filterNonEmpty]).array;
+		knownImports = multiwayUnion([
+			knownImports.filterNonEmpty, imports.filterNonEmpty
+		]).array;
 		updateImports();
 	}
 
@@ -596,7 +613,7 @@ class DCDComponent : ComponentWrapper
 					{
 						calltips ~= item.definition;
 						symbols ~= DCDCompletions.Symbol(item.symbolFilePath,
-							cast(int)item.symbolLocation, item.documentation);
+							cast(int) item.symbolLocation, item.documentation);
 					}
 					completions._calltips = calltips.data;
 					completions._symbols = symbols.data;
@@ -608,9 +625,9 @@ class DCDComponent : ComponentWrapper
 					foreach (item; c.completions)
 					{
 						identifiers ~= DCDIdentifier(item.identifier,
-							item.kind == char.init ? "" : [cast(char)item.kind].idup,
+							item.kind == char.init ? "" : [cast(char) item.kind].idup,
 							item.definition, item.symbolFilePath,
-							cast(int)item.symbolLocation, item.documentation,
+							cast(int) item.symbolLocation, item.documentation,
 							item.typeOf);
 					}
 					completions._identifiers = identifiers.data;
@@ -680,12 +697,14 @@ private:
 
 	auto raw(string[] args, Redirect redirect = Redirect.all)
 	{
-		return pipeProcess(args, redirect, null, Config.none, refInstance ? instance.cwd : null);
+		return pipeProcess(args, redirect, null, Config.none, refInstance
+				? instance.cwd : null);
 	}
 
 	auto rawExec(string[] args)
 	{
-		return execute(args, null, Config.none, size_t.max, refInstance ? instance.cwd : null);
+		return execute(args, null, Config.none, size_t.max, refInstance
+				? instance.cwd : null);
 	}
 
 	bool isSocketRunning(string socket)