Simplify Nimbus setup params handling to isinstance-only check

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: rickwierenga

pylabrobot/hamilton/liquid_handlers/nimbus/chatterbox.py

@@ -30,15 +30,8 @@ def __init__(self, num_channels: int = 8):
   async def setup(self, backend_params: Optional[BackendParams] = None):
     from .pip_backend import NimbusPIPBackend
 
-    if backend_params is None:
-      params = NimbusSetupParams()
-    elif isinstance(backend_params, NimbusSetupParams):
-      params = backend_params
-    else:
-      raise TypeError(
-        "NimbusChatterboxDriver.setup expected NimbusSetupParams | None for backend_params, "
-        f"got {type(backend_params).__name__}"
-      )
+    if not isinstance(backend_params, NimbusSetupParams):
+      backend_params = NimbusSetupParams()
 
     # Use canned addresses (skip TCP connection entirely)
     pipette_address = Address(1, 1, 257)
@@ -53,10 +46,10 @@ async def setup(self, backend_params: Optional[BackendParams] = None):
     self._nimbus_resolved = NimbusResolvedInterfaces.from_resolution_map(self._resolved_interfaces)
 
     self.pip = NimbusPIPBackend(
-      driver=self, deck=params.deck, address=pipette_address, num_channels=self._num_channels
+      driver=self, deck=backend_params.deck, address=pipette_address, num_channels=self._num_channels
     )
     self.door = NimbusDoor(driver=self, address=door_address)
-    if params.require_door_lock and self.door is None:
+    if backend_params.require_door_lock and self.door is None:
       raise RuntimeError("DoorLock is required but not available on this instrument.")
 
   async def stop(self):

pylabrobot/hamilton/liquid_handlers/nimbus/driver.py

@@ -133,15 +133,8 @@ async def setup(self, backend_params: Optional[BackendParams] = None):
     Args:
       backend_params: Optional :class:`NimbusSetupParams`.
     """
-    if backend_params is None:
-      params = NimbusSetupParams()
-    elif isinstance(backend_params, NimbusSetupParams):
-      params = backend_params
-    else:
-      raise TypeError(
-        "NimbusDriver.setup expected NimbusSetupParams | None for backend_params, "
-        f"got {type(backend_params).__name__}"
-      )
+    if not isinstance(backend_params, NimbusSetupParams):
+      backend_params = NimbusSetupParams()
 
     # TCP connection + Protocol 7 + Protocol 3 + root discovery
     await super().setup()
@@ -186,12 +179,12 @@ async def setup(self, backend_params: Optional[BackendParams] = None):
 
     # Create backends — each object stores its own address and state
     self.pip = NimbusPIPBackend(
-      driver=self, deck=params.deck, address=pipette_address, num_channels=num_channels
+      driver=self, deck=backend_params.deck, address=pipette_address, num_channels=num_channels
     )
 
     if door_address is not None:
       self.door = NimbusDoor(driver=self, address=door_address)
-    elif params.require_door_lock:
+    elif backend_params.require_door_lock:
       raise RuntimeError("DoorLock is required but not available on this instrument.")
 
     # Initialize subsystems

pylabrobot/hamilton/liquid_handlers/nimbus/nimbus.py

@@ -44,20 +44,11 @@ async def setup(self, backend_params: Optional[BackendParams] = None):
     runs InitializeSmartRoll, and wires the PIP capability frontend to the driver's
     PIP backend.
     """
-    if backend_params is None:
-      params = NimbusSetupParams(deck=self.deck)
-    elif isinstance(backend_params, NimbusSetupParams):
-      params = backend_params
-      if params.deck is None:
-        params = NimbusSetupParams(deck=self.deck, require_door_lock=params.require_door_lock)
-    else:
-      raise TypeError(
-        "Nimbus.setup expected NimbusSetupParams | None for backend_params, "
-        f"got {type(backend_params).__name__}"
-      )
+    if not isinstance(backend_params, NimbusSetupParams):
+      backend_params = NimbusSetupParams(deck=self.deck)
 
     try:
-      await self.driver.setup(backend_params=params)
+      await self.driver.setup(backend_params=backend_params)
 
       self.pip = PIP(backend=self.driver.pip)
       self._capabilities = [self.pip]