FEATURE: Complete Apple Intelligence workout summary integration

[Rektoooooo]

🤖 Added comprehensive AI-powered workout analysis with:

• Weekly workout data fetching and processing
• Apple Intelligence API integration with structured prompts
• Real-time streaming UI with partially generated content
• Beautiful card-based summary layout with insights

📊 Key Features:

• Fetches completed workouts from past 7 days via DayStorage
• Generates personalized insights, trends, and recommendations
• Displays key stats, personal records, and areas of concern
• Streaming UI updates as AI generates content
• Apple Intelligence themed design with floating clouds

🔧 Technical Implementation:

• WorkoutSummarizer: Apple Intelligence session management
• WorkoutDataFetcher: SwiftData integration with proper date handling
• AISummaryView: Comprehensive UI with PartiallyGenerated support
• WorkoutSummary: Structured data models for AI analysis

💡 AI Analysis Includes:

• Weekly performance overview and key achievements
• Volume, strength, and consistency trends
• Personal record detection and celebration
• Form issues and recovery recommendations
• Specific actionable advice for next week

🎨 UI Components:

• Motivational headlines and progress summaries
• Visual trend indicators and severity markers
• Personal record celebration cards
• Issue tracking with priority levels
• Actionable recommendation cards

🐛 Fixes:

• Resolved SwiftData predicate compilation errors
• Fixed PartiallyGenerated array handling
• Corrected date format matching for DayStorage
• Removed unnecessary session breakdown for cleaner UI

🤖 Generated with Claude Code

[claude]

Code Review: Apple Intelligence Workout Summary Integration

✅ Strengths

• Well-structured implementation - Good separation of concerns with dedicated components for data fetching, summarization, and UI
• Comprehensive feature set - Covers key aspects: trends, PRs, stats, issues, and recommendations
• Good UI/UX patterns - Streaming updates, loading states, and error handling are properly implemented
• Clean SwiftUI code - Follows modern SwiftUI patterns with @StateObject, @Environment, and proper view composition

🔍 Issues & Recommendations

1. Missing Input Validation (Security)

• WorkoutDataFetcher.swift: No validation of date ranges or limits on data fetched
• Recommendation: Add bounds checking and limit max date range to prevent excessive memory usage

2. Force Unwrapping & Error Handling

• Multiple uses of force unwrapping that could crash the app
• WorkoutSummarizer.swift:114: Missing error handling in async stream
• Recommendation: Replace force unwraps with safe unwrapping, add proper error recovery

3. Performance Concerns

• WorkoutDataFetcher.swift:64-68: Fetching ALL days from database is inefficient
• O(n) lookup for matching day IDs could be slow with large datasets
• Recommendation: Use predicates to filter at database level, not in memory

4. Hard-coded Values

• Magic numbers throughout (3 mins per set, 2 mins rest, etc.)
• Recommendation: Extract to configuration constants or user preferences

5. Missing Test Coverage ⚠️

• No unit tests for data fetching logic
• No tests for AI prompt generation
• No UI tests for the summary view
• Recommendation: Add comprehensive test suite, especially for data transformation logic

6. Memory Management

• AISummaryView.swift: Multiple @State properties could cause retention
• Potential memory leak with streaming responses not being cancelled
• Recommendation: Ensure proper cleanup in onDisappear, cancel streaming on view dismissal

7. Date Handling Issues

• String-based date comparisons ("d MMMM yyyy") are fragile and locale-dependent
• Recommendation: Use Date objects for all comparisons, store dates as timestamps

8. Code Duplication

• Similar card view implementations could be extracted to reusable components
• Recommendation: Create generic SummaryCard component to reduce duplication

🛡️ Security Considerations

• Ensure AI API keys are properly secured (not visible in diff, good!)
• Consider rate limiting AI requests to prevent abuse
• Add input sanitization before sending to AI service

💡 Suggestions for Improvement

1. Add caching mechanism for AI summaries to reduce API calls
2. Implement retry logic with exponential backoff for failed AI requests
3. Add analytics to track feature usage and performance
4. Consider adding export functionality for summaries
5. Add user preferences for summary detail level

📊 Performance Recommendations

1. Implement pagination for large workout histories
2. Add database indexes on frequently queried fields (date, dayId)
3. Consider background processing for heavy computations
4. Cache calculated metrics (duration, volume) in database

Overall, this is a solid implementation with good architecture. The main areas for improvement are test coverage, performance optimization, and error handling. Great work on the UI and feature completeness! 🎯