diff --git a/.claude/skills/review-pr/SKILL.md b/.claude/skills/review-pr/SKILL.md index b825b0085ba..2dbe2a808cb 100644 --- a/.claude/skills/review-pr/SKILL.md +++ b/.claude/skills/review-pr/SKILL.md @@ -64,7 +64,7 @@ For each changed file, check the applicable sections below. Report findings grou - [ ] **If public API changed (new input, changed behavior, removed feature), docs examples are updated** - [ ] Examples consolidated into existing examples — no unnecessary standalone example files - [ ] Every demonstrated feature is user-observable (can the user see it working?) -- [ ] `@sap-ui/common-css` utility classes (`sap-flex`, `sap-margin-*`, `sap-padding-*`) — no inline styles +- [ ] `@fundamental-styles/common-css` utility classes (`sap-flex`, `sap-margin-*`, `sap-padding-*`) — no inline styles - [ ] Individual component imports in examples — no deprecated `*Module` classes ### 6. Breaking Changes diff --git a/.claude/skills/update-docs/SKILL.md b/.claude/skills/update-docs/SKILL.md index 5e206f271e2..ae2a26a1750 100644 --- a/.claude/skills/update-docs/SKILL.md +++ b/.claude/skills/update-docs/SKILL.md @@ -39,7 +39,7 @@ Flag inputs/outputs that exist in the component but are not documented anywhere. For each example file: - [ ] Individual component imports — no deprecated `*Module` classes -- [ ] `@sap-ui/common-css` utility classes — no inline styles where avoidable +- [ ] `@fundamental-styles/common-css` utility classes — no inline styles where avoidable - [ ] Every demonstrated feature is user-observable - [ ] No unnecessary standalone examples (consolidate where possible) - [ ] Example code matches current API (no removed/renamed inputs) diff --git a/apps/docs/src/styles.scss b/apps/docs/src/styles.scss index 57843541884..b60aca314d8 100644 --- a/apps/docs/src/styles.scss +++ b/apps/docs/src/styles.scss @@ -2,7 +2,7 @@ @import 'fundamental-styles/dist/info-label.css'; @import 'fundamental-styles/dist/form-layout-grid.css'; @import '@angular/cdk/overlay-prebuilt.css'; -@import '@sap-ui/common-css/dist/common-css.css'; +@import '@fundamental-styles/common-css/dist/common-css.css'; @include cdk.a11y-visually-hidden(); diff --git a/libs/core/avatar-group/avatar-group.component.scss b/libs/core/avatar-group/avatar-group.component.scss index 925236c55ea..5b84a3b456c 100644 --- a/libs/core/avatar-group/avatar-group.component.scss +++ b/libs/core/avatar-group/avatar-group.component.scss @@ -1,4 +1,4 @@ -@use '@sap-ui/common-css/dist/sass/_common-mixins.scss' as sap; +@use '@fundamental-styles/common-css/dist/sass/_common-mixins.scss' as sap; @use 'fundamental-styles/dist/avatar-group.css'; @mixin fd-avatar-element() { diff --git a/libs/core/combobox/combobox.component.scss b/libs/core/combobox/combobox.component.scss index b3b07180553..78f3b2e5512 100644 --- a/libs/core/combobox/combobox.component.scss +++ b/libs/core/combobox/combobox.component.scss @@ -6,6 +6,10 @@ } } +.fd-combobox-custom-list.fd-list--dropdown .fd-list__item.fd-list__group-header { + border-bottom: var(--sapList_BorderWidth) solid var(--sapList_GroupHeaderBorderColor); +} + .fd-list__item.fd-combobox-list-item { cursor: pointer; } diff --git a/libs/core/link/link.component.scss b/libs/core/link/link.component.scss index ed13226af76..b127e37e74b 100644 --- a/libs/core/link/link.component.scss +++ b/libs/core/link/link.component.scss @@ -1,4 +1,4 @@ -@use '@sap-ui/common-css/dist/sass/_common-mixins.scss' as sap; +@use '@fundamental-styles/common-css/dist/sass/_common-mixins.scss' as sap; @use 'fundamental-styles/dist/link.css'; $block: fd-link; diff --git a/libs/core/multi-combobox/select-all-toggler/select-all-toggler.component.scss b/libs/core/multi-combobox/select-all-toggler/select-all-toggler.component.scss index dcfc8fd35c7..8f8d308b0c5 100644 --- a/libs/core/multi-combobox/select-all-toggler/select-all-toggler.component.scss +++ b/libs/core/multi-combobox/select-all-toggler/select-all-toggler.component.scss @@ -1,4 +1,4 @@ -@use '@sap-ui/common-css/dist/sass/_common-mixins.scss' as sap; +@use '@fundamental-styles/common-css/dist/sass/_common-mixins.scss' as sap; fd-multi-combobox-select-all-toggler { display: block; diff --git a/libs/core/product-switch/product-switch-body/product-switch-body.component.scss b/libs/core/product-switch/product-switch-body/product-switch-body.component.scss index 376efe01e64..bfb53fee2fc 100644 --- a/libs/core/product-switch/product-switch-body/product-switch-body.component.scss +++ b/libs/core/product-switch/product-switch-body/product-switch-body.component.scss @@ -74,24 +74,3 @@ } } } - -// TO DO: to be removed with the adoption of fundamental-styles v0.41.0+ -.fd-product-switch__item { - gap: 0.5rem; -} - -.fd-product-switch__icon [class*='sap-icon'], -.fd-product-switch__icon[class*='sap-icon'] { - margin-block-end: 0; -} - -.fd-product-switch__body.fd-product-switch__body--mobile { - .fd-product-switch__item { - gap: 0.75rem; - } - - .fd-product-switch__icon [class*='sap-icon'], - .fd-product-switch__icon[class*='sap-icon'] { - margin-inline: 0; - } -} diff --git a/libs/core/quick-view/quick-view-group-title/quick-view-group-title.component.html b/libs/core/quick-view/quick-view-group-title/quick-view-group-title.component.html index f67d3692a3a..e5139a63cf4 100644 --- a/libs/core/quick-view/quick-view-group-title/quick-view-group-title.component.html +++ b/libs/core/quick-view/quick-view-group-title/quick-view-group-title.component.html @@ -1,5 +1,8 @@ -