Skip to content

Commit f06bbb9

Browse files
Merge pull request Ancurio#137 from Splendide-Imaginarius/mkxp-z-actions-windows-zip
GitHub Actions: zip Windows artifact before uploading
2 parents d2d46b2 + 6ca7d06 commit f06bbb9

1 file changed

Lines changed: 11 additions & 7 deletions

File tree

.github/workflows/autobuild.yml

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ jobs:
2222
- uses: msys2/setup-msys2@v2
2323
with:
2424
msystem: mingw64
25+
# zip is just used for artifact compression at the end.
2526
install: >-
2627
base-devel
2728
git
@@ -31,6 +32,7 @@ jobs:
3132
mingw-w64-x86_64-meson
3233
mingw-w64-x86_64-autotools
3334
mingw-w64-x86_64-gcc
35+
zip
3436
3537
3638
- name: Checkout repository
@@ -71,17 +73,16 @@ jobs:
7173
cp ../../mkxp.json .
7274
cp -r ../../scripts .
7375
cp ../../assets/LICENSE.mkxp-z-with-https.txt .
76+
cd ..
77+
# Zipping before uploading decreases the upload time considerably.
78+
# Unfortunately this results in double-zipping; tracked at:
79+
# https://github.com/actions/upload-artifact/issues/426
80+
zip -r artifact.zip artifact
7481
7582
- uses: actions/upload-artifact@v3
7683
with:
7784
name: mkxp-z.windows.${{github.event_name == 'pull_request' && format('PR{0}', github.event.number) || github.ref_name}}-${{steps.short-sha.outputs.sha}}
78-
path: |
79-
build/artifact/*.dll
80-
build/artifact/*.exe
81-
build/artifact/mkxp.json
82-
build/artifact/LICENSE.mkxp-z-with-https.txt
83-
build/artifact/scripts/
84-
build/artifact/stdlib/
85+
path: build/artifact.zip
8586

8687
build-linux-native:
8788
name: Ubuntu 22.04 x86_64
@@ -129,6 +130,9 @@ jobs:
129130
cp -r ../../scripts .
130131
cp ../../assets/LICENSE.mkxp-z-with-https.txt .
131132
cd ..
133+
# Zipping before uploading preserves +x permissions.
134+
# Unfortunately this results in double-zipping; tracked at:
135+
# https://github.com/actions/upload-artifact/issues/426
132136
zip -r local.zip local
133137
134138
- uses: actions/upload-artifact@v3

0 commit comments

Comments
 (0)