Skip to content

Commit a1daf77

Browse files
committed
fix github action errors
1 parent 3160b72 commit a1daf77

6 files changed

Lines changed: 14 additions & 16 deletions

File tree

.github/workflows/format-check.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,8 @@ jobs:
2222

2323
- name: Install dependencies
2424
run: |
25-
# Ensure lock file includes dev dependencies
26-
uv lock --dev
27-
# Sync with dev dependencies
28-
uv sync --dev
25+
# Sync with all extras and dev dependencies
26+
uv sync --all-extras --dev
2927
3028
- name: Run ruff format check
3129
run: uv run ruff format --check .

.github/workflows/test.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,8 @@ jobs:
2626

2727
- name: Install dependencies
2828
run: |
29-
# Ensure lock file includes dev dependencies
30-
uv lock --dev
31-
# Sync with dev dependencies
32-
uv sync --dev
29+
# Sync with all extras and dev dependencies
30+
uv sync --all-extras --dev
3331
3432
- name: Run pytest
3533
run: uv run pytest

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ install:
2121
uv sync
2222

2323
install-dev:
24-
uv sync --dev
24+
uv sync --all-extras --dev
2525

2626
lock:
2727
uv lock

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,10 @@ A comprehensive machine learning project template with modern tooling for depend
5959

6060
3. **Install dependencies**:
6161
```bash
62-
uv sync --dev
62+
uv sync --all-extras --dev
6363
```
64+
65+
Note: `--all-extras` is needed because dev dependencies are defined as optional dependencies in `pyproject.toml`.
6466

6567
4. **Generate lock file** (if not present):
6668
```bash
@@ -152,7 +154,7 @@ uv run ruff check --fix .
152154

153155
1. Add the dependency to `pyproject.toml` under `[project.dependencies]` (for production) or `[project.optional-dependencies.dev]` (for development)
154156
2. Run `uv lock` to update the lock file
155-
3. Run `uv sync` to install the new dependency
157+
3. Run `uv sync --all-extras --dev` to install the new dependency (or `uv sync` for production dependencies only)
156158

157159
Example:
158160
```bash

pyproject.toml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ packages = ["src/ml_project_template"]
4040
[tool.ruff]
4141
line-length = 100
4242
target-version = "py311"
43+
44+
[tool.ruff.lint]
4345
select = [
4446
"E", # pycodestyle errors
4547
"W", # pycodestyle warnings
@@ -54,15 +56,15 @@ ignore = [
5456
"B008", # do not perform function calls in argument defaults
5557
]
5658

59+
[tool.ruff.lint.isort]
60+
known-first-party = ["ml_project_template"]
61+
5762
[tool.ruff.format]
5863
quote-style = "double"
5964
indent-style = "space"
6065
skip-magic-trailing-comma = false
6166
line-ending = "auto"
6267

63-
[tool.ruff.isort]
64-
known-first-party = ["ml_project_template"]
65-
6668
[tool.pytest.ini_options]
6769
testpaths = ["tests"]
6870
python_files = ["test_*.py", "*_test.py"]

tests/test_example.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
"""Example test file to demonstrate pytest setup."""
22

3-
import pytest
4-
53

64
def test_example():
75
"""Example test that always passes."""

0 commit comments

Comments
 (0)