The logger drops frame with the "Success" status.

[nickolay168]

Repro steps:

1. Start the tox client, capable to sending video stream in the console (I used qTox).
2. Start the video call with the friend.

Result

The console will have a lot of non informative warnings as follows:
[04:15:03.304 UTC] rtp.c:842 : Warning: RTP send failed (len: 1373)! net error: Success

That happens, because we log failure when get the response error codes different fromTOX_ERR_FRIEND_CUSTOM_PACKET_OK, while we are logging the system error variable (errno), which in this case is "Success".

Proposal

I suggest to add tox error literal into the error:
[05:05:56.437 UTC] rtp.c:870 : Warning: RTP send failed (len: 1373)! tox error: TOX_ERR_FRIEND_CUSTOM_PACKET_SENDQ net error: Success

I would be happy to create a PR with the fix, if I will be allowed to. What is the process of contributing? Should I create a Merge or pull request?

[Green-Sky]

Yes, feel free to open a pr. Much appreciated.

[nickolay168]

I have created the PR with the fix. The gates which ran has passed, the rest are in the waiting state.
Thank you!