Should MTConnect.NET-HTTP-AspNetCore add net8.0 to its TFM matrix?
#161
Replies: 4 comments
-
|
@ottobolyos Yes that is fine to include .NET 8 in the MTConnect.NET-HTTP-AspNetCore project. I don't think that project should really even be needed anymore as it was replaced by the MTConnect.NET-AgentModule-HttpServer. |
Beta Was this translation helpful? Give feedback.
-
|
@PatrickRitchie, thanks for the steer. I'd like to ask two follow-ups on the back of the deprecation hint, then I'll line the work up to match whichever you pick.
Whichever direction you pick, I'll align the docs-site exclusion note in #157 to match—either by dropping the 'the only excluded library' caveat, or by keeping it with a pointer to the removal PR. |
Beta Was this translation helpful? Give feedback.
-
|
@PatrickRitchie, circling back on the two follow‑ups from my previous comment—the docs-site PR (#157) is now ready in shape, and the only remaining edit on it is the |
Beta Was this translation helpful? Give feedback.
-
|
@ottobolyos It is ok to remove the MTConnect.NET-HTTP-AspNetCore project completely from the repo. That project is no longer needed. If you can draft a removal PR that would be helpful. I will take care of the Nuget package. The docs site is looking great! Thanks! |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
@PatrickRitchie, a small TFM-matrix question I'd like a steer on before opening a PR.
libraries/MTConnect.NET-HTTP-AspNetCore/MTConnect.NET-HTTP-AspNetCore.csprojcurrently targetsnetcoreapp3.1;net5.0;net6.0;net7.0for Release andnet6.0for Debug. ItsProjectReferencedeps (MTConnect.NET-HTTP,MTConnect.NET-Common) targetnet8.0on Debug, so the project doesn't build standalone on a stock .NET 8 SDK —dotnet build libraries/MTConnect.NET-HTTP-AspNetCore/...exits withNU1201: Project MTConnect.NET-HTTP is not compatible with net6.0 … supports: net8.0.I noticed it while wiring docfx for the documentation-site PR (#157). Every other shipped library produces an API-reference page; this one is the only library docfx can't load, because there's no
bin/Debug/net8.0/MTConnect.NET-HTTP-AspNetCore.dllon disk.Three plausible directions, none of which I want to pick unilaterally:
net8.0to both Release and Debug TFM lists. Keeps the legacy TFMs and unblocks the docs build. The smallest possible change.net5.0,net6.0, andnet7.0(all out of support) and standardise onnetcoreapp3.1;net8.0. Lighter matrix; anyone still on net5–net7 loses official support.docs/api/index.mdas the sole excluded one, with a one-line pointer.Happy to draft whichever direction you'd prefer — they're all small csproj edits plus, in (1) and (2), a re-run of the docfx pipeline. Just want your call before opening a PR.
Beta Was this translation helpful? Give feedback.
All reactions