fix(test): the android instance now tests true phone geometry

The shared browser setup forced its 1280x720 iframe onto every project —
on the android instance (a 393x727 phone window) the harness then scaled
that desktop-width iframe down to fit, so every suite without its own
per-test viewport was silently testing desktop layout, optically shrunk.
Positional input was displaced by the same transform, which had been
misread as 'mouse idioms don't translate to touch emulation'. The setup
now sizes the iframe per project.

Touch emulation also gets self-healing: Chromium's beyond-viewport
screenshot capture (captureBeyondViewport, sent by Playwright for any
element taller than the viewport) can silently drop the context's touch
emulation. A restoreTouchEmulation command (persistent CDP session —
Emulation overrides revert when their session detaches) re-arms it before
every android test, and ensureTouchEmulation runs as an automatic
assertion right after, so no suite calls it manually anymore. The assert
stays because it guards a different failure than the heal: the mechanism
itself breaking (provider contextOptions silently ignored, an upgrade
rewiring the provider).

At true geometry the include list is re-grounded on one principle,
stated per entry in the config: a suite runs on this instance when it
can go red for a mobile-conditional reason no other suite here pins.
form/ drops out — its popover suite drives the desktop link toolbar
(hover, clipped at phone width) and its Enter mechanics are pinned
red-first by mobile/ and keyboardhandlers/. copypaste/ drops out — the
clipboard path has no platform conditionals at all, and its Enter
presses are setup scaffolding for routes androidEnter pins directly.
emojipicker/ stays: Enter-to-select goes through the suggestion menu's
own key handling, a distinct consumer of the synthesized-Enter route.

Author: YousefED

tests/src/end-to-end/mobile/linkSubmit.test.tsx

@@ -12,7 +12,6 @@ import { render } from "vitest-browser-react";
 import { page, userEvent } from "../../utils/context.js";
 import { EDITOR_SELECTOR, LINK_BUTTON_SELECTOR } from "../../utils/const.js";
 import { waitForSelector } from "../../utils/editor.js";
-import { ensureTouchEmulation } from "../../utils/ensureTouchEmulation.js";
 
 const MOBILE_TOOLBAR_SELECTOR = ".bn-mobile-formatting-toolbar";
 
@@ -33,7 +32,6 @@ const MOBILE_TOOLBAR_SELECTOR = ".bn-mobile-formatting-toolbar";
 // test below; the IME's choice itself stays a release-checklist item.
 
 beforeEach(async () => {
-  ensureTouchEmulation();
   await page.viewport(393, 727);
 });
 

tests/src/end-to-end/mobile/mobileToolbar.test.tsx

@@ -5,7 +5,6 @@ import { render } from "vitest-browser-react";
 import { page, userEvent } from "../../utils/context.js";
 import { EDITOR_SELECTOR, LINK_BUTTON_SELECTOR } from "../../utils/const.js";
 import { focusOnEditor, waitForSelector } from "../../utils/editor.js";
-import { ensureTouchEmulation } from "../../utils/ensureTouchEmulation.js";
 
 const MOBILE_TOOLBAR_SELECTOR = ".bn-mobile-formatting-toolbar";
 const LINK_POPOVER_SELECTOR = ".bn-form-popover";
@@ -41,7 +40,6 @@ function activeUrlInput() {
 }
 
 beforeEach(async () => {
-  ensureTouchEmulation();
   await page.viewport(VIEWPORT_WIDTH, KEYBOARD_CLOSED);
   await render(<App />);
   await waitForSelector(EDITOR_SELECTOR);

tests/src/end-to-end/mobile/popoverScroll.test.tsx

@@ -12,7 +12,6 @@ import { render } from "vitest-browser-react";
 import { page, userEvent } from "../../utils/context.js";
 import { EDITOR_SELECTOR, LINK_BUTTON_SELECTOR } from "../../utils/const.js";
 import { waitForSelector } from "../../utils/editor.js";
-import { ensureTouchEmulation } from "../../utils/ensureTouchEmulation.js";
 
 const MOBILE_TOOLBAR_SELECTOR = ".bn-mobile-formatting-toolbar";
 
@@ -24,7 +23,6 @@ const MOBILE_TOOLBAR_SELECTOR = ".bn-mobile-formatting-toolbar";
 // scroll-into-view chased it to its pre-positioned spot.
 
 beforeEach(async () => {
-  ensureTouchEmulation();
   await page.viewport(393, 727);
 });
 

tests/src/utils/restoreTouchEmulation.ts

@@ -0,0 +1,33 @@
+import type { BrowserCommand } from "vite-plus/test/node";
+
+/**
+ * Re-applies the touch emulation the android instance's Playwright
+ * `contextOptions` established. Chromium's beyond-viewport screenshot
+ * capture (`Page.captureScreenshot` with `captureBeyondViewport: true`,
+ * which Playwright sends for any element taller than the viewport) can
+ * silently drop the context's emulation overrides — `maxTouchPoints`
+ * becomes 0 for every later test. `vitestSetup.browser.ts` calls this
+ * before each file on the android instance.
+ *
+ * The CDP session is deliberately cached and never detached:
+ * Emulation-domain overrides revert when the session that set them
+ * detaches (learned the hard way — a detaching version of this command
+ * *caused* the exact poison it was meant to heal).
+ */
+const sessions = new WeakMap<object, Promise<unknown>>();
+
+export const restoreTouchEmulation: BrowserCommand<[]> = async (ctx) => {
+  let session = sessions.get(ctx.page);
+  if (session === undefined) {
+    session = ctx.context.newCDPSession(ctx.page);
+    sessions.set(ctx.page, session);
+  }
+  const cdp = (await session) as {
+    send(method: string, params: object): Promise<unknown>;
+  };
+  // Exactly what Playwright sends for `hasTouch: true` — and nothing more.
+  // In particular NOT `Emulation.setEmitTouchEventsForMouse`: that converts
+  // real mouse events into touch events, which breaks every userEvent click
+  // (learned the hard way; Playwright never enables it).
+  await cdp.send("Emulation.setTouchEmulationEnabled", { enabled: true });
+};

tests/vite.config.browser.ts

@@ -5,6 +5,7 @@ import { defineConfig, type UserConfig } from "vite-plus";
 import { playwright } from "vite-plus/test/browser/providers/playwright";
 import { positionalMouse } from "./src/utils/positionalMouse.js";
 import { imeComposition } from "./src/utils/imeComposition.js";
+import { restoreTouchEmulation } from "./src/utils/restoreTouchEmulation.js";
 
 // 1280x720 matches the old Playwright defaults so visual baselines have room.
 // Used as the playwright context viewport for every browser instance.
@@ -141,7 +142,7 @@ export default defineConfig(
           // still show in the HTML report (errors + stack traces don't depend
           // on these shots), so disable them. See `e2e:report` to view.
           screenshotFailures: false,
-          commands: { positionalMouse, imeComposition },
+          commands: { positionalMouse, imeComposition, restoreTouchEmulation },
           instances: [
             {
               browser: "chromium",
@@ -188,29 +189,28 @@ export default defineConfig(
                   hasTouch: true,
                 },
               }),
-              // Mobile-specific tests plus the screenshot-free behavioural
-              // suites where Android genuinely differs (IME key handling,
-              // suggestion menus). Those only pass under this emulation with
-              // the Enter fix in this change — before it, every test that
-              // presses Enter to make a second block failed here.
-              //
-              // Keep iframe-screenshotting suites (the exporters'
-              // `screenshotFull` previews) out permanently: Playwright's
-              // element-screenshot path for iframe elements drops the
-              // context's touch emulation for later files (see
-              // utils/ensureTouchEmulation.ts). Individual tests that drive
-              // selection or resizing with positional mouse drags carry
-              // `skipIf(onAndroid)` guards. Not included: indentation (drives
-              // the desktop floating toolbar, clipped at phone width).
+              // One principle decides membership: a suite runs here when it can
+              // go red for a mobile-conditional reason no other suite here
+              // already pins. Tests whose driving idiom doesn't translate to
+              // touch emulation (positional mouse drags) carry
+              // `skipIf(onAndroid)` guards; product behavior is never
+              // skipped. No blanket screenshot suites — android baselines
+              // would double maintenance for viewport-independent artifacts;
+              // mobile visuals get curated tests with their own baselines.
+              // (form/ and copypaste/ were tried and dropped: no distinct
+              // mobile-conditional failure mode — see #3031.)
               include: [
+                // Mobile-specific product behavior: the toolbar/popover
+                // lifecycle, IME delivery routes, touch link taps.
                 "./src/end-to-end/mobile/**/*.test.tsx",
-                // The popover form-submission suites are this instance's
-                // reason to exist — the bugs they guard were Android bugs;
-                // the platform-contract suites pin the browser facts they
-                // rest on under the same mobile emulation.
-                "./src/end-to-end/form/**/*.test.tsx",
+                // The browser facts Form.Root rests on (implicit submission,
+                // composition), re-asserted under mobile emulation flags.
                 "./src/end-to-end/platform/**/*.test.tsx",
+                // Synthesized Enter through the keymap chain — the #3001
+                // fix's primary consumer, exercised across every handler.
                 "./src/end-to-end/keyboardhandlers/**/*.test.tsx",
+                // Synthesized Enter through the suggestion menu's own key
+                // handling — a distinct consumer from the keymap chain.
                 "./src/end-to-end/emojipicker/**/*.test.tsx",
               ],
             },

tests/vitestSetup.browser.ts

@@ -1,5 +1,7 @@
 import { afterEach, beforeAll, beforeEach } from "vite-plus/test";
-import { page } from "vite-plus/test/browser";
+import { commands, page } from "vite-plus/test/browser";
+
+import { ensureTouchEmulation } from "./src/utils/ensureTouchEmulation.js";
 
 // Browser-mode setup. Unlike the jsdom `vitestSetup.ts`, we don't mock
 // ClipboardEvent/DragEvent/matchMedia here — the real browser provides them.
@@ -14,7 +16,15 @@ import { page } from "vite-plus/test/browser";
 // resizes that iframe. Run before all tests in the file so every test sees the
 // right size from the first render.
 beforeAll(async () => {
-  await page.viewport(1280, 720);
+  // On the android instance the outer window is a 393x727 phone (provider
+  // contextOptions) — the iframe must match it exactly. A larger iframe gets
+  // scaled down by the harness's fit-to-window transform, so captures come
+  // out phone-*sized* but contain a shrunken desktop-width layout.
+  if (/android/i.test(navigator.userAgent)) {
+    await page.viewport(393, 727);
+  } else {
+    await page.viewport(1280, 720);
+  }
 
   // Match the playground's editor framing so screenshots line up with what
   // users see at https://www.blocknotejs.org/examples (max-width 731px,
@@ -25,6 +35,24 @@ beforeAll(async () => {
   document.head.appendChild(style);
 });
 
+// Chromium's beyond-viewport screenshot capture (any `toMatchScreenshot` of
+// an element taller than the viewport — Playwright sends
+// `captureBeyondViewport: true`) can silently drop the context's touch
+// emulation for every later test. Before every test on the android instance:
+// re-arm the emulation, then assert it actually holds — the assert is what
+// catches the deeper failure class where the *mechanism* breaks (provider
+// contextOptions silently ignored, a vitest upgrade rewiring the provider,
+// this very command regressing). No suite needs to call
+// `ensureTouchEmulation` itself.
+beforeEach(async () => {
+  if (/android/i.test(navigator.userAgent)) {
+    await (
+      commands as unknown as { restoreTouchEmulation(): Promise<void> }
+    ).restoreTouchEmulation();
+    ensureTouchEmulation();
+  }
+});
+
 beforeEach(() => {
   (window as Window & { __TEST_OPTIONS?: any }).__TEST_OPTIONS = {};
 });