Skip to content

Commit 8be258e

Browse files
committed
Log before marking future as done
1 parent 29adb8f commit 8be258e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

runtime/src/main/java/dev/vankka/dependencydownload/DependencyManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -473,11 +473,11 @@ private CompletableFuture<Void>[] forEachDependency(
473473
Runnable run = () -> {
474474
try {
475475
boolean stepPerformed = runnable.run(dependency);
476-
future.complete(null);
477-
478476
if (stepPerformed) {
479477
successLog.accept(dependency);
480478
}
479+
480+
future.complete(null);
481481
} catch (Throwable t) {
482482
future.completeExceptionally(dependencyException.apply(dependency, t));
483483
failLog.accept(dependency, t);

0 commit comments

Comments
 (0)